Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Pushed to git. Thanks, Carl http://codereview.appspot.com/3099041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Update spacing for Keith Ohara's suggested defaults (issue3099041)

Reviewers: , Message: Here's the new default spacing patch with the new names. Keith, can you check it out? THanks, Carl Description: Update spacing for Keith Ohara's suggested defaults Please review this at http://codereview.appspot.com/3099041/ Affected files: M ly/engraver-init.ly

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Thanks Carl. I marked one (non-essential) change to make the patch equivalent to its final state after discussion at http://lists.gnu.org/archive/html/lilypond-devel/2010-11/msg00177.html Outside of that, looks good to me. http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly File

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Looks good to me, thanks Carl! I'll make .39 once this is applied, but let's wait 24 hours before pushing to give people in all time zones a chance to comment. http://codereview.appspot.com/3099041/ ___ lilypond-devel mailing list

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Thanks, Keith. Done. Carl http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly#newcode418 ly/engraver-init.ly:418: \override VerticalAxisGroup #'nonstaff-unrelatedstaff-spacing

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

On 2010/11/13 22:38:36, Graham Percival wrote: Looks good to me, thanks Carl! I'll make .39 once this is applied, but let's wait 24 hours before pushing to give people in all time zones a chance to comment. OK, I'll wait till tomorrow night. Carl http://codereview.appspot.com/3099041/

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Hi Carl, Just one tiny style nitpick below. Otherwise, looks fine. Thanks, Patrick http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly File ly/paper-defaults-init.ly (right): http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly#newcode60

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Thanks, Patrick. Carl http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly File ly/paper-defaults-init.ly (right): http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly#newcode60 ly/paper-defaults-init.ly:60: system-system-spacing = #'((space . 12)