Re: add \shape (issue 6255056)

2012-06-03 Thread david . nalesnik
On 2012/06/03 19:39:35, janek wrote: Hi David, please close this Rietveld issue (crossed circle next to its name). OK, done. Thanks! David http://codereview.appspot.com/6255056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://li

Re: add \shape (issue 6255056)

2012-06-03 Thread janek . lilypond
Hi David, please close this Rietveld issue (crossed circle next to its name). cheers, Janek http://codereview.appspot.com/6255056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add \shape (issue 6255056)

2012-05-31 Thread Neil Puttock
On 31 May 2012 18:40, wrote: > Thank you for reviewing this, Neil! You're welcome. :) LGTM. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add \shape (issue 6255056)

2012-05-31 Thread david . nalesnik
Thank you for reviewing this, Neil! On 2012/05/31 16:22:53, Neil Puttock wrote: http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly File input/regression/shape-slurs.ly (right): http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly#newcod

Re: add \shape (issue 6255056)

2012-05-31 Thread n . puttock
http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly File input/regression/shape-slurs.ly (right): http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly#newcode5 input/regression/shape-slurs.ly:5: @code{\\shape}. The blue slurs are modified fr

Re: add \shape (issue 6255056)

2012-05-30 Thread graham
LGTM, and I like the regtests. http://codereview.appspot.com/6255056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add \shape (issue 6255056)

2012-05-29 Thread janek . lilypond
it's good! http://codereview.appspot.com/6255056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add \shape (issue 6255056)

2012-05-28 Thread david . nalesnik
On 2012/05/28 20:23:37, janek wrote: generally LGTM. What about coloring the \shaped curves? This would make checking regtests more obvious to an ordinary person who may be not familiar with this stuff. Good idea! I did this for both regression tests. http://codereview.appspot.com/6255

Re: add \shape (issue 6255056)

2012-05-28 Thread janek . lilypond
generally LGTM. What about coloring the \shaped curves? This would make checking regtests more obvious to an ordinary person who may be not familiar with this stuff. thanks, David! http://codereview.appspot.com/6255056/diff/1/input/regression/shape-other-curves.ly File input/regression/shape-

add \shape (issue 6255056)

2012-05-28 Thread david . nalesnik
Reviewers: , Message: Add \shape as a method of modifying the control points of bezier curves. Description: add \shape add \shape as a method of altering bezier curves by offsetting their control-points. Please review this at http://codereview.appspot.com/6255056/ Affected files: A input/reg