Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

LGTM https://codereview.appspot.com/311430043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

New patch set is online that includes an entry in changes.tely and changes the wording of the two places in question. Cheers, Alexander https://codereview.appspot.com/311430043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

On 2016-12-14 23:13, thomasmorle...@gmail.com wrote: Worth an entry in changes? Maybe. Doesn't need a lot, I guess; something like "Accidental rules can now be defined across ChoirStaff contexts. Two new rules choral and choral-cautionary are available that combine the characteristics of

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

Worth an entry in changes? Some wording-nitpicks, otherwise LGTM https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right):

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

Passes make, make check and a full make doc https://codereview.appspot.com/311430043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

On 14/12/16 12:32, Alexander Kobel wrote: Hi James, thanks for taking care of that one. On 2016-12-14 13:15, James wrote: Hello, On 13/12/16 20:10, perpeduumimmob...@gmail.com wrote: Reviewers: , Message: add choral and choral-cautionary accidental style ... Please review this at

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

Hi James, thanks for taking care of that one. On 2016-12-14 13:15, James wrote: Hello, On 13/12/16 20:10, perpeduumimmob...@gmail.com wrote: Reviewers: , Message: add choral and choral-cautionary accidental style ... Please review this at https://codereview.appspot.com/311430043/

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

Hello, On 13/12/16 20:10, perpeduumimmob...@gmail.com wrote: Reviewers: , Message: add choral and choral-cautionary accidental style ... Please review this at https://codereview.appspot.com/311430043/ Affected files (+151, -1 lines): M Documentation/notation/pitches.itely M

add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

Reviewers: , Message: add choral and choral-cautionary accidental style This solves the issues mentioned in https://lists.gnu.org/archive/html/lilypond-user/2016-12/msg00201.html that accidental style could not apply to ChoirStaves in the same way as they did for PianoStaves, StaffGroups or