Re: adding markup-commands \oval and \ellipse (issue 11427044)

2013-07-23 Thread dak
https://codereview.appspot.com/11427044/diff/9001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/11427044/diff/9001/scm/define-markup-commands.scm#newcode416 scm/define-markup-commands.scm:416: (x-padding 0.75) I am not enthused about

Re: adding markup-commands \oval and \ellipse (issue 11427044)

2013-07-22 Thread david . nalesnik
LGTM Thanks for adding these, Harm. https://codereview.appspot.com/11427044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: adding markup-commands \oval and \ellipse (issue 11427044)

2013-07-21 Thread graham
LGTM https://codereview.appspot.com/11427044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

adding markup-commands \oval and \ellipse (issue 11427044)

2013-07-17 Thread thomasmorley65
Reviewers: , Message: Please review. (git-cl seems to work - currently) Description: adding markup-commands \oval and \ellipse \oval and \ellipse are drawing an oval respectively an ellipse around their argument. Also adding a reg-test for markup-commands framing their argument. Please