Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-11 Thread janek . lilypond
Thanks for review! Pushed as commit ab6842155a003ba7d9243507594e3e973ebbb3e4 Author: Janek Warchoł lemniskata.bernoull...@gmail.com Date: Mon Jun 30 22:14:16 2014 +0200 Issue 2462 : don't change ideal spacing when adding a rod When objects like lyrics are added to the PaperColumns,

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-07 Thread Janek Warchoł
Hi, sorry for delayed reply - i had a busy weekend (been on a wedding!) 2014-07-05 19:46 GMT+02:00 Keith OHara k-ohara5...@oco.net: On Fri, 04 Jul 2014 14:38:19 -0700, Janek Warchoł janek.lilyp...@gmail.com wrote: 2014-07-04 23:26 GMT+02:00 Janek Warchoł janek.lilyp...@gmail.com: That's

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-07 Thread k-ohara5a5a
On 2014/07/07 10:21:42, janek wrote: ok - this looks like a good path to follow. Unfortunately, i don't know when i'll have enough time to chew on this stuff - it seems that i'll have a busy week (or two). Let's countdown and push this as-is, then. https://codereview.appspot.com/108280044/

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-07 Thread Janek Warchoł
2014-07-07 17:17 GMT+02:00 k-ohara5...@oco.net: On 2014/07/07 10:21:42, janek wrote: ok - this looks like a good path to follow. Unfortunately, i don't know when i'll have enough time to chew on this stuff - it seems that i'll have a busy week (or two). Let's countdown and push this

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-05 Thread Keith OHara
On Fri, 04 Jul 2014 14:38:19 -0700, Janek Warchoł janek.lilyp...@gmail.com wrote: 2014-07-04 23:26 GMT+02:00 Janek Warchoł janek.lilyp...@gmail.com: That's actually not what i want to do; I apologize for being unclear. I *want* the columns to behave the same way in case of both accidentals

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-04 Thread Keith OHara
On Wed, 02 Jul 2014 23:56:20 -0700, janek.lilyp...@gmail.com wrote: you should try to make the change consistently everywhere ? Yes, that's what i'm aiming for. However, as you remember, some of these changes produce unwanted side-effects I remember you said there were side effects, but

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-04 Thread Janek Warchoł
Hi Keith, 2014-07-04 9:07 GMT+02:00 Keith OHara k-ohara5...@oco.net: On Wed, 02 Jul 2014 23:56:20 -0700, janek.lilyp...@gmail.com wrote: you should try to make the change consistently everywhere ? Yes, that's what i'm aiming for. However, as you remember, some of these changes produce

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-04 Thread Janek Warchoł
I'm sorry, i mistakenly clicked send too early... 2014-07-04 23:26 GMT+02:00 Janek Warchoł janek.lilyp...@gmail.com: That's actually not what i want to do; I apologize for being unclear. I *want* the columns to behave the same way in case of both accidentals and lyrics (and everything else).

Re: fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-03 Thread janek . lilypond
Reviewers: Keith, franio.kropka.b, Message: Updated description. On 2014/07/03 04:42:48, Keith wrote: This does make sense, but if you change the basic rules of a Spring (allowing the natural length to be less than the minimum-distance constraint, so it stays at the minimum length until

fix Issue 2462. (issue 108280044 by janek.lilyp...@gmail.com)

2014-07-02 Thread k-ohara5a5a
This does make sense, but if you change the basic rules of a Spring (allowing the natural length to be less than the minimum-distance constraint, so it stays at the minimum length until the line is considerably stretched) you should try to make the change consistently everywhere ?