Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Jonathan Kulp
On Sun, Jul 12, 2009 at 3:31 PM, Mark Polesky wrote: > > Patrick McCarty wrote: > > Rechecking your patch, it did in fact have DOS line endings. > > > > So, I changed them to UNIX line endings in Vim: > > > > :set ff=unix > > > > and then it applied cleanly. Maybe something happened between th

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Mark Polesky
Patrick McCarty wrote: > Rechecking your patch, it did in fact have DOS line endings. > > So, I changed them to UNIX line endings in Vim: > > :set ff=unix > > and then it applied cleanly. Maybe something happened between the > creation of the patch and sending the email that changed the line

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Patrick McCarty
On Sun, Jul 12, 2009 at 01:14:23PM -0700, Mark Polesky wrote: > > Patrick McCarty wrote: > > > Rather weirdly, your earlier patch won't apply now either. > > > > Did you do > > > > git rebase --abort > > > > before trying to apply his earlier patch? > > > > > You've got push access now, ha

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Patrick McCarty
On Sun, Jul 12, 2009 at 01:07:22PM -0700, Patrick McCarty wrote: > On Sun, Jul 12, 2009 at 11:32:24AM -0700, Mark Polesky wrote: > > > From: Neil Puttock wrote: > > > @lilypond[quote] > > > > Okay, > > > > here's a new patch using @lilypond[quote]. I'm leaving it called > > "The Feta font" for no

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Neil Puttock
2009/7/12 Patrick McCarty : > Did you do > >  git rebase --abort > > before trying to apply his earlier patch? Of course. :) I just got confused with different patches and applied the wrong one. Regards, Neil ___ lilypond-devel mailing list lilypond

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Mark Polesky
Patrick McCarty wrote: > > Rather weirdly, your earlier patch won't apply now either. > > Did you do > > git rebase --abort > > before trying to apply his earlier patch? > > > You've got push access now, haven't you? If so, you can do > >it yourself. > > He doesn't, but he should have ac

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Patrick McCarty
On Sun, Jul 12, 2009 at 09:06:49PM +0100, Neil Puttock wrote: > 2009/7/12 Mark Polesky : > > > Please double-check once more and apply. > > For some reason, I can't apply it. > > Applying: Docs: NR B.6 The Feta font: Organize glyph list. > /home/neil/lilypond/.git/rebase-apply/patch:15: trailing

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Neil Puttock
2009/7/12 Mark Polesky : > Please double-check once more and apply. For some reason, I can't apply it. Applying: Docs: NR B.6 The Feta font: Organize glyph list. /home/neil/lilypond/.git/rebase-apply/patch:15: trailing whitespace. /home/neil/lilypond/.git/rebase-apply/patch:16: trailing whitesp

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Patrick McCarty
On Sun, Jul 12, 2009 at 11:32:24AM -0700, Mark Polesky wrote: > > From: Neil Puttock wrote: > > @lilypond[quote] > > Okay, > > here's a new patch using @lilypond[quote]. I'm leaving it called > "The Feta font" for now. Changing it to "The Emmentaler font" > would require changing some 50 or so cr

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Mark Polesky
> From: Neil Puttock wrote: > @lilypond[quote] Okay, here's a new patch using @lilypond[quote]. I'm leaving it called "The Feta font" for now. Changing it to "The Emmentaler font" would require changing some 50 or so cross-references in the source and I think that should be a different patch. Pl

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Neil Puttock
2009/7/12 Mark Polesky : > Is it ready to apply? Looks fine. If I may sugget one refinement: use the quote environment (it produces nicer looking examples in html). @lilypond[quote] Regards, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.o

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Trevor Daniels
Mark Polesky wrote Saturday, July 11, 2009 11:36 PM Okay, here's a patch. Can someone test this? Applies fine and output looks good. My only comment is the heading - should this not be changed to The Emmentaler font? See http://lists.gnu.org/archive/html/lilypond-devel/2009-05/msg00222.htm

Re: improving NR B.6 "The Feta Font"

2009-07-12 Thread Mark Polesky
Patrick McCarty wrote: > I just compiled the docs, and it looks great! Is it ready to apply? - Mark ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: improving NR B.6 "The Feta Font"

2009-07-11 Thread Patrick McCarty
On Sat, Jul 11, 2009 at 03:36:04PM -0700, Mark Polesky wrote: > Okay, here's a patch. Can someone test this? Mark, I just compiled the docs, and it looks great! I believe Francisco brought this a while back, but we should rename this appendix to "The Emmentaler font", since that is its current n

Re: improving NR B.6 "The Feta Font"

2009-07-11 Thread Mark Polesky
Okay, here's a patch. Can someone test this? Thanks. - Mark 0001-Docs-NR-B.6-The-Feta-Font-Organize-glyph-list.patch Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-

Re: improving NR B.6 "The Feta Font"

2009-07-11 Thread Carl Sorensen
On 7/11/09 12:29 PM, "Mark Polesky" wrote: > > > Carl Sorensen wrote: > >> @subsection Shaped Notes >> >> @lilypond >> \include font-table.ly >> #(display-font-table 'shape-notes) >> @end lilypond >> >> @subsection Ancient Notes >> >> @lilypond >> \include font-table.ly >> #(display-font

Re: improving NR B.6 "The Feta Font"

2009-07-11 Thread Mark Polesky
Carl Sorensen wrote: > @subsection Shaped Notes > > @lilypond > \include font-table.ly > #(display-font-table 'shape-notes) > @end lilypond > > @subsection Ancient Notes > > @lilypond > \include font-table.ly > #(display-font-table 'ancient-notes) > @end lilypond I just discovered a neat tric

Re: improving NR B.6 "The Feta Font"

2009-07-11 Thread Trevor Daniels
Mark Polesky wrote Friday, July 10, 2009 8:51 PM I was having trouble finding glyphs in NR B.6, so I reorganized things. I'm not saying I used the best approach, but I think this would be an improvement. Any comments or suggestions? A better approach? See the attached file. Thanks. - Mark M

Re: improving NR B.6 "The Feta Font"

2009-07-10 Thread Carl Sorensen
On 7/10/09 8:25 PM, "Mark Polesky" wrote: > > > Neil Puttock wrote: >> I like it. Though it sacrifices a bit of maintainability, I >> think it's worth it when it looks so good. >> >> One thing I don't like is the (begin ...) form though, especially >> since there's no indentation for the h

Re: improving NR B.6 "The Feta Font"

2009-07-10 Thread Mark Polesky
Neil Puttock wrote: > I like it. Though it sacrifices a bit of maintainability, I > think it's worth it when it looks so good. > > One thing I don't like is the (begin ...) form though, especially > since there's no indentation for the helper functions inside. I would've been shocked had you not

Re: improving NR B.6 "The Feta Font"

2009-07-10 Thread Carl Sorensen
On 7/10/09 1:51 PM, "Mark Polesky" wrote: > I was having trouble finding glyphs in NR B.6, so I reorganized > things. I'm not saying I used the best approach, but I think this > would be an improvement. Any comments or suggestions? A better > approach? See the attached file. I like it a lot.

Re: improving NR B.6 "The Feta Font"

2009-07-10 Thread Neil Puttock
2009/7/10 Mark Polesky : > I was having trouble finding glyphs in NR B.6, so I reorganized > things. I'm not saying I used the best approach, but I think this > would be an improvement. Any comments or suggestions? A better > approach? See the attached file. I like it. Though it sacrifices a bit

Re: improving NR B.6 "The Feta Font"

2009-07-10 Thread Graham Percival
On Fri, Jul 10, 2009 at 12:51:19PM -0700, Mark Polesky wrote: > I was having trouble finding glyphs in NR B.6, so I reorganized > things. I'm not saying I used the best approach, but I think this > would be an improvement. Any comments or suggestions? A better > approach? See the attached file. Lo

improving NR B.6 "The Feta Font"

2009-07-10 Thread Mark Polesky
I was having trouble finding glyphs in NR B.6, so I reorganized things. I'm not saying I used the best approach, but I think this would be an improvement. Any comments or suggestions? A better approach? See the attached file. Thanks. - Mark #(set-global-staff-size 16) #(begin ;; some hel