Re: issue #5341: Urgent corrections to stencil-integral.cc (skylines) (issue 341350043 by torsten.haemme...@web.de)

2018-06-12 Thread dak
On 2018/06/12 10:49:11, Be-3 wrote: On 2018/06/12 10:05:17, dak wrote: > However, cough cough, all this is an unnecessary complication. Sorry for > overlooking this. Just write > > Stencil q = *s; > […] Just to mention it: How about the definition of ly:stencil-rotate in

Re: issue #5341: Urgent corrections to stencil-integral.cc (skylines) (issue 341350043 by torsten.haemme...@web.de)

2018-06-12 Thread dak
On 2018/06/12 10:49:11, Be-3 wrote: On 2018/06/12 10:05:17, dak wrote: > However, cough cough, all this is an unnecessary complication. Sorry for > overlooking this. Just write > > Stencil q = *s; > […] Just to mention it: How about the definition of ly:stencil-rotate in

Re: issue #5341: Urgent corrections to stencil-integral.cc (skylines) (issue 341350043 by torsten.haemme...@web.de)

2018-06-12 Thread torsten . haemmerle
On 2018/06/12 10:05:17, dak wrote: However, cough cough, all this is an unnecessary complication. Sorry for overlooking this. Just write Stencil q = *s; […] Just to mention it: How about the definition of ly:stencil-rotate in lily/stencil-scheme.cc? There, we should have the exact same

Re: issue #5341: Urgent corrections to stencil-integral.cc (skylines) (issue 341350043 by torsten.haemme...@web.de)

2018-06-12 Thread dak
https://codereview.appspot.com/341350043/diff/1/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/341350043/diff/1/lily/stencil-integral.cc#newcode1132 lily/stencil-integral.cc:1132: SCM new_s = s->smobbed_copy (); This does not work: the compiler

issue #5341: Urgent corrections to stencil-integral.cc (skylines) (issue 341350043 by torsten.haemme...@web.de)

2018-06-11 Thread torsten . haemmerle
Reviewers: , Message: Please review (ideally DAK) Thanks, Torsten Description: issue #5341: Urgent corrections to stencil-integral.cc (skylines) modified: ../lily/stencil-integral.cc Main correction: Stencil::skylines_from_stencil Avoid garbage collection by introducing an SCM variable