Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-26 Thread Noeck
Am 26.04.2018 um 12:13 schrieb Torsten Hämmerle: > I hardly dare to admit it, but all I used was Windows' infamous Paint > program :D ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-26 Thread Karlin High
On 4/26/2018 5:13 AM, Torsten Hämmerle wrote: I hardly dare to admit it, but all I used was Windows' infamous Paint program (a simple raster graphics editor). As a basis, I used a LilyPond screenshot, moved things around and inserted pixel based elements. -- Karlin High Missouri, USA

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-26 Thread Torsten Hämmerle
Noeck wrote > I've confidence in your algorithm. I just thought I post a situation > which I would have neglected at first – without knowing what your > algorithm does. Hi Joram, It's good have asked, it is just too easy to overlook things... Noeck wrote > Thanks for your explanation! It

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-25 Thread Noeck
Hi Torsten, I've confidence in your algorithm. I just thought I post a situation which I would have neglected at first – without knowing what your algorithm does. Thanks for your explanation! It seems pretty robust and straightforward to me, now. Are the two algorithms the equivalent if you make

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread Torsten Hämmerle
Joram Berger wrote > Will it also look good for custom key signatures? Hi Joram, Well, in your example, there will be no difference between the old and new coding: The first two naturals with full overlap get a maximum extra padding of 0.3, the second and third naturals are (vertically) so far

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread Joram
Will it also look good for custom key signatures? \relative { \set Staff.keyAlterations = #`((6 . ,FLAT) (5 . ,FLAT) (3 . ,SHARP)) c'4 d e fis aes4 bes c2 \key c \major c } Best, Joram

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread torsten . haemmerle
On 2018/04/24 21:49:37, Carl wrote: On 2018/04/24 18:43:45, Be-3 wrote: > The intervals are just *approximating* the outlines of a run-of-the mill > natural glyph. I even played around with the concept using squared paper. > This approach more or less relies on the fact that the

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread Carl . D . Sorensen
On 2018/04/24 18:43:45, Be-3 wrote: The intervals are just *approximating* the outlines of a run-of-the mill natural glyph. I even played around with the concept using squared paper. This approach more or less relies on the fact that the square/parallelogram part of a natural glyph will

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread torsten . haemmerle
On 2018/04/24 17:59:31, Carl wrote: LGTM. I am just a *little* bit concerned about having the dimensions of the Emmentaler natural glyph hardcoded in the source, but we already have magic numbers reflecting the characteristics of the Emmentaler glyphs. Maybe it would be good to put a

Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread Carl . D . Sorensen
LGTM. I am just a *little* bit concerned about having the dimensions of the Emmentaler natural glyph hardcoded in the source, but we already have magic numbers reflecting the characteristics of the Emmentaler glyphs. Maybe it would be good to put a FIXME in recognizing this fact. Or maybe we

issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by torsten.haemme...@web.de)

2018-04-24 Thread torsten . haemmerle
Reviewers: , Message: Please review... Thanks, Torsten PS: no new regression test needed, there are loads of key cancellations in the existing regression tests. Description: issue 5312: Key cancellation glyph position inconsistent file lily/key-signature-interface.cc Using two intervals