Oui, mon Général ! ;)
Issue #5341 "Urgent corrections to stencil-integral.cc (skylines)" created.
--
Sent from: http://lilypond.1069038.n5.nabble.com/Dev-f88644.html
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Torsten Hämmerle writes:
> David Kastrup wrote
>> Once you create a smobbed copy, it must be protected from garbage
>> collection.
>> […]
>> However, it seems that uses here are few enough that you can just do
>> SCM q = s->smobbed_copy ();
>> and use unsmob
>>
>> (q) where you now use q.
>
>
David Kastrup wrote
> Once you create a smobbed copy, it must be protected from garbage
> collection.
> […]
> However, it seems that uses here are few enough that you can just do
> SCM q = s->smobbed_copy ();
> and use unsmob
>
> (q) where you now use q.
Hi David,
Many thanks for your review
https://codereview.appspot.com/342060043/diff/20001/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/342060043/diff/20001/lily/stencil-integral.cc#newcode1132
lily/stencil-integral.cc:1132: Stencil *q = unsmob
(s->smobbed_copy ());
Once you create
On 2018/05/03 17:42:22, lemzwerg wrote:
LGTM
https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc
File lily/key-signature-interface.cc (right):
https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc#newcode114
LGTM
https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc
File lily/key-signature-interface.cc (right):
https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc#newcode114
lily/key-signature-interface.cc:114: padding += (intersection (ht_right,
I am top posting
Torsten,
Can you make a new patch based on current master as this one no longer applies
so I cannot test it even without the *.cc file - I think it is because of a
recent push to master for changes.tely this morning.
James
On Thu, 03 May 2018 05:51:11 -0700,
Reviewers: ,
Message:
Please review...
Inadvertently, file
../lily/key-signature-interface.cc
slipped into the patch (from issue 5312 currently in staging).
So ignore is (or shall I upload a new, cleansed patch for reviewing?)
Thanks,
Torsten
Description:
issue 5319: Make skylines reflect
