Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-15 Thread janek . lilypond
LGTM I apologize that you had to wait. Thank you for your work!! http://codereview.appspot.com/6189048/diff/9003/input/regression/collision-whole.ly File input/regression/collision-whole.ly (right): http://codereview.appspot.com/6189048/diff/9003/input/regression/collision-whole.ly#newcode16

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-15 Thread k-ohara5a5a
http://codereview.appspot.com/6189048/diff/9003/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6189048/diff/9003/lily/note-collision.cc#newcode301 lily/note-collision.cc:301: in calc_positioning_done(), by the width of the downstem note. On 2012/05/15

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-15 Thread janek . lilypond
On 2012/05/15 07:31:09, Keith wrote: On 2012/05/15 06:48:09, janek wrote: Why don't we get gid of that multiplication? That is my plan. See Patch Set 1 for a preview. All note-collision spacing is scaled by the first down-stem note, so each path through the collision code needs to use

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-10 Thread janek . lilypond
http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc#newcode301 lily/note-collision.cc:301: of the note heads on the sides that interfere. */ So, should the offsets

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-10 Thread Keith OHara
On Thu, 10 May 2012 17:21:54 -0700, janek.lilyp...@gmail.com wrote: The interesting thing is that the order of voices matters: [] the placement of the notes should be the same in both measures,but it isn't. The order of voices produces different placement for half notes. \override