2014-02-17 18:54 GMT+01:00 :
> Forgot to move one magic number in the reorganization.
>
> The behavior of the line-breaker is strange in the presence of
> zero-stretchable lines; maybe the enforcement of minimum stretchability
> should go there instead.
>
>
> https://codereview.appspot.com/3683004
Forgot to move one magic number in the reorganization.
The behavior of the line-breaker is strange in the presence of
zero-stretchable lines; maybe the enforcement of minimum stretchability
should go there instead.
https://codereview.appspot.com/36830045/diff/120001/lily/note-spacing.cc
File li
On 2013/12/29 22:58:32, janek wrote:
Do you mean that you won't add a regtest or won't use big staffsize?
I won't add a regression test. Several tests already change in response
to this change in code.
Some thoughts on the space around the \mark are below:
https://codereview.appspot.com/36
On 2013/12/29 21:50:46, Keith wrote:
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc#newcode103
lily/ledger-line-spanner.cc:103: if (Staf
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc#newcode103
lily/ledger-line-spanner.cc:103: if (Staff_symbol::ledger_positions
(staff, pos).e
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (right):
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc#newcode103
lily/ledger-line-spanner.cc:103: if (Staff_symbol::ledger_positions
(staff, pos).e
On Fri, Dec 27, 2013 at 1:28 AM, Keith OHara wrote:
> On Thu, 26 Dec 2013 22:47:41 -0800, Trevor Bača
> wrote:
>
> I suppose it's important to note that all of my scores use proportional
>> notation everywhere. So I imagine that most of the horizontal spacing
>> improvements don't actually impa
On Thu, 26 Dec 2013 22:47:41 -0800, Trevor Bača wrote:
I suppose it's important to note that all of my scores use proportional
notation everywhere. So I imagine that most of the horizontal spacing
improvements don't actually impact my scores. (The recent spacing changes
optimize Lily's *default
On Mon, Dec 16, 2013 at 2:28 AM, Mike Solomon wrote:
>
> On Dec 16, 2013, at 10:24 AM, k-ohara5...@oco.net wrote:
>
> Reviewers: MikeSol,
>
> Message:
> On 2013/12/16 07:42:52, MikeSol wrote:
>
> If you understand this stuff, could you put a comment in
>
> lily/include/spring.hh
>
> as to what in
On Dec 16, 2013, at 10:24 AM, k-ohara5...@oco.net wrote:
> Reviewers: MikeSol,
>
> Message:
> On 2013/12/16 07:42:52, MikeSol wrote:
>
>> If you understand this stuff, could you put a comment in
> lily/include/spring.hh
>> as to what inverse_compress_strength and inverse_stretch_strength are?
>
Reviewers: MikeSol,
Message:
On 2013/12/16 07:42:52, MikeSol wrote:
If you understand this stuff, could you put a comment in
lily/include/spring.hh
as to what inverse_compress_strength and inverse_stretch_strength are?
They are the stretchability and compressibility of the space.
Next time
https://codereview.appspot.com/36830045/diff/20001/lily/note-spacing.cc
File lily/note-spacing.cc (right):
https://codereview.appspot.com/36830045/diff/20001/lily/note-spacing.cc#newcode117
lily/note-spacing.cc:117: ret.set_inverse_stretch_strength (base_space);
Looked at it, but I have no idea
12 matches
Mail list logo