Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2014-02-22 Thread Janek Warchoł
2014-02-17 18:54 GMT+01:00 k-ohara5...@oco.net: Forgot to move one magic number in the reorganization. The behavior of the line-breaker is strange in the presence of zero-stretchable lines; maybe the enforcement of minimum stretchability should go there instead.

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2014-02-17 Thread k-ohara5a5a
Forgot to move one magic number in the reorganization. The behavior of the line-breaker is strange in the presence of zero-stretchable lines; maybe the enforcement of minimum stretchability should go there instead. https://codereview.appspot.com/36830045/diff/120001/lily/note-spacing.cc File

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-29 Thread janek . lilypond
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc#newcode103 lily/ledger-line-spanner.cc:103: if (Staff_symbol::ledger_positions (staff,

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-29 Thread k-ohara5a5a
https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc#newcode103 lily/ledger-line-spanner.cc:103: if (Staff_symbol::ledger_positions (staff,

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-29 Thread janek . lilypond
On 2013/12/29 21:50:46, Keith wrote: https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): https://codereview.appspot.com/36830045/diff/120001/lily/ledger-line-spanner.cc#newcode103 lily/ledger-line-spanner.cc:103: if

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-29 Thread k-ohara5a5a
On 2013/12/29 22:58:32, janek wrote: Do you mean that you won't add a regtest or won't use big staffsize? I won't add a regression test. Several tests already change in response to this change in code. Some thoughts on the space around the \mark are below:

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-26 Thread Trevor Bača
On Mon, Dec 16, 2013 at 2:28 AM, Mike Solomon m...@mikesolomon.org wrote: On Dec 16, 2013, at 10:24 AM, k-ohara5...@oco.net wrote: Reviewers: MikeSol, Message: On 2013/12/16 07:42:52, MikeSol wrote: If you understand this stuff, could you put a comment in lily/include/spring.hh as to

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-26 Thread Keith OHara
On Thu, 26 Dec 2013 22:47:41 -0800, Trevor Bača trevorb...@gmail.com wrote: I suppose it's important to note that all of my scores use proportional notation everywhere. So I imagine that most of the horizontal spacing improvements don't actually impact my scores. (The recent spacing changes

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-26 Thread Trevor Bača
On Fri, Dec 27, 2013 at 1:28 AM, Keith OHara k-ohara5...@oco.net wrote: On Thu, 26 Dec 2013 22:47:41 -0800, Trevor Bača trevorb...@gmail.com wrote: I suppose it's important to note that all of my scores use proportional notation everywhere. So I imagine that most of the horizontal spacing

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-16 Thread k-ohara5a5a
Reviewers: MikeSol, Message: On 2013/12/16 07:42:52, MikeSol wrote: If you understand this stuff, could you put a comment in lily/include/spring.hh as to what inverse_compress_strength and inverse_stretch_strength are? They are the stretchability and compressibility of the space. Next time

Re: note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-16 Thread Mike Solomon
On Dec 16, 2013, at 10:24 AM, k-ohara5...@oco.net wrote: Reviewers: MikeSol, Message: On 2013/12/16 07:42:52, MikeSol wrote: If you understand this stuff, could you put a comment in lily/include/spring.hh as to what inverse_compress_strength and inverse_stretch_strength are? They

note-spacing: stretch somewhat uniformly; issue 3304 (issue 36830045)

2013-12-15 Thread mtsolo
https://codereview.appspot.com/36830045/diff/20001/lily/note-spacing.cc File lily/note-spacing.cc (right): https://codereview.appspot.com/36830045/diff/20001/lily/note-spacing.cc#newcode117 lily/note-spacing.cc:117: ret.set_inverse_stretch_strength (base_space); Looked at it, but I have no idea