Re: LSR is now on 2.14
- Original Message -
From: David Nalesnik
To: Phil Holmes
Cc: Thomas Morley ; lilypond-devel
Sent: Monday, April 02, 2012 8:29 PM
Subject: Re: LSR is now on 2.14
Hi,
On Mon, Apr 2, 2012 at 11:48 AM, Phil Holmes m...@philholmes.net wrote:
Sorry about the top post. Windows mail is sometimes a pain. I'll do
fretted-string-harmonics... to screech-boink.
Phil Holmes
Attached the tarball with the missing files from
`Ducumentatione/snippets/new/'
I'll pick the following files and put them into the LSR:
alternative-breve-note.ly
changing-the-ambitus-gap.ly
changing-the-number-of-augmentation-dots-per-note.ly
changing-the-size-of-woodwind-diagrams.ly
chordchanges-for-fretboards.ly
chord-glissando-in-tablature.ly
controlling-spanner-visibility-after-a-line-break.ly
defining-an-engraver-in-scheme-ambitus-engraver.ly
dynamics-custom-text-spanner-postfix.ly
dynamics-text-spanner-postfix.ly
expressive-headword.ly
figured-bass-headword.ly
fretboards-alternate-tables.ly
Cheers,
Harm
I just added the remaining files. One thing: I kept the formatting in the
texidoc string because I noticed that this had been done in other additions.
Should this be converted to HTML formatting?
-David
Simple answer - don't know. I converted @code{} to code/code in the
snippets I added, since this then displays correctly in the web version of the
LSR. I'm assuming this gets put back to texidoc coding during the import, but
will need to check it when I do this.
There are a few tweaks like this we need to remember when we document the
process.
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
- Original Message - From: Thomas Morley thomasmorle...@googlemail.com To: lilypond-devel lilypond-devel@gnu.org Cc: David Nalesnik david.nales...@gmail.com; bug-lilypond bug-lilyp...@gnu.org Sent: Tuesday, April 03, 2012 12:26 AM Subject: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr Hi, Seba just informed me that the Contemporary vibrato snippet is not compiling. [snip] Do you think we should delete it and replace it with a working one when Mike completes it? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
Am 3. April 2012 10:27 schrieb Phil Holmes m...@philholmes.net: - Original Message - From: Thomas Morley thomasmorle...@googlemail.com To: lilypond-devel lilypond-devel@gnu.org Cc: David Nalesnik david.nales...@gmail.com; bug-lilypond bug-lilyp...@gnu.org Sent: Tuesday, April 03, 2012 12:26 AM Subject: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr Hi, Seba just informed me that the Contemporary vibrato snippet is not compiling. [snip] Do you think we should delete it and replace it with a working one when Mike completes it? Yes. Can you do it or shall I ask Seba? But there is a very basic problem: If I test compiling the whole LSR and all is fine but compiling a single file from LSR failes, means I can't trust my testing-results. How can I continue the work? Having no chance to notice problematic files annoys me and in the end Seba, too. -Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
- Original Message - From: Thomas Morley thomasmorle...@googlemail.com To: Phil Holmes m...@philholmes.net Cc: lilypond-devel lilypond-devel@gnu.org; David Nalesnik david.nales...@gmail.com; bug-lilypond bug-lilyp...@gnu.org Sent: Tuesday, April 03, 2012 11:53 AM Subject: Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr Am 3. April 2012 10:27 schrieb Phil Holmes m...@philholmes.net: - Original Message - From: Thomas Morley thomasmorle...@googlemail.com To: lilypond-devel lilypond-devel@gnu.org Cc: David Nalesnik david.nales...@gmail.com; bug-lilypond bug-lilyp...@gnu.org Sent: Tuesday, April 03, 2012 12:26 AM Subject: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr Hi, Seba just informed me that the Contemporary vibrato snippet is not compiling. [snip] Do you think we should delete it and replace it with a working one when Mike completes it? Yes. Can you do it or shall I ask Seba? I can do it and I've just done so. But there is a very basic problem: If I test compiling the whole LSR and all is fine but compiling a single file from LSR failes, means I can't trust my testing-results. How can I continue the work? Having no chance to notice problematic files annoys me and in the end Seba, too. -Harm We need to check what the script is doing and how it responds to failing snippets like this. I'm not in a position to do this right now, but let's not forget it's there. I've put it on the tracker as http://code.google.com/p/lilypond/issues/detail?id=2466 -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
On Apr 3, 2012, at 1:10 PM, Phil Holmes wrote: We need to check what the script is doing and how it responds to failing snippets like this. I'm not in a position to do this right now, but let's not forget it's there. I've put it on the tracker as http://code.google.com/p/lilypond/issues/detail?id=2466 It's also important to establish if this is a critical regression or not. The snippet dug into the bowels of LilyPond and used lots of functionality that's not put into play often. So its failure to compile may be pointing to an unexposed regression. Perhaps it'd be wise to label this as critical now and then downgrade it once we confirm that the compilation failure isn't coming from anything directly involved in running the LilyPond executable. Cheers, MS___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
On Tue, Apr 03, 2012 at 12:53:33PM +0200, Thomas Morley wrote: But there is a very basic problem: If I test compiling the whole LSR and all is fine but compiling a single file from LSR failes, means I can't trust my testing-results. How can I continue the work? Having no chance to notice problematic files annoys me and in the end Seba, too. Your method 1) here: http://lists.gnu.org/archive/html/lilypond-devel/2012-04/msg00056.html won't give any huge error messages if one lilypond run fails. You'll need to tweak that script to look at the returned value from lilypond and quit the entire script if it's a non-zero return value. I wouldn't expect method 2) to give much useful data; focus on adjusting method 1) so that it looks at the ret value. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LSR is now on 2.14
Hi David, I just checked our recent addings to the LSR. In unfretted-headword.ly I noticed the line: noflag = \once \override Flag #'style = #'no-flag could you change it to: noflag = \once \override Stem #'flag-style = #'no-flag ? Well, the noflag-Definition isn't used in the snippet, but perhaps someone would be puzzled about it. Thanks, Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LSR is now on 2.14
Hi Harm, On Tue, Apr 3, 2012 at 8:45 AM, Thomas Morley thomasmorle...@googlemail.com wrote: Hi David, I just checked our recent addings to the LSR. In unfretted-headword.ly I noticed the line: noflag = \once \override Flag #'style = #'no-flag could you change it to: noflag = \once \override Stem #'flag-style = #'no-flag ? Well, the noflag-Definition isn't used in the snippet, but perhaps someone would be puzzled about it. Nice catch! Fixed. -David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LSR is now on 2.14
Hi Phil, I just checked the snippets I added to the lsr-tarball as well as our recent lsr-addings against the snippets from `Documentation/snippets/new/' on http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=tree;f=Documentation/snippets/new;h=cac0bba81f655a2666049823e7d21ec51bcd73cd;hb=2055f35c47a045a50a01ff4dba8524322cfc3b48 Perhaps I messed up sth or I missed recent changes. There are a few files, now being in the LSR, which should be changed: adjusting-lyrics-vertical-spacing.ly comment changed position automatic-beam-subdivisions.ly markup-arguments were changed changing-the-time-signature-without-affecting-the-beaming.ly should be deleted: This snippet is deprecated as of 2.13.5 and will be removed in 2.14 displaying-complex-chords.ly should be replaced by the current version engravers-one-by-one.ly \consists Tie_engraver is doubled (In the file on Savannah, too) May I ask you to do this? -Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LSR is now on 2.14
- Original Message - From: Thomas Morley thomasmorle...@googlemail.com To: Phil Holmes m...@philholmes.net Cc: David Nalesnik david.nales...@gmail.com; lilypond-devel lilypond-devel@gnu.org Sent: Tuesday, April 03, 2012 3:24 PM Subject: Re: LSR is now on 2.14 Hi Phil, I just checked the snippets I added to the lsr-tarball as well as our recent lsr-addings against the snippets from `Documentation/snippets/new/' on http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=tree;f=Documentation/snippets/new;h=cac0bba81f655a2666049823e7d21ec51bcd73cd;hb=2055f35c47a045a50a01ff4dba8524322cfc3b48 Perhaps I messed up sth or I missed recent changes. There are a few files, now being in the LSR, which should be changed: adjusting-lyrics-vertical-spacing.ly comment changed position automatic-beam-subdivisions.ly markup-arguments were changed changing-the-time-signature-without-affecting-the-beaming.ly should be deleted: This snippet is deprecated as of 2.13.5 and will be removed in 2.14 displaying-complex-chords.ly should be replaced by the current version engravers-one-by-one.ly \consists Tie_engraver is doubled (In the file on Savannah, too) May I ask you to do this? -Harm My understanding is that, once a correct snippet is in the LSR, it should be deleted from snippets/new. What will then happen is that I will grab an updated tarball of the snippets tagged with the docs tag and run makelsr. These will then all be imported into snippets (not snippets/new). If there is a snippet in snippets/new it over-writes the one from the tarball. So the next task is to check whether there are any snippets in snippets/new that should not be deleted - these would be ones that only run on 2.15.x. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fwd: Staging/Master Merge - James' Patchy
I might have some internet issues at home. Patchy hasn't pushed since midday or emailed until now. I cannot remember what the message is if it 'fails' to connect to the internet - I think it posts this generic message. I'll check when I get home, there are no commits I can see in master or staging since yesterday. So this is probably just an internet connection glitch. James -- Forwarded message -- From: lilypond.patchy.jl...@gmail.com Date: 3 April 2012 17:31 Subject: Staging/Master Merge - James' Patchy To: lilypond-a...@gnu.org, pkx1...@gmail.com Cc: pkx1...@gmail.com *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
Am 3. April 2012 16:52 schrieb David Kastrup d...@gnu.org: m...@apollinemike.com m...@apollinemike.com writes: On Apr 3, 2012, at 1:10 PM, Phil Holmes wrote: We need to check what the script is doing and how it responds to failing snippets like this. I'm not in a position to do this right now, but let's not forget it's there. I've put it on the tracker as http://code.google.com/p/lilypond/issues/detail?id=2466 It's also important to establish if this is a critical regression or not. The snippet dug into the bowels of LilyPond and used lots of functionality that's not put into play often. So its failure to compile may be pointing to an unexposed regression. Perhaps it'd be wise to label this as critical now and then downgrade it once we confirm that the compilation failure isn't coming from anything directly involved in running the LilyPond executable. There are things like bleedover. See URL:http://code.google.com/p/lilypond/issues/detail?id=2449 for one example where a user interface was added that results in changes affecting the entire rest of a multi-file session. If a later snippet relies on a define-event-class in an earlier snippet, bleedover will make this reach into further sessions. git grep define-public Documentation/snippets returns several snippets that _export_ definitions (I have not checked whether this means that they will spill over, but I would not be surprised if it did). Any snippet that reaches into the bowels of LilyPond causing a _permanent_ change there surviving beyond the session is a mistake. It is possible that here one snippet depends on another snippet. What are the error messages in this particular case? -- David Kastrup I tried to narrow it down. At last I had only the contemporary-vibrato.ly-file in the directory. Using #!/bin/bash for LILYFILE in *.ly do STEM=$(basename $LILYFILE .ly) echo running $LILYFILE... lilypond --format=png -ddelete-intermediate-files $LILYFILE $STEM.txt done (as for the whole lsr) works and it compiles!! Compiling with 2.14.2 lilypond contemporary-vibrato.ly gave me simply: ERROR: Wrong type (expecting pair): () Can someone confirm this behaviour? I can hardly believe it. Compiling with 2.15.34 after removing a $-sign gave me contemporary-vibrato.ly:98:19: In procedure car in expression (map car in_l): contemporary-vibrato.ly:98:19: Wrong type (expecting pair): () Compiling with 2.12.3 works fine. Cheers, Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LSR is now on 2.14
Sebastiano's last mail: Am 3. April 2012 18:31 schrieb Sebastiano Vigna vi...@dsi.unimi.it: On Apr 3, 2012, at 9:21 AM, Thomas Morley wrote: Am 3. April 2012 18:00 schrieb Sebastiano Vigna vi...@dsi.unimi.it: All new snippets compiled happily. Now it shold be impossible to insert wrong snippets (the web interface won't allow it). I'm happy to hear that. Am I right that now the 2.14.2-LSR-update is completely successful and all other work on/with it has to be done through the web-interface? Yes, absolutely :). Ciao, seba :)) -Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2391 in lilypond: Add Appendix entry for Predefined Paper Sizes
Le 02/04/2012 00:19, Colin Hall disait :
On Sun, Apr 01, 2012 at 03:34:27PM +0200, Jean-Charles Malahieude wrote:
Unfortunately, the rewriting of NR-4.1.2 Paper size and automatic
scaling results in disappearance of the standard paper sizes which
now get only mentioned in an appendix.
This appendix needs a @ref (will be there in French after I have committed).
Yes, comparing those pages for 2.14 and 2.15.35:
Yes, I can see what you mean.
Could you submit a documentation suggestion, as set out here:
see enclosed
Cheers,
Jean-Charles
diff --git a/Documentation/notation/spacing.itely b/Documentation/notation/spacing.itely
index 68208d2..05509f5 100644
--- a/Documentation/notation/spacing.itely
+++ b/Documentation/notation/spacing.itely
@@ -233,7 +233,8 @@ placed @emph{before} any other functions used within the same
Paper sizes are defined in @file{scm/paper.scm}, and while it is
possible to add custom sizes, they will be overwritten on subsequent
-software updates.
+software updates. The available paper sizes are listed in
+@ref{Predefined paper sizes}.
@c An appendix entry exists for paper sizes but is not auto-generated
@@ -268,7 +269,8 @@ The music output will @emph{not} be rotated, just the paper size.
@seealso
Notation Reference:
-@ref{Automatic scaling to paper size}.
+@ref{Automatic scaling to paper size},
+@ref{Predefined paper sizes}.
Installed Files:
@file{scm/paper.scm}.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
Thomas Morley thomasmorle...@googlemail.com writes: Using #!/bin/bash for LILYFILE in *.ly do STEM=$(basename $LILYFILE .ly) echo running $LILYFILE... lilypond --format=png -ddelete-intermediate-files $LILYFILE $STEM.txt done (as for the whole lsr) works and it compiles!! Compiling with 2.14.2 lilypond contemporary-vibrato.ly gave me simply: ERROR: Wrong type (expecting pair): () Can someone confirm this behaviour? I can hardly believe it. Compiling with 2.15.34 after removing a $-sign gave me contemporary-vibrato.ly:98:19: In procedure car in expression (map car in_l): contemporary-vibrato.ly:98:19: Wrong type (expecting pair): () Compiling with 2.12.3 works fine. Can you try with -dno-protected-scheme-parsing again? Sometimes this leads to better error messages. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Failed compiling a single lsr-snippet, which does not fail whenrunning the whole lsr
Am 3. April 2012 21:30 schrieb David Kastrup d...@gnu.org: Thomas Morley thomasmorle...@googlemail.com writes: Using #!/bin/bash for LILYFILE in *.ly do STEM=$(basename $LILYFILE .ly) echo running $LILYFILE... lilypond --format=png -ddelete-intermediate-files $LILYFILE $STEM.txt done (as for the whole lsr) works and it compiles!! Compiling with 2.14.2 lilypond contemporary-vibrato.ly gave me simply: ERROR: Wrong type (expecting pair): () Can someone confirm this behaviour? I can hardly believe it. Compiling with 2.15.34 after removing a $-sign gave me contemporary-vibrato.ly:98:19: In procedure car in expression (map car in_l): contemporary-vibrato.ly:98:19: Wrong type (expecting pair): () Compiling with 2.12.3 works fine. Can you try with -dno-protected-scheme-parsing again? Sometimes this leads to better error messages. -- David Kastrup Done. But I've got no additional message. -Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: my GSoC application - please review! (also, who will be my mentor?)
On Mon, Apr 2, 2012 at 5:10 PM, m...@apollinemike.com m...@apollinemike.com wrote: Looks good! It's much more assertive and professional it's an easier read as well. Good luck! The application should now be publicly visible here: http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/janek_warchol/1# Please note that i've changed the schedule, and also added a skill evaluation as requested by GNU. I've also added some pictures - what do you think about them? cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LSR is now on 2.14
Am 3. April 2012 16:30 schrieb Phil Holmes m...@philholmes.net: My understanding is that, once a correct snippet is in the LSR, it should be deleted from snippets/new. What will then happen is that I will grab an updated tarball of the snippets tagged with the docs tag and run makelsr. These will then all be imported into snippets (not snippets/new). If there is a snippet in snippets/new it over-writes the one from the tarball. So the next task is to check whether there are any snippets in snippets/new that should not be deleted - these would be ones that only run on 2.15.x. I'm not sure how to continue: I just downloaded the source-tarball, lilypond-2.15.35.tar.gz and sorted the 2.14-snippets from *Documentation/snippets/new/ I noticed that these snippets are not completely identical to the ones from Savannah: http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=tree;f=Documentation/snippets/new;h=cac0bba81f655a2666049823e7d21ec51bcd73cd;hb=2055f35c47a045a50a01ff4dba8524322cfc3b48 What to do? -Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2391 in lilypond: Add Appendix entry for Predefined Paper Sizes
On Tue, Apr 03, 2012 at 07:30:50PM +0200, Jean-Charles Malahieude wrote: Le 02/04/2012 00:19, Colin Hall disait : On Sun, Apr 01, 2012 at 03:34:27PM +0200, Jean-Charles Malahieude wrote: Unfortunately, the rewriting of NR-4.1.2 Paper size and automatic scaling results in disappearance of the standard paper sizes which now get only mentioned in an appendix. This appendix needs a @ref (will be there in French after I have committed). Yes, comparing those pages for 2.14 and 2.15.35: Yes, I can see what you mean. Could you submit a documentation suggestion, as set out here: see enclosed Thank you very much indeed! Cheers, Colin. -- Colin Hall ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 2391 in lilypond: Add Appendix entry for Predefined Paper Sizes
On Tue, Apr 03, 2012 at 07:30:50PM +0200, Jean-Charles Malahieude wrote: Le 02/04/2012 00:19, Colin Hall disait : On Sun, Apr 01, 2012 at 03:34:27PM +0200, Jean-Charles Malahieude wrote: Unfortunately, the rewriting of NR-4.1.2 Paper size and automatic scaling results in disappearance of the standard paper sizes which now get only mentioned in an appendix. This appendix needs a @ref (will be there in French after I have committed). Yes, comparing those pages for 2.14 and 2.15.35: Yes, I can see what you mean. Could you submit a documentation suggestion, as set out here: see enclosed Documentation suggestion tracker here: http://code.google.com/p/lilypond/issues/detail?id=2467 Cheers, Colin. -- Colin Hall ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: my GSoC application - please review! (also, who will be my mentor?)
On 4/3/12 3:17 PM, Janek Warchoł janek.lilyp...@gmail.com wrote: The application should now be publicly visible here: http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/janek_w archol/1# Please note that i've changed the schedule, and also added a skill evaluation as requested by GNU. I've also added some pictures - what do you think about them? cheers, Janek LGTM. I don't know that it makes any difference, but you should do s/thourough/thorough/ Great job! Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: my GSoC application - please review! (also, who will be my mentor?)
On Wed, Apr 4, 2012 at 12:08 AM, Carl Sorensen c_soren...@byu.edu wrote: I don't know that it makes any difference, but you should do s/thourough/thorough/ fixed. Great job! Thanks! Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: change the size of the arpeggio arrows
On Tue, Apr 3, 2012 at 12:24 AM, Paolo Prete p4olo_pr...@yahoo.it wrote: Hello, how can I change the size of the arpeggio (up and down) arrows? The default size is really small I think it may be impossible (i.e. if you increase it's font-size, the size of the arpeggio zigzag will also increase). I agree that the arrow should be bigger. Long time ago i wrote a draft patch that addresses this, but i'm too busy now to do something about it. Maybe you'd like to handle it (files attached)? cheers, Janek 0001-font-widening-the-arpeggio-arrow.patch Description: Binary data 0002-more-fiddling.patch Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: rall. and accel stopped working in articulate. (issue 5927044)
pkx166h == pkx166h pkx1...@gmail.com writes: pkx166h Peter, this has passed our 'countdown' review, if you don't pkx166h yet have push access you can email me a git-formatted patch pkx166h and I can push it for you. OK here it is. From ee64a711a9b046496eeef116a1e1a01fe4a0df2a Mon Sep 17 00:00:00 2001 From: Peter Chubb peter.ch...@nicta.com.au Date: Thu, 15 Mar 2012 09:48:52 +1100 Subject: [PATCH] rall. and accel stopped working in articulate. According to the the git logs, in February 2011 the way that tempo changes for MIDI were interpreted changed from just the tempoWholesPerMinute property to use a TempoChangeEvent. This broke rall. in articulated MIDI output. This patch brings the articulate script up-to-date wrt to the way that tempo changes are signalled, and also adds accel. and poco accel. to the list of accepted scripts. Reported-by: Thomas Morley thomasmorle...@googlemail.com Reviewed-by: Carl Sorensen carl.d.soren...@gmail.com Reviewed-by: Graham Percival gra...@percival-music.ca Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- ly/articulate.ly | 65 ++ 1 file changed, 46 insertions(+), 19 deletions(-) diff --git a/ly/articulate.ly b/ly/articulate.ly index 59424e5..4702e20 100644 --- a/ly/articulate.ly +++ b/ly/articulate.ly @@ -341,8 +341,18 @@ ; (ac:accel trillMusic factor)) ))) - - +% +% Generate a tempoChangeEvent and its associated property setting. +% +#(define (ac:tempoChange tempo) + (make-sequential-music + (list (make-music 'TempoChangeEvent + 'metronome-count + tempo + 'tempo-unit + (ly:make-duration 0 0 1 1)) +(context-spec-music +(make-property-set 'tempoWholesPerMinute tempo) 'Score % If there's an articulation, use it. % If in a slur, use (1 . 1) instead. @@ -414,6 +424,14 @@ (string= t rall.)) (loop factor (cons e newelements) tail (cons 'rall actions))) ((or +(string= t accelerando) +(string= t accel) +(string= t accel.)) + (loop factor (cons e newelements) tail (cons 'accel actions))) + ((or +(string= t poco accel.)) + (loop factor (cons e newelements) tail (cons 'pocoAccel actions))) + ((or (string= t poco rall.) (string= t poco rit.)) (loop factor (cons e newelements) tail (cons 'pocoRall actions))) @@ -477,25 +495,37 @@ (make-music 'RestEvent 'duration (ly:make-duration len dots newnum newdenom)) music))) + ((accel) + (set! ac:lastTempo ac:currentTempo) + (set! ac:currentTempo (ly:moment-div ac:currentTempo ac:rallFactor)) + (let ((pset (ac:tempoChange ac:currentTempo))) +(if (null? (cdr actions)) + (make-sequential-music (list pset music)) + (make-sequential-music + (list pset (loop (cdr actions))) + + ((pocoAccel) + (set! ac:lastTempo ac:currentTempo) + (set! ac:currentTempo (ly:moment-div ac:currentTempo ac:pocoRallFactor)) + (let ((pset (ac:tempoChange ac:currentTempo))) +(if (null? (cdr actions)) + (make-sequential-music (list pset music)) + (make-sequential-music + (list pset (loop (cdr actions))) + ((rall) + (set! ac:lastTempo ac:currentTempo) (set! ac:currentTempo (ly:moment-mul ac:currentTempo ac:rallFactor)) - (let ((pset (make-music 'PropertySet - 'value - ac:currentTempo - 'symbol - 'tempoWholesPerMinute))) + (let ((pset (ac:tempoChange ac:currentTempo))) (if (null? (cdr actions)) (make-sequential-music (list pset music)) (make-sequential-music (list pset (loop (cdr actions))) ((pocoRall) + (set! ac:lastTempo ac:currentTempo) (set! ac:currentTempo (ly:moment-mul ac:currentTempo ac:pocoRallFactor)) - (let ((pset (make-music 'PropertySet - 'value - ac:currentTempo - 'symbol - 'tempoWholesPerMinute))) + (let ((pset (ac:tempoChange ac:currentTempo))) (if (null? (cdr actions)) (make-sequential-music (list pset music)) (make-sequential-music @@ -503,11 +533,8 @@ ((aTempo) (set! ac:currentTempo ac:lastTempo) - (let ((pset (make-music 'PropertySet - 'value - ac:currentTempo - 'symbol - 'tempoWholesPerMinute))) + + (let ((pset (ac:tempoChange ac:currentTempo))) (if (null? (cdr actions)) (make-sequential-music (list pset music)) (make-sequential-music @@ -621,12 +648,12 @@ (ac:adjust-props (ly:music-property music 'symbol) music) music) -(else music)) +(else music)) )) -% At last ... here's the music function that aplies all the above to a +% At last ... here's the music function that applies
PATCH: Countdown to 20120405
For 20:00 MDT Thursday April 5 Documentation: Issue 2416 http://code.google.com/p/lilypond/issues/detail?id=2416: make doc documentation - remove description the need to touch files - R5967060 http://codereview.appspot.com/5967060/ (this already has 2 LGTM, could probably be pushed without waiting for countdown) Issue 2435 http://code.google.com/p/lilypond/issues/detail?id=2435: Font size setting explanation is a bit misleading in documentation - R5969060 http://codereview.appspot.com/5969060/ Issue 2438 http://code.google.com/p/lilypond/issues/detail?id=2438: NR 1.2.3 Add explanation about reminder accidentals and \cadenzaOn - R5976056 http://codereview.appspot.com/5976056/ Cheers, Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch push announcements
When a countdown completes, I mark the tracker item patch-push and Google dutifully sends the resulting email to lilypond-auto, where it formerly went to -devel. I wonder if the owners are getting the notification, and if so, how we handle those tracker items which do not have an owner? Cheers, Colin lists, lists everywhere, nor any mail to read Campbell -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Triggers X-extent calculation for NoteColumn before setting stem-begin-position (issue 5934050)
http://codereview.appspot.com/5934050/diff/7001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/5934050/diff/7001/lily/stem.cc#newcode131 lily/stem.cc:131: Real stem_beg = internal_calc_stem_begin_position (me, false); On 2012/04/02 07:48:11, MikeSol wrote: On 2012/04/02 07:42:55, Keith wrote: I'm assuming something within calc_stem_begin_position triggers note-collision resolution That was nonsense. Note-collision resolution happens in the Preprocessing graphical objects... phase, which completes for all three scores in your regtest before the Fitting music on 1 page... phase, which is when we pass the code with the comment //trigger note collision Yup. It allows calc_stem_position to skip all of the beam business and get to the setting of note positions. You must mean something like get to the business of /looking up/ stem attachment points that were set long ago. Could you change the comment and commit message to whatever you thought I meant when you said Yup, because what I thought it meant isn't true. http://codereview.appspot.com/5934050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
