Re: PATCHES - Countdown for Nov 2nd

2018-11-03 Thread Malte Meyn
Am 02.11.18 um 23:38 schrieb Dan Eble: On Nov 2, 2018, at 10:44, James Lowe wrote: A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Somehow, https://codereview.appspot.com/353790043/

Re: ISO git-and-patch mentoring/assistance

2018-11-03 Thread David Kastrup
Kieren MacMillan writes: > Hello all, > > I'm reaching out for help with the git-and-patch process for my first > two patches. They are both very small changes — one is a tweak to an > existing music function, one is the addition of a few pieces of > syntactic sugar — which I think are perfect

Re: ISO git-and-patch mentoring/assistance

2018-11-03 Thread Thomas Morley
Am Sa., 3. Nov. 2018 um 15:04 Uhr schrieb David Kastrup : > > Kieren MacMillan writes: > > > Hello all, > > > > I'm reaching out for help with the git-and-patch process for my first > > two patches. They are both very small changes — one is a tweak to an > > existing music function, one is the

Re: Turkish makam using regular.ly

2018-11-03 Thread Hans Åberg
> On 3 Nov 2018, at 09:46, Torsten Hämmerle wrote: > > Just leave do not specify the tonic scale step in the scale/key definiton! > That's all! ;) > That way it will never be printed in the key signature. > If we set up the two special key signatures bestenigâr and revnaknüma > completely

ISO git-and-patch mentoring/assistance

2018-11-03 Thread Kieren MacMillan
Hello all, I'm reaching out for help with the git-and-patch process for my first two patches. They are both very small changes — one is a tweak to an existing music function, one is the addition of a few pieces of syntactic sugar — which I think are perfect as first attempts/submissions. I

Re: Use a stable sort when ordering MIDI items (issue 353790043 by mrbobo1...@gmail.com)

2018-11-03 Thread nine . fierce . ballads
The ticket for this review is https://sourceforge.net/p/testlilyissues/issues/5434/ . Carl, it sounds like James needs clarification as to whether you are still pressing for changing more sort calls to stable_sort calls. MHO is that this change stands fine on its own.

Re: ISO git-and-patch mentoring/assistance

2018-11-03 Thread Kieren MacMillan
Hi David and Harm, >> So the developer list as a whole seems certainly one >> somewhat viable solution to your problem. > > I'd like to second David with his recommendation to write to the devel-list. All right! I’ll do that for the "mentoring" part. For the "accountability" part, maybe I can

Re: Turkish makam using regular.ly

2018-11-03 Thread Torsten Hämmerle
Hi, Adam and Hans (in alphabetical order), I had to stop to think about it (the key signature problem). *Result: forget about all the fancy tricks, LilyPond can do it out-of-the-box!* It's rather uncommon (to say the least) to spare out a certain scale step from the key signature, so it took a

Re: Turkish makam using regular.ly

2018-11-03 Thread Adam Good
On Sat, Nov 3, 2018 at 4:46 AM Torsten Hämmerle wrote: > Just leave do not specify the tonic scale step in the scale/key definiton! > That's all! ;) > That way it will never be printed in the key signature. > Sometimes my cat has a cat treat right under her nose but she doesn't know it because

Re: PATCHES - Countdown for Nov 2nd

2018-11-03 Thread James
Hello, On 03/11/2018 07:13, Malte Meyn wrote: Am 02.11.18 um 23:38 schrieb Dan Eble: On Nov 2, 2018, at 10:44, James Lowe wrote: A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Somehow,

Re: Use a stable sort when ordering MIDI items (issue 353790043 by mrbobo1...@gmail.com)

2018-11-03 Thread Carl . D . Sorensen
On 2018/11/03 12:39:41, Dan Eble wrote: The ticket for this review is https://sourceforge.net/p/testlilyissues/issues/5434/ . Carl, it sounds like James needs clarification as to whether you are still pressing for changing more sort calls to stable_sort calls. MHO is that this change

Re: compilation with clang

2018-11-03 Thread David Kastrup
Werner LEMBERG writes: > ./include/translator.hh:78:3: note: > expanded from macro 'TRANSLATOR_FAMILY_DECLARATIONS' > DECLARE_TRANSLATOR_CALLBACKS (NAME); \ > ^ > ./include/translator.hh:97:14: note: > expanded from macro

compilation with clang

2018-11-03 Thread Werner LEMBERG
[git 964722f8046cbc77633fb8efbc4696677a579311] Folks, for better support of lilypond on MacOS I think it would be a good idea to be able to compile lilypond with clang. Trying so with clang-6.0 as provided by my openSuSE GNU/Linux box quickly aborts as follows (clang-6.0 on my MacOS Lion box

Re: compilation with clang

2018-11-03 Thread Werner LEMBERG
>> Looking around in the internet it seems that this is a real >> problem, violating the C++11 standard, cf. >> >> >> https://stackoverflow.com/questions/33872039/invalid-explicitly-specified-argument-in-clang-but-successful-compilation-in-gcc >> >> Unfortunately, I'm completely stuck with a

Re: compilation with clang

2018-11-03 Thread David Kastrup
Werner LEMBERG writes: >>> Looking around in the internet it seems that this is a real >>> problem, violating the C++11 standard, cf. >>> >>> >>> https://stackoverflow.com/questions/33872039/invalid-explicitly-specified-argument-in-clang-but-successful-compilation-in-gcc >>> >>>

Re: Turkish makam using regular.ly

2018-11-03 Thread Hans Åberg
> On 3 Nov 2018, at 17:32, Adam Good wrote: > > On Sat, Nov 3, 2018 at 4:46 AM Torsten Hämmerle > wrote: > >> Just leave do not specify the tonic scale step in the scale/key definiton! >> That's all! ;) >> That way it will never be printed in the key signature. > > Sometimes my cat has a cat

Re: compilation with clang

2018-11-03 Thread Werner LEMBERG
>> Are you *sure* that lilypond's code conforms to C++11? > > I had read the standard on this after the first report. It was > pretty clear I thought. We had a discussion then. I think that > Mojca reported it then, maybe you can look this up. Found it, together with your MWE. Note that

Re: ISO git-and-patch mentoring/assistance

2018-11-03 Thread James
Kieren, On 03/11/2018 14:27, Kieren MacMillan wrote: Hi David and Harm, So the developer list as a whole seems certainly one somewhat viable solution to your problem. I'd like to second David with his recommendation to write to the devel-list. All right! I’ll do that for the "mentoring"