LGTM. The goal is to have less dynamic casts, right?
https://codereview.appspot.com/545280043/
On 2019/11/26 08:25:04, lemzwerg wrote:
LGTM. The goal is to have less dynamic casts, right?
Yes, and most of all, fewer cases like this:
dynamic_cast (c[j])->set_system (system);
Dynamic casting is for casting to a derived type when the actual type of
the object is not known at compile
Am 16.11.19 um 21:52 schrieb David Kastrup:
But the current roadblock is David K. cherry-picking some patches. Here
is a remaining list (not completely up to date with current master,
though not missing much) to check for possible inclusion (assuming I
have not overlooked something important
I'm glad to see this. It clears up some of the confusion I've had in
digging into the code relative to the distinctions between Item, Grob,
and Paper_column.
Thanks,
Carl
https://codereview.appspot.com/545280043/
What level of respect should I maintain for the integrity of
flower/include/yaffut.h? I think it would be nice to limit the default output
of the unit test program to errors + summary, and I could achieve that either
by modifying Yaffut itself or by filtering the output through a script.
—
Dan Eble writes:
> What level of respect should I maintain for the integrity of
> flower/include/yaffut.h? I think it would be nice to limit the
> default output of the unit test program to errors + summary, and I
> could achieve that either by modifying Yaffut itself or by filtering
> the
On 2019/11/23 11:18:10, Malte Meyn wrote:
I would suggest to:
• add the label-alignments property to all spanners with exactly one
label
• think about all those different piano pedal grobs, whether they are
needed,
and how alignment could be done between the label grob and the line
grob
•
On 11/26/19, 10:40 PM, "lilyp...@maltemeyn.de" wrote:
On 2019/11/23 11:18:10, Malte Meyn wrote:
> I would suggest to:
> • add the label-alignments property to all spanners with exactly one
label
> • think about all those different piano pedal grobs, whether they are
Hey!
I'm trying to make a (small) contribution to Lilypond. The instructions
I found at
http://lilypond.org/doc/v2.19/Documentation/contributor/git_002dcl tell
me to email this address and ask for write access to the Lilypond issue
tracker.
Sourceforge username: austinglaser
Thanks in advance,
LGTM
https://codereview.appspot.com/549220043/
10 matches
Mail list logo