What's with the test-patches volunteers?

2012-04-22 Thread David Kastrup
It is close to two months that I have been the only person running test-patches, even though several volunteers claimed they would do so. It has been the main reason I shelled out €20 for a week of internet access during my spring vacation. My limited computing resources mean that I have to take

hideNotes should hide also TabNoteHead (issue 2480). (issue 6105049)

2012-04-22 Thread graham
LGTM http://codereview.appspot.com/6105049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: State of the pond

2012-04-22 Thread Francisco Vila
2012/4/22 James pkx1...@gmail.com: Hello, On 22 April 2012 00:02, Francisco Vila paconet@gmail.com wrote: 2012/4/20 Graham Percival gra...@percival-music.ca: We do not have a long history of flawless git actions from translations, so my preference would be not to touch anything. Good

Re: State of the pond

2012-04-22 Thread David Kastrup
Francisco Vila paconet@gmail.com writes: On the other hand, I can not omit doing things forever just for safety. Therefore, I have to assume a certain degree of risk. I already apologized when it went bad. After that, everything has gone smoothly. Git history will judge us all. The

Re: What's with the test-patches volunteers?

2012-04-22 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, April 22, 2012 7:31 AM Subject: What's with the test-patches volunteers? It is close to two months that I have been the only person running test-patches, even though several volunteers

Re: Footnote documentation error

2012-04-22 Thread Ian Hulin
Hi bug-squad, On 22/04/12 06:39, James wrote: Hello, On 22 April 2012 04:12, Mark Mathias d8val...@gmail.com wrote: So... as far as the Bug Squad is concerned, are we still waiting for something or does this need to get added to the tracker? Thanks, Mark As far as the bug squad are

Strange loop executed only once!

2012-04-22 Thread Łukasz Czerwiński
Hi, I have spotted a strange loop in lily/ledger-line-spanner.cc (lines 46-69): Direction d = UP; do { . } while (flip (d) != DOWN); *It will be executed only once - with d set to UP.* To be executed for d = UP and then d = DOWN, it should be: while (flip (d) !=

Re: State of the pond

2012-04-22 Thread Werner LEMBERG
Git history will judge us all. Interesting. Up to now I've assumed God does this. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: State of the pond

2012-04-22 Thread David Kastrup
Werner LEMBERG w...@gnu.org writes: Git history will judge us all. Interesting. Up to now I've assumed God does this. If HE weren't a fan of distributed version control systems, why create the world in the first place? -- David Kastrup ___

Re: State of the pond

2012-04-22 Thread Werner LEMBERG
Interesting. Up to now I've assumed God does this. If HE weren't a fan of distributed version control systems, why create the world in the first place? Good point :-) This reminds me of a joke: Two planets meet. `How are you?' `Well, not very well.' `How comes?' `I suffer from

Re: State of the pond

2012-04-22 Thread James
Hello, On 22 April 2012 11:59, David Kastrup d...@gnu.org wrote: Werner LEMBERG w...@gnu.org writes: Git history will judge us all. Interesting.  Up to now I've assumed God does this. If HE weren't a fan of distributed version control systems, why create the world in the first place?

Re: for_UP_and_DOWN

2012-04-22 Thread Han-Wen Nienhuys
sorry for the delay; I was on holidays On Fri, Apr 20, 2012 at 10:45 AM, Łukasz Czerwiński milimet...@gmail.com wrote: Could you please say, if there was a reason for using do { } while(flip(d)); instead of my macro: if (UP_and_DOWN) Macros make code harder to read for people not into the

Re: Strange loop executed only once!

2012-04-22 Thread Han-Wen Nienhuys
On Sun, Apr 22, 2012 at 7:20 AM, Łukasz Czerwiński milimet...@gmail.com wrote: Hi, I have spotted a strange loop in lily/ledger-line-spanner.cc (lines 46-69): Direction d = UP;   do     {       .     }   while (flip (d) != DOWN); It will be executed only once - with d set

Re: Part_combine_iterator::derived_mark: don't abort marking prematurely. (issue 6057044)

2012-04-22 Thread Han-Wen Nienhuys
On Wed, Apr 18, 2012 at 4:56 AM, d...@gnu.org wrote: Short of any protests, I think I'll be going with void Part_combine_iterator::derived_mark () const {  if (first_iter_)    scm_gc_mark (first_iter_-self_scm ());  if (second_iter_)    scm_gc_mark (second_iter_-self_scm ());  if

Re: What's with the test-patches volunteers?

2012-04-22 Thread Colin Campbell
On 12-04-22 03:57 AM, Phil Holmes wrote: - Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, April 22, 2012 7:31 AM Subject: What's with the test-patches volunteers? It is close to two months that I have been the only person running

Re: What's with the test-patches volunteers?

2012-04-22 Thread James
Hello, On 22 April 2012 16:00, Colin Campbell c...@shaw.ca wrote: On 12-04-22 03:57 AM, Phil Holmes wrote: - Original Message - From: David Kastrup d...@gnu.org To: lilypond-devel@gnu.org Sent: Sunday, April 22, 2012 7:31 AM Subject: What's with the test-patches volunteers? It

Doc: LM - Use Homophonic instead of Monophonic (issue 6107045)

2012-04-22 Thread dak
http://codereview.appspot.com/6107045/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/6107045/diff/1/Documentation/learning/fundamental.itely#newcode1045 Documentation/learning/fundamental.itely:1045: % The

Re: Footnote documentation error

2012-04-22 Thread Mark Mathias
So... as far as the Bug Squad is concerned, are we still waiting for something or does this need to get added to the tracker? Thanks, Mark On Fri, Apr 20, 2012 at 1:52 AM, m...@apollinemike.com m...@apollinemike.com wrote: On Apr 20, 2012, at 7:40 AM, James wrote: Hello, On 20 April

Rename translation branch

2012-04-22 Thread Francisco Vila
Hello, David and all, I'd like the lilypond/translation branch to be renamed to just 'translation' if there are no objections. David, I recall you did something similar for 'staging'. A good moment would be just after one or two 2.16 releases, I think. Comments? -- Francisco Vila. Badajoz

Re: Rename translation branch

2012-04-22 Thread David Kastrup
Francisco Vila paconet@gmail.com writes: Hello, David and all, I'd like the lilypond/translation branch to be renamed to just 'translation' if there are no objections. David, I recall you did something similar for 'staging'. A good moment would be just after one or two 2.16 releases, I

Re: Rename translation branch

2012-04-22 Thread Jean-Charles Malahieude
Le 22/04/2012 19:59, David Kastrup disait : Francisco Vilapaconet@gmail.com writes: Hello, David and all, I'd like the lilypond/translation branch to be renamed to just 'translation' if there are no objections. David, I recall you did something similar for 'staging'. A good moment would

Document fingerings being frets rather than fingers for fretted instruments. (issue 6099046)

2012-04-22 Thread tdanielsmusic
One nitpick; otherwise LGTM http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely#newcode68

Re: Document fingerings being frets rather than fingers for fretted instruments. (issue 6099046)

2012-04-22 Thread Carl . D . Sorensen
I believe that this is wrong -- fingerings are fingers for fretted instruments, not frets. http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right):

Re: Document fingerings being frets rather than fingers for fretted instruments. (issue 6099046)

2012-04-22 Thread dak
Reviewers: Trevor Daniels, carl.d.sorensen_gmail.com, http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right):

PATCH: Countdown to 20120424

2012-04-22 Thread Colin Campbell
For 20:00 MDT Tuesday April 24 Critical: Issue 2468 http://code.google.com/p/lilypond/issues/detail?id=2468: augmentation dot of a moved rest is placed on a line - R6035053 http://codereview.appspot.com/6035053/ Defect: Issue 2449

Re: Doc: LM - Use Homophonic instead of Monophonic (issue 6107045)

2012-04-22 Thread graham
LGTM, please push directly. Small suggestion below but I'm not particularly enamoured with it. You can push it whether or not you like it. http://codereview.appspot.com/6107045/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right):

Re: Doc: LM - Use Homophonic instead of Monophonic (issue 6107045)

2012-04-22 Thread graham
LGTM, please push directly. Small suggestion below but I'm not particularly enamoured with it. You can push it whether or not you like it. http://codereview.appspot.com/6107045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Let rhythmic-engraver make its articulation-or-event decision based on current listeners (issue 6098050)

2012-04-22 Thread graham
LGTM http://codereview.appspot.com/6098050/diff/2001/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/6098050/diff/2001/Documentation/changes.tely#newcode170 Documentation/changes.tely:170: Another consequence is that string numbers and right

Change \bendAfter and \rightHandFinger into event functions (issue 6102045)

2012-04-22 Thread graham
LGTM http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely#newcode1589

Re: PATCH: Countdown to 20120424

2012-04-22 Thread Carl Sorensen
On Apr 22, 2012, at 9:01 PM, Colin Campbell c...@shaw.camailto:c...@shaw.ca wrote: For 20:00 MDT Tuesday April 24 Documentation: Issue 2488http://code.google.com/p/lilypond/issues/detail?id=2488: Doc: LM - Change 'Monophonic' to 'Homophonic' - R

Re: PATCH: Countdown to 20120424

2012-04-22 Thread David Kastrup
Carl Sorensen c_soren...@byu.edu writes: On Apr 22, 2012, at 9:01 PM, Colin Campbell c...@shaw.ca wrote: For 20:00 MDT Tuesday April 24 Documentation:     Issue 2488: Doc: LM - Change 'Monophonic' to 'Homophonic' - R 6107045     Issue 2490: Patch: Document

Re: hideNotes should hide also TabNoteHead (issue 2480). (issue 6105049)

2012-04-22 Thread k-ohara5a5a
works good for me. I can see the sense in either splitting into two commits as you mentioned in email (the \hideNotes commit first) or combining into one (which makes more sense to me since they are so closely related).

Re: Let rhythmic-engraver make its articulation-or-event decision based on current listeners (issue 6098050)

2012-04-22 Thread pkx166h
http://codereview.appspot.com/6098050/diff/2001/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6098050/diff/2001/Documentation/notation/fretted-strings.itely#newcode521