Make \footnote a post-event (issue 6203044)

2012-05-10 Thread k-ohara5a5a
I like the way you showed the results of the convert-ly regexp on the docs. Step 1 looks good, and I hope you can find time to do the re-ordering by hand for step 2. http://codereview.appspot.com/6203044/diff/1018/input/regression/collision-seconds.ly File input/regression/collision-seconds.ly

Display postevents on drum notes, rests and spacer rests (issue 6195059)

2012-05-10 Thread k-ohara5a5a
It works for me. Even if I can't read Scheme I can run it, and maybe pick different test-cases than you. http://codereview.appspot.com/6195059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-10 Thread tdanielsmusic
LGTM http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simultaneous.itely:89: r4

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-10 Thread dak
http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simultaneous.itely:89: r4 e8( g

Re: Make \footnote a post-event (issue 6203044)

2012-05-10 Thread graham
LGTM http://codereview.appspot.com/6203044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Stop SkipMusic from being marked as rhythmic-event. (issue 6189051)

2012-05-10 Thread graham
LGTM http://codereview.appspot.com/6189051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Display postevents on drum notes, rests and spacer rests (issue 6195059)

2012-05-10 Thread graham
LGTM http://codereview.appspot.com/6195059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PO: modifying po-replace before integrating it to the release process (issue 6188051)

2012-05-10 Thread graham
I can't see anything wrong, but it would be nice if somebody other than lilyfan could test this. I'm on vacation so I can't really test it until May 30. http://codereview.appspot.com/6188051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: CG: add updating of lilypond.pot in the release process (issue 6195060)

2012-05-10 Thread graham
http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi File Documentation/contributor/release-work.itexi (right): http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi#newcode87

Plan for discussions

2012-05-10 Thread Graham Percival
Spent yesterday wandering around Kloten, the old town part of Zurich, and looking at stain-glass windows. Spent this morning walking along Uetliberg, a series of hills right next to the city. Travel advice: skip the city and culture, just go straight to the Alps. Ok, maybe Uetliberg isn't high

Re: CG: add updating of lilypond.pot in the release process (issue 6195060)

2012-05-10 Thread lilyfan
Uploading new version http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi File Documentation/contributor/release-work.itexi (right): http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi#newcode87

Re: Dictionary for musical terms in Lilypond

2012-05-10 Thread Łukasz Czerwiński
On 9 May 2012 10:35, Trevor Daniels t.dani...@treda.co.uk wrote: Łukasz Czerwiński wrote Sunday, April 29, 2012 12:18 PM Thanks all three of you for your immediate reply! :) I didn't know about the glossary. One problem with it is that for musical terms, except for notes and rests, it

Re: Your Gnu package lilypond

2012-05-10 Thread Janek Warchoł
On Sun, May 6, 2012 at 5:24 PM, Graham Percival gra...@percival-music.ca wrote: On Sun, May 06, 2012 at 05:15:59AM -0400, John Darrington wrote: Thank you for your very comprehensive reply, which inspired me to look at the lilypond website.  It is indeed very elaborate and certainly gives a

Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-10 Thread janek . lilypond
http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56 lily/pure-from-neighbor-engraver.cc:56: in_same_column (Grob *g1, Grob

web: update GSoC subpage (issue 6190068)

2012-05-10 Thread Carl . D . Sorensen
A couple of small grammatical suggestions. I'm fine being listed on these projects as a potential mentor. Thanks, Carl http://codereview.appspot.com/6190068/diff/1/Documentation/web/community.itexi File Documentation/web/community.itexi (right):

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-10 Thread Carl . D . Sorensen
LGTM, but I concur with the line-wrap comment of Janek. http://codereview.appspot.com/6201068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: web: update GSoC subpage (issue 6190068)

2012-05-10 Thread janek . lilypond
Reviewers: carl.d.sorensen_gmail.com, Message: fixed, thanks! http://codereview.appspot.com/6190068/diff/1/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/6190068/diff/1/Documentation/web/community.itexi#newcode878

Re: Plan for discussions

2012-05-10 Thread Janek Warchoł
On Thu, May 10, 2012 at 4:04 PM, Graham Percival gra...@percival-music.ca wrote: Spent yesterday wandering around Kloten, the old town part of Zurich, and looking at stain-glass windows.  Spent this morning walking along Uetliberg, a series of hills right next to the city. Travel advice: skip

Re: web: update GSoC subpage (issue 6190068)

2012-05-10 Thread fedelogy
Hey Janek, have you seen this thread in -bug list? http://lists.gnu.org/archive/html/bug-lilypond/2012-04/msg00042.html I think that gsoc page should be corrected now, i.e.: - hammer-on and pull-off are already implemented, the only feature to be implemented is bends (a link to issue 1196,

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-10 Thread janek . lilypond
http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc#newcode301 lily/note-collision.cc:301: of the note heads on the sides that interfere. */ So, should the offsets

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

2012-05-10 Thread Keith OHara
On Thu, 10 May 2012 17:21:54 -0700, janek.lilyp...@gmail.com wrote: The interesting thing is that the order of voices matters: [] the placement of the notes should be the same in both measures,but it isn't. The order of voices produces different placement for half notes. \override

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

2012-05-10 Thread k-ohara5a5a
http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/6197068/diff/1/Documentation/notation/simultaneous.itely#newcode89 Documentation/notation/simultaneous.itely:89: r4 e8( g

Re: Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

2012-05-10 Thread mtsolo
Reviewers: janek, carl.d.sorensen_gmail.com, http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56

PATCH: Countdown to 20120513

2012-05-10 Thread Colin Campbell
For 20:00 MDT Sunday May 13 Defect: Issue 2525 http://code.google.com/p/lilypond/issues/detail?id=2525: Patch: Fix a number of display-lily shortcomings - R 6203056 http://codereview.appspot.com/6203056/ Ugly: Issue 2469 http://code.google.com/p/lilypond/issues/detail?id=2469: