Re: PATCHES: Countdown for February 15th
Am 12. Februar 2016 12:41:30 MEZ, schrieb James: >Hello, > >Here is the current patch countdown list. The next countdown will be on >February 15th. > ... > > >4763 Web: Review GSoC page - Urs Liska >https://sourceforge.net/p/testlilyissues/issues/4763 >http://codereview.appspot.com/285400043 > > Dies this need a full neqvreview cycle? I've just uploaded a new patch set with a minimal modification. The "review" was basically over, and I suggest setting it to countdown immediately if it passes the tests. Or at least to review. Urs ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for February 15th
Hello, Here is the current patch countdown list. The next countdown will be on February 15th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ __ Push: No patches to Push at this time. Countdown: 4768 Support additional bass strings in TabStaff - Thomas Morley https://sourceforge.net/p/testlilyissues/issues/4768 http://codereview.appspot.com/286210043 4767 Crash with Completion_heads_engraver and bare durations - David Kastrup https://sourceforge.net/p/testlilyissues/issues/4767 http://codereview.appspot.com/288100043 4766 Patch: new markup command `\with-dimensions-from` - Simon Albrecht https://sourceforge.net/p/testlilyissues/issues/4766 http://codereview.appspot.com/281710043 4735 Update texinfo.tex from upstream - Masamichi Hosoda https://sourceforge.net/p/testlilyissues/issues/4735 http://codereview.appspot.com/281300043 Review: 4737 Add XeTeX for document building - Masamichi Hosoda https://sourceforge.net/p/testlilyissues/issues/4737 http://codereview.appspot.com/285790043 New: 4769 Doc: CG 3.3 separate commits and patches subsections - Paul Morris https://sourceforge.net/p/testlilyissues/issues/4769 http://codereview.appspot.com/285480043 4763 Web: Review GSoC page - Urs Liska https://sourceforge.net/p/testlilyissues/issues/4763 http://codereview.appspot.com/285400043 Waiting: 4600 Let notes/rests suppress multi-measure rest grobs - Dan Eble https://sourceforge.net/p/testlilyissues/issues/4600 http://codereview.appspot.com/265160043 James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 4767: Crash with Completion_heads_engraver and bare durations (issue 288100043 by d...@gnu.org)
LGTM https://codereview.appspot.com/288100043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: CG 3.3 separate commits and patches subsections (issue 285480043 by paulwmor...@gmail.com)
On 2016/02/12 12:49:06, benko.pal wrote: do we really need to talk about patches at all in the preferred (i.e. Rietveld-based) workflow? (do we really need any more about non preferred ways than "ask on devel"?) Good question... maybe, maybe not, but I think that deserves a separate issue/review and maybe a discussion on the dev list. (Currently anyone contributing who does not have push access (like myself) has to create patches as described in the "Making Patches" section, after a review is over, and email them to James or someone with push access who can push them. So that section currently documents part of our standard workflow, and just removing it is not so simple. I think revising the wording would help, and/or maybe changing the order of the sections so that the git-cl/Rietveld section comes first. But I think that deserves its own issue/review, if not a dev list discussion.) https://codereview.appspot.com/285480043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel