Remove white-space from storePredefinedDiagram input-string (issue 330340043 by thomasmorle...@gmail.com)

2017-09-28 Thread thomasmorley65 

Reviewers: ,

Message:
please review

Description:
Remove white-space from storePredefinedDiagram input-string

This extends issue 4575

Please review this at https://codereview.appspot.com/330340043/

Affected files (+2, -1 lines):
  M ly/predefined-fretboards-init.ly


Index: ly/predefined-fretboards-init.ly
diff --git a/ly/predefined-fretboards-init.ly  
b/ly/predefined-fretboards-init.ly
index  
acf116dd691b4069c15ce1158031742bee57422a..67821cd09579fba3ac76aa6d840d0c2ea3de824c  
100644

--- a/ly/predefined-fretboards-init.ly
+++ b/ly/predefined-fretboards-init.ly
@@ -70,7 +70,8 @@ storePredefinedDiagram =
 (car (extract-named-music chord 'EventChord
  (hash-key (cons tuning pitches))
  (verbose-definition (if (string? diagram-definition)
- (parse-terse-string diagram-definition)
+ (parse-terse-string
+   (remove-whitespace diagram-definition))
  diagram-definition)))
   (hash-set! fretboard-table
  hash-key



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

2017-09-28 Thread dak 

On 2017/09/28 10:26:05, knupero wrote:

> While we are at it, it may make sense not to refer to the no longer
> existing Gmane page for bug reports.



I changed the message, but there are 58 more places where post.gmane

is

referenced in the tree.
And there 113 mor place that reference othere places of gmane.


Ouch.


At least http://lilypond.org/bug-reports.html needs to be updated

soon.

I thought this one was already fixed.

https://codereview.appspot.com/325630043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Introduction + how/what to contribute?

2017-09-28 Thread Trevor Daniels 

"Koen Samyn" wrote Thursday, September 28, 2017 9:02 AM

Hi and Welcome!

> I am trying to get started with the lilypond source code and see where I
> can contribute, but the documentation links seem out of order, for example
> the following link:
> 
> /doc/v2.21/Documentation/contributor/summary-for-experienced-developers.htm

2.21 has not yet been released.  Try this one:

http://lilypond.org/doc/v2.19/Documentation/contributor/summary-for-experienced-developers
 
> Any pointers you can give me where extra programming help might be required?

You could browse the Issues DB:

https://sourceforge.net/p/testlilyissues/issues/
 
Trevor


---
This email has been checked for viruses by AVG.
http://www.avg.com
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

2017-09-28 Thread knupero 

While we are at it, it may make sense not to refer to the no longer
existing Gmane page for bug reports.


I changed the message, but there are 58 more places where post.gmane is
referenced in the tree.
And there 113 mor place that reference othere places of gmane.

At least http://lilypond.org/bug-reports.html needs to be updated soon.

https://codereview.appspot.com/325630043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

2017-09-28 Thread knupero 



BTW, is there any chance to reduce the width of the help screen to
stay within 78 characters?


I don't think so

https://codereview.appspot.com/325630043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Introduction + how/what to contribute?

2017-09-28 Thread Koen Samyn 
Hey lilypond developers,

I am trying to get started with the lilypond source code and see where I
can contribute, but the documentation links seem out of order, for example
the following link:

 /doc/v2.21/Documentation/contributor/summary-for-experienced-developers.htm

Any pointers you can give me where extra programming help might be required?

Maybe a little background about myself. I am a game development programming
teacher with experience in C++/OpenGL/DirectX, Java and Python. I also
teach parser and database courses.



regards,

Koen Samyn
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

2017-09-28 Thread David Kastrup 
Werner LEMBERG  writes:

>> lilypond --help gives the following output: [...]
>
>>   -O, --pspdfopt=KEY  set ps/pdf optimization to KEY 
>> (default: size)
>> KEY is either 'size', 'TeX' or 
>> 'TeX-GS'
>
> LGTM, thanks!
>
> BTW, is there any chance to reduce the width of the help screen to
> stay within 78 characters?

While we are at it, it may make sense not to refer to the no longer
existing Gmane page for bug reports.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel