Re: Issue 5310: find_top_context () maintenance (issue 341150043 by nine.fierce.ball...@gmail.com)

2018-04-21 Thread Carl . D . Sorensen
It seems like if there is a problem that this solves, there should be a regression test that shows the problem and hence why this patch is needed. https://codereview.appspot.com/341150043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Issue 5310: find_top_context () maintenance (issue 341150043 by nine.fierce.ball...@gmail.com)

2018-04-21 Thread dak
https://codereview.appspot.com/341150043/diff/1/lily/context.cc File lily/context.cc (right): https://codereview.appspot.com/341150043/diff/1/lily/context.cc#newcode723 lily/context.cc:723: find_top_context (Context ) What problem are you trying to fix here? find_top_context worked given a

Re: issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses) (issue 341140043 by torsten.haemme...@web.de)

2018-04-21 Thread torsten . haemmerle
lily/stencil-integral.cc:410: int quantization = max (0, (int) (rounded * (x_scale + y_scale) * radius * M_PI / QUANTIZATION_UNIT / 4)); [Please use a line length of at most 78 characters if possible.] In the original coding, many lines exceed 78 characters (including the one you mention

PATCHES - Countdown for April 21st

2018-04-21 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on April 23rd. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5304 Scheme typo in Notation Reference 3.3.1 - Malte Meyn