Re: Address output-distance problems: (issue 563730043 by hanw...@gmail.com)

2020-03-11 Thread Han-Wen Nienhuys
Easiest fix is probably to change disable the test for output-distance, by backing out the change GNUmakefile.in I'm curious about the exact procedure for building here. I've tested this and previous patch in various configurations. On Thu, Mar 12, 2020 at 12:49 AM David Kastrup wrote: > >

Re: Address output-distance problems: (issue 563730043 by hanw...@gmail.com)

2020-03-11 Thread David Kastrup
hanw...@gmail.com writes: > going to fast-track this so the testing can continue. > > https://codereview.appspot.com/563730043/ Patchy refuses. Staging is blocked. Since there is no point in admitting a patch that will stop master from building, I am removing from staging. I will retry to

Issue #5822 aftermath: download sizes are gone from web site

2020-03-11 Thread David Kastrup
I am not particularly surprised, to be honest: it did seem like the website would employ something other than the online-root/offline-root targets in the normal Stepmake build procedure. The sized were inaccurate anyway. I'll read up in the CG to see whether I can figure out just what scripts

Re: Address output-distance problems: (issue 563730043 by hanw...@gmail.com)

2020-03-11 Thread hanwenn
going to fast-track this so the testing can continue. https://codereview.appspot.com/563730043/

Re: Address output-distance problems: (issue 563730043 by hanw...@gmail.com)

2020-03-11 Thread jonas . hahnfeld
LGTM (It might be a good idea to suppress the output of the test run - I was seriously confused that output-distance was outputting differences before even running the regression tests. But that's for a future change.) https://codereview.appspot.com/563730043/

Re: [RFC] switch to Gerrit

2020-03-11 Thread David Kastrup
Karlin High writes: > On 3/11/2020 3:04 PM, David Kastrup wrote: >> Rietveld takes OAuth if I understand correctly. While I don't really >> know whether that is "sufficiently neutral and uncontroversial", it is >> something we have depended on for a long time. >> So while it is always good to

Re: [RFC] switch to Gerrit

2020-03-11 Thread Karlin High
On 3/11/2020 3:04 PM, David Kastrup wrote: Rietveld takes OAuth if I understand correctly. While I don't really know whether that is "sufficiently neutral and uncontroversial", it is something we have depended on for a long time. So while it is always good to improve, it doesn't sound like it

Re: [RFC] switch to Gerrit

2020-03-11 Thread David Kastrup
Karlin High writes: > On Wed, Mar 11, 2020 at 1:19 PM Jonas Hahnfeld via Discussions on > LilyPond development wrote: >> >> Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys: >> > Gerrit itself does not have an authentication service. See >> >

Re: Address output-distance problems: (issue 563730043 by hanw...@gmail.com)

2020-03-11 Thread hanwenn
On 2020/03/11 12:15:54, hahnjo wrote: > Looks mostly good to me, but I don't understand the change for . I'd > propose to push only the changes required to restore 'make check' because it's > blocking James from testing patches. > >

Re: [RFC] switch to Gerrit

2020-03-11 Thread Karlin High
On Wed, Mar 11, 2020 at 1:19 PM Jonas Hahnfeld via Discussions on LilyPond development wrote: > > Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys: > > Gerrit itself does not have an authentication service. See > >

Re: [RFC] switch to Gerrit

2020-03-11 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys: > On Wed, Mar 11, 2020 at 5:09 PM Jonas Hahnfeld < > hah...@hahnjo.de > > wrote: > > > > > Right now, LilyPond's source code is hosted on Savannah [1], our > > > > > issues > > > > > are tracked on SourceForge [2] and we review

Re: a new way to build LilyPond binary releases

2020-03-11 Thread Jonas Hahnfeld
Am Mittwoch, den 11.03.2020, 11:38 -0500 schrieb Karlin High: > On Wed, Mar 11, 2020 at 10:56 AM Jonas Hahnfeld < > hah...@hahnjo.de > > wrote: > > Please let me know if something doesn't work at all > > That sounds like an interesting project. I tested the Windows version, > and it works. I got

Re: [RFC] switch to Gerrit

2020-03-11 Thread Han-Wen Nienhuys
On Wed, Mar 11, 2020 at 5:09 PM Jonas Hahnfeld wrote: > > > > Right now, LilyPond's source code is hosted on Savannah [1], our issues > > > > are tracked on SourceForge [2] and we review patches on Rietveld [3]. > > > > There is no synchronization between the systems and a contributor is > > > >

64-bit Mac build of 2.20 is now available!

2020-03-11 Thread Marnen Laibow-Koser
Folks-- I've just published 64-bit Mac builds of 2.20 at https://bintray.com/marnen/lilypond-darwin-64/lilypond-2.20.0 . Enjoy, and please let me know if you run into any issues: it appears to work, but I haven't tested it exhaustively. Best, -- Marnen Laibow-Koser mar...@marnen.org

Re: a new way to build LilyPond binary releases

2020-03-11 Thread Karlin High
On Wed, Mar 11, 2020 at 10:56 AM Jonas Hahnfeld wrote: > Please let me know if something doesn't work at all That sounds like an interesting project. I tested the Windows version, and it works. I got a PDF from compiling { c' } as a hello-world test. Now, is this supposed to be a 64-bit

Re: [RFC] switch to Gerrit

2020-03-11 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Freitag, den 07.02.2020, 17:16 +0100 schrieb Han-Wen Nienhuys: > On Fri, Feb 7, 2020 at 5:09 PM Jonas Hahnfeld wrote: > > Am Freitag, den 07.02.2020, 12:09 +0100 schrieb Han-Wen Nienhuys: > > > [RFC] Gerrit for LilyPond > > > > > > Right now, LilyPond's source code is hosted on Savannah [1],

a new way to build LilyPond binary releases

2020-03-11 Thread Jonas Hahnfeld
We got to this topic a few times now, so here's a proper thread about it. As the title suggests, I've been working on a new way to build redistributable LilyPond binaries. Right now we are using GUB for this task (see CG and https://github.com/gperciva/gub). This is _not_ (yet) a proposal to

Re: configure.ac: Restore check for 'libguile18.h'. (issue 557580043 by lemzw...@googlemail.com)

2020-03-11 Thread lemzwerg--- via Discussions on LilyPond development
> configure.ac:195: save_CPPFLAGS="$CXXFLAGS" > Took me some time to find this two-character typo :-( > fixed in staging with commit 7fddbc0ff1 Thanks a lot! https://codereview.appspot.com/557580043/

Re: configure.ac: Restore check for 'libguile18.h'. (issue 557580043 by lemzw...@googlemail.com)

2020-03-11 Thread jonas . hahnfeld
https://codereview.appspot.com/557580043/diff/577630043/configure.ac File configure.ac (right): https://codereview.appspot.com/557580043/diff/577630043/configure.ac#newcode195 configure.ac:195: save_CPPFLAGS="$CXXFLAGS" Took me some time to find this two-character typo :-( fixed in staging with

Re: Address output-distance problems: (issue 563730043 by hanw...@gmail.com)

2020-03-11 Thread jonas . hahnfeld
Looks mostly good to me, but I don't understand the change for . I'd propose to push only the changes required to restore 'make check' because it's blocking James from testing patches. https://codereview.appspot.com/563730043/diff/577660046/scripts/build/output-distance.py File

Re: Fix Windows resource to enable manifest (issue 551580044 by truer...@gmail.com)

2020-03-11 Thread trueroad
Reviewers: lemzwerg, Be-3, dak, thomasmorley651, Message: I've added changes.tely entry in Issue 5833. This Issue 5828 became "push", but I would like to push this and Issue 5833 together. If only this issue is pushed without Issue 5833, LilyPond for Windows cannot handle some filenames. I wait

Re: Fix test target name in python/GNUmakefile (issue 581770043 by hanw...@gmail.com)

2020-03-11 Thread Han-Wen Nienhuys
On Wed, Mar 11, 2020 at 11:16 AM wrote: > > > https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile > File scripts/build/GNUmakefile (right): > > https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile#newcode19 > scripts/build/GNUmakefile:19:

Re: Fix test target name in python/GNUmakefile (issue 581770043 by hanw...@gmail.com)

2020-03-11 Thread jonas . hahnfeld
https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile File scripts/build/GNUmakefile (right): https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile#newcode19 scripts/build/GNUmakefile:19: $(PYTHON) output-distance.py --test This is wrong

Re: Added transition lines for lyrics (issue 565750043 by davidgrant...@gmail.com)

2020-03-11 Thread lemzwerg--- via Discussions on LilyPond development
> Gould talks specifically about vowels, but I don't see > any reason why it shouldn't apply to sh->ss, or even > from vowel to closed mouth. How about > gradual-syllable-change-event? Mhmm, what about simply `vowel-transition-event`? IMHO it's not necessary to invent new names.

Re: Added transition lines for lyrics (issue 565750043 by davidgrant...@gmail.com)

2020-03-11 Thread Francisco Vila
El 11/3/20 a las 3:30, nine.fierce.ball...@gmail.com escribió: I know some people hate talking about names, but can we talk about this one? Think of the kinds of events that a "transition event" might properly refer to: pretty much any. The essence of this transition is that it is gradual

Re: Added transition lines for lyrics (issue 565750043 by davidgrant...@gmail.com)

2020-03-11 Thread davidgrant . no
On 2020/03/11 02:30:04, Dan Eble wrote: > How about calling it a gradual-vowel-change-event? Come > to think of it, is this only for vowels, or would it be appropriate to use it > for, say, sh -> ss? Gould talks specifically about vowels, but I don't see any reason why it shouldn't apply to

Re: Added transition lines for lyrics (issue 565750043 by davidgrant...@gmail.com)

2020-03-11 Thread lemzwerg--- via Discussions on LilyPond development
Some more nits :-) https://codereview.appspot.com/565750043/diff/557610044/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): https://codereview.appspot.com/565750043/diff/557610044/Documentation/music-glossary.tely#newcode415

PATCHES - Countdown for March 11th

2020-03-11 Thread pkx166h
Hello, Here is the current patch countdown list. The next countdown will be on March 13th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5835 Fix test target name in python/GNUmakefile -