Re: Extracting approximate outlines from FT ?

2020-04-25 Thread Han-Wen Nienhuys
On Sat, Apr 25, 2020 at 9:42 PM Werner LEMBERG wrote: > There are two: TrueType and PostScript, which are exactly the > opposite. However, all glyphs in a font have the same orientation, so > this should be easy to handle. > > > If I can assume that external outlines go in clockwise order, I > >

Re: Transform: add print_smob to aid debugging (issue 561680043 by hanw...@gmail.com)

2020-04-25 Thread nine . fierce . ballads
https://codereview.appspot.com/561680043/diff/577820044/lily/include/transform.hh File lily/include/transform.hh (right): https://codereview.appspot.com/561680043/diff/577820044/lily/include/transform.hh#newcode33 lily/include/transform.hh:33: int print_smob (SCM p, scm_print_state *) const;

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread dak
On 2020/04/25 17:07:17, hahnjo wrote: > I strongly object to adding more random scripts to the source tree. There are > already far too many unmaintained in scripts/auxiliar/ with no documentation at > all. How about approaching this in a different manner then? Adding instructions to the CG

Re: Extracting approximate outlines from FT ?

2020-04-25 Thread Werner LEMBERG
> In https://docs.microsoft.com/en-us/typography/opentype/spec/ttch01 > it is explained that outside curves go clockwise. Does that hold for > other font types too? (PFA, OTF?) PostScript flavoured glyphs like PFA or OTF[*] have the opposite orientation. You can easily check whether the used

Re: Annoying 'langdefs.py' warning

2020-04-25 Thread Francisco Vila
El 24/4/20 a las 17:18, Jonas Hahnfeld escribió: However I'm pretty sure that many translations in the latter are dead: As far as I understand we don't translate the docs by putting the strings in Documentation/po, but rather by copying the files and translating them below Documentation/lang.

Re: Extracting approximate outlines from FT ?

2020-04-25 Thread Werner LEMBERG
> is there a standard wrt to outline direction? There are two: TrueType and PostScript, which are exactly the opposite. However, all glyphs in a font have the same orientation, so this should be easy to handle. > If I can assume that external outlines go in clockwise order, I > could skip

Transform: add print_smob to aid debugging (issue 561680043 by hanw...@gmail.com)

2020-04-25 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/561680043/

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
Reviewers: hahnjo, Message: sure. Description: Add a script for running timing benchmarks Please review this at https://codereview.appspot.com/545950043/ Affected files (+97, -0 lines): A scripts/auxiliar/benchmark.py Index: scripts/auxiliar/benchmark.py diff --git

Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread jonas . hahnfeld
I strongly object to adding more random scripts to the source tree. There are already far too many unmaintained in scripts/auxiliar/ with no documentation at all. https://codereview.appspot.com/545950043/

Re: Minor cleanups in stencil-integral.cc (issue 579630043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
On 2020/04/25 08:32:40, dak wrote: > > I have plans to do this, but they require overhaul of calling conventions in > the > > stencil -> {box,building} -> skyline pipeline. this was actually much simpler than I thought. See https://codereview.appspot.com/581960043/

Re: Fix font-name-add-files.ly on GUILE v2 (issue 567500043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
Tested on GUILE v1 (ubuntu xenial docker), and GUILE 2 (fedora) https://codereview.appspot.com/567500043/

Re: skip countdown for GUILE 2 fix

2020-04-25 Thread Han-Wen Nienhuys
Good point. I'll run it through my GUILE1 docker tests. On Sat, Apr 25, 2020 at 11:41 AM David Kastrup wrote: > > Han-Wen Nienhuys writes: > > > I just uploaded https://codereview.appspot.com/567500043 > > > > this breaks the GUILE v2 reg tests, so I'd like to push this soon. > > If you checked

Re: Fix font-name-add-files.ly on GUILE v2 (issue 567500043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
Reviewers: Valentin Villenave, Message: On 2020/04/25 09:01:49, Valentin Villenave wrote: > Thanks, this should be pushed immediately I think. > > (Man, did this regtest give us a lot of headaches.) > >

Re: skip countdown for GUILE 2 fix

2020-04-25 Thread David Kastrup
Han-Wen Nienhuys writes: > I just uploaded https://codereview.appspot.com/567500043 > > this breaks the GUILE v2 reg tests, so I'd like to push this soon. If you checked that the change doesn't break the Guile v1 tests. I mean, as far as one can check, given that those breakages also depend on

Re: Fix warnings related to po (issue 551830043 by jonas.hahnf...@gmail.com)

2020-04-25 Thread dak
On 2020/04/25 08:36:02, hahnjo wrote: > On 2020/04/24 20:14:36, hahnjo wrote: > > On 2020/04/24 18:25:33, lemzwerg wrote: > > > LGTM, thanks a lot! > > > > > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile > > > File po/GNUmakefile (right): > > > > > > > > >

Fix font-name-add-files.ly on GUILE v2 (issue 567500043 by hanw...@gmail.com)

2020-04-25 Thread v . villenave
Thanks, this should be pushed immediately I think. (Man, did this regtest give us a lot of headaches.) https://codereview.appspot.com/567500043/diff/577810043/input/regression/font-name-add-files.ly File input/regression/font-name-add-files.ly (right):

skip countdown for GUILE 2 fix

2020-04-25 Thread Han-Wen Nienhuys
I just uploaded https://codereview.appspot.com/567500043 this breaks the GUILE v2 reg tests, so I'd like to push this soon. -- Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen

Re: Fix warnings related to po (issue 551830043 by jonas.hahnf...@gmail.com)

2020-04-25 Thread jonas . hahnfeld
On 2020/04/24 20:14:36, hahnjo wrote: > On 2020/04/24 18:25:33, lemzwerg wrote: > > LGTM, thanks a lot! > > > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile > > File po/GNUmakefile (right): > > > > >

Re: Minor cleanups in stencil-integral.cc (issue 579630043 by hanw...@gmail.com)

2020-04-25 Thread dak
On 2020/04/25 07:29:06, hanwenn wrote: > On 2020/04/24 22:04:52, dak wrote: > > On 2020/04/24 21:33:12, Carl wrote: > > > On 2020/04/24 21:19:57, dak wrote: > > > > On 2020/04/24 21:18:12, dak wrote: > > > > > > > > > > > > > > >

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-25 Thread Kevin Barry
Patch is attached to this mail as a file if that is more convenient. Kevin >From 1c5715ad52139aab936ee7dffb2cdef3d123b369 Mon Sep 17 00:00:00 2001 From: Kevin Barry Date: Fri, 24 Apr 2020 19:26:26 +0100 Subject: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend As

Re: Minor cleanups in stencil-integral.cc (issue 579630043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
On 2020/04/24 22:04:52, dak wrote: > On 2020/04/24 21:33:12, Carl wrote: > > On 2020/04/24 21:19:57, dak wrote: > > > On 2020/04/24 21:18:12, dak wrote: > > > > > > > > > > https://codereview.appspot.com/579630043/diff/555740043/lily/stencil-integral.cc > > > > File lily/stencil-integral.cc