Re: Fix #5964: MM Rests shouldn’t segfault when there’s no StaffSymbol. (issue 576090043 by v.villen...@gmail.com)

2020-05-07 Thread Dan Eble
On May 7, 2020, at 11:12, v.villen...@gmail.com wrote: > No, I actually want oneline to be true . I did consider changing the > variable name to no_multiple_lines, because that’s what it’s really > about. I also considered adding a comment such as: > // If there is no StaffSymbol, print MMrests on

Issue 4182: avoid checking the offset of cross-staff stems too early (issue 554030043 by barr...@gmail.com)

2020-05-07 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly File input/regression/cross-staff-stem-offset.ly (right): https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly#newcode5

Re: Annoying 'langdefs.py' warning

2020-05-07 Thread Jean-Charles Malahieude
Le 26/04/2020 à 09:46, Jonas Hahnfeld a écrit : Am Samstag, den 25.04.2020, 21:53 +0200 schrieb Francisco Vila: El 24/4/20 a las 17:18, Jonas Hahnfeld escribió: However I'm pretty sure that many translations in the latter are dead: As far as I understand we don't translate the docs by putting

Re: Fix #5964: MM Rests shouldn’t segfault when there’s no StaffSymbol. (issue 576090043 by v.villen...@gmail.com)

2020-05-07 Thread Carl . D . Sorensen
Here's a thought. https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc File lily/multi-measure-rest.cc (right): https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc#newcode268 lily/multi-measure-rest.cc:268: bool oneline = (!staff) ||

Re: Fix #5964: MM Rests shouldn’t segfault when there’s no StaffSymbol. (issue 576090043 by v.villen...@gmail.com)

2020-05-07 Thread v . villenave
https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc File lily/multi-measure-rest.cc (right): https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc#newcode268 lily/multi-measure-rest.cc:268: bool oneline = (!staff) ||

Re: Fix #5964: MM Rests shouldn’t segfault when there’s no StaffSymbol. (issue 576090043 by v.villen...@gmail.com)

2020-05-07 Thread nine . fierce . ballads
https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc File lily/multi-measure-rest.cc (right): https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc#newcode268 lily/multi-measure-rest.cc:268: bool oneline = (!staff) ||

Re: Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets" (issue 559930043 by v.villen...@gmail.com)

2020-05-07 Thread v . villenave
Reviewers: lemzwerg, Message: On 2020/04/30 19:33:03, lemzwerg wrote: > LGTM, thanks! Thanks Werner! I added your suggestions and pushed it as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=ee56da0f7a68cb6d6c5cd8531a566d81abdc5e59 V. Description: Doc: mention tuplet-slur in Changes

PATCHES - Countdown for May 7th

2020-05-07 Thread pkx166h
Hello, Here is the current patch countdown list. The next countdown will be on May 9th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5962 Avoid using Skyline_pair::insert. - Han-Wen Nienhuys

Re: Almost, but not quite: C++ STL in LilyPond

2020-05-07 Thread David Kastrup
David Kastrup writes: > David Kastrup writes: > >> Han-Wen Nienhuys writes: >> >>> On Tue, May 5, 2020 at 5:49 PM Jonas Hahnfeld wrote: Am Dienstag, den 05.05.2020, 17:09 +0200 schrieb David Kastrup: > I am currently digging back and forth regarding implementation of our >

Re: Vertical alignment of non AxisGroup grobs

2020-05-07 Thread James Lowe
Hello Valentin, On 06/05/2020 13:24, Valentin Petzel wrote: Hi everyone, I’m looking into doing large time sigs found in modern conducting scores in lilypond. For that reason I need to place TimeSignatures that are not in a Vertical axis group on the score. Is there any way to vertically align

Re: Almost, but not quite: C++ STL in LilyPond

2020-05-07 Thread David Kastrup
Jonas Hahnfeld writes: > Am Donnerstag, den 07.05.2020, 07:57 +0200 schrieb Han-Wen Nienhuys: >> In my mind, supporting GUILE 2.x means supporting byte compilation >> because we'd otherwise regress startup speed by a second or so. >> >> That is currently blocked on your proposed alternative to

Re: Almost, but not quite: C++ STL in LilyPond

2020-05-07 Thread Jonas Hahnfeld
Am Donnerstag, den 07.05.2020, 07:57 +0200 schrieb Han-Wen Nienhuys: > In my mind, supporting GUILE 2.x means supporting byte compilation > because we'd otherwise regress startup speed by a second or so. > > That is currently blocked on your proposed alternative to >