https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc#newcode268
lily/multi-measure-rest.cc:268: bool oneline = (!staff) ||
https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
https://codereview.appspot.com/576090043/diff/557790043/lily/multi-measure-rest.cc#newcode268
lily/multi-measure-rest.cc:268: bool oneline = (!staff) ||
On 08/05/2020 12:21, Jonas Hahnfeld wrote:
Am Freitag, den 08.05.2020, 13:07 +0200 schrieb David Kastrup:
Jonas Hahnfeld writes:
3) The idea is to have the "main" repository at GitLab, next to the
issues and merge requests. This leads to the question what to do with
Savannah because git is
Reviewers: hanwenn,
Message:
On 2020/05/08 17:12:41, hanwenn wrote:
> I don't understand how this approach could ever help byte-compiling
the markup
> scheme files. This still uses module-define! , so the guile2
compilation step
> will be oblivious to markup functions.
It makes it easier to
I don't understand how this approach could ever help byte-compiling the
markup scheme files. This still uses module-define! , so the guile2
compilation step will be oblivious to markup functions.
https://codereview.appspot.com/547920045/
[forgot to send it previously]
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc
File lily/freetype.cc (right):
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode126
lily/freetype.cc:126: else if (outline->tags[j] & 1)
On 2020/05/08 08:15:58,
https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc
File lily/freetype.cc (right):
https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc#newcode129
lily/freetype.cc:129: else if (ctags[j] & 1)
1 → FT_CURVE_TAG_ON
On Fri, May 8, 2020 at 4:28 PM wrote:
> > seems to make the assertion output comparatively useless. Wouldn't it
> be better
> > to do such things as
> >
> > else {
> > assert(condition);
> > ...
> > }
> >
> > instead?
>
> I'm used to the following idiom from LLVM:
> assert(0 && "Unknown
On 2020/05/08 14:24:18, dak wrote:
> On 2020/05/08 14:14:47, hahnjo wrote:
>
> > assert(false) that none of the previous cases was true? That should
detect a
> > breaking change in FT_Outline pretty quickly.
>
> else if (condition)
> { ... }
> else assert(false);
>
> seems to make the assertion
On 2020/05/08 14:14:47, hahnjo wrote:
> assert(false) that none of the previous cases was true? That should
detect a
> breaking change in FT_Outline pretty quickly.
else if (condition)
{ ... }
else assert(false);
seems to make the assertion output comparatively useless. Wouldn't it
be better
On Fri, May 8, 2020 at 4:14 PM wrote:
>
> On 2020/05/08 14:03:23, hanwenn wrote:
> >
> https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode162
> > lily/freetype.cc:162: }
> > On 2020/05/08 08:15:59, hahnjo wrote:
> > > This code looks very familiar. Don't we already
On 2020/05/08 14:03:23, hanwenn wrote:
>
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode162
> lily/freetype.cc:162: }
> On 2020/05/08 08:15:59, hahnjo wrote:
> > This code looks very familiar. Don't we already have it in
> > make_draw_bezier_boxes?
>
> yes.
So
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc
File lily/freetype.cc (right):
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode105
lily/freetype.cc:105: bool is_tt = (0 == strcmp ("TrueType",
FT_Get_Font_Format (face)));
On 2020/05/08
Am Freitag, den 08.05.2020, 13:07 +0200 schrieb David Kastrup:
> Jonas Hahnfeld writes:
>
> > 3) The idea is to have the "main" repository at GitLab, next to the
> > issues and merge requests. This leads to the question what to do with
> > Savannah because git is distributed anyway. I first
Jonas Hahnfeld writes:
> 3) The idea is to have the "main" repository at GitLab, next to the
> issues and merge requests. This leads to the question what to do with
> Savannah because git is distributed anyway. I first thought about only
> pushing "important" branches and tags to GitLab (master,
Am Freitag, den 08.05.2020, 11:03 +0200 schrieb Valentin Villenave:
> On 5/8/20, Jonas Hahnfeld wrote:
> > 3) The idea is to have the "main" repository at GitLab, next to the
> > issues and merge requests.
>
> If the two are kept in sync (if and when you enable mirroring), does
> that mean some
On 5/8/20, Jonas Hahnfeld wrote:
> I haven't heard further objections which, for me, means we are going
> with GitLab. If you don't agree, now's your final time to speak up.
Thanks for tackling this!
> 3) The idea is to have the "main" repository at GitLab, next to the
> issues and merge
Am Freitag, den 08.05.2020, 10:17 +0200 schrieb Jean-Charles
Malahieude:
> Le 08/05/2020 à 08:57, Jonas Hahnfeld a écrit :
> > I haven't heard further objections which, for me, means we are going
> > with GitLab. If you don't agree, now's your final time to speak up.
> > Otherwise I would like to
Le 08/05/2020 à 08:57, Jonas Hahnfeld a écrit :
I haven't heard further objections which, for me, means we are going
with GitLab. If you don't agree, now's your final time to speak up.
Otherwise I would like to tackle the migration rather soon to take
advantage of the new opportunities :-)
This
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc
File lily/freetype.cc (right):
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode105
lily/freetype.cc:105: bool is_tt = (0 == strcmp ("TrueType",
FT_Get_Font_Format (face)));
Can we have this
Thank you for looking at this! Issues should be fixed.
https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly
File input/regression/cross-staff-stem-offset.ly (right):
I haven't heard further objections which, for me, means we are going
with GitLab. If you don't agree, now's your final time to speak up.
Otherwise I would like to tackle the migration rather soon to take
advantage of the new opportunities :-)
This leads me to some final considerations:
1) I'm
22 matches
Mail list logo
