separate narrowed accidentals (issue 5527049)

Reviewers: , Message: ignore first 3 sentences, it was a mistake. http://code.google.com/p/lilypond/issues/detail?id=2203 Description: separate narrowed accidentals leaving arrows alone font: narrowed variants of accidentals As discussed in issue 2142, narrower versions of accidentals

Re: separate narrowed accidentals (issue 5527049)

According to suggestions, narrow natural was made a bit wider. New example files attached to tracker issue http://code.google.com/p/lilypond/issues/detail?id=2203 http://codereview.appspot.com/5527049/ ___ lilypond-devel mailing list

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1350 Documentation/notation/rhythms.itely:1350: partial measure

Re: explain how to add git-cl to PATH (issue 5503093)

pushed to staging and closed. http://codereview.appspot.com/5503093/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let \footnote do the job of \footnote, \footnoteGrob, \autoFootnote and \autoFootnoteGrob (issue 5527058)

There are some duplications in the docs now. (LBTM?) http://codereview.appspot.com/5527058/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5527058/diff/1/Documentation/notation/input.itely#newcode1053

Re: Glyphs for Kievan Notation (issue 4951062)

http://codereview.appspot.com/4951062/diff/91002/input/regression/note-head-style.ly File input/regression/note-head-style.ly (right): http://codereview.appspot.com/4951062/diff/91002/input/regression/note-head-style.ly#newcode101 input/regression/note-head-style.ly:101: add break here

Re: Implements DOM-id property for grobs. (issue 5504106)

Hi Mike, could you add some comments to the code and/or commit message explaining what it does? I've read whole patch and i don't understand what happens here, except that it's some kind of XML identifier. tia, Janek http://codereview.appspot.com/5504106/

Re: Issue 2100: Explanation of branches for CG (issue 5539062)

Some thoughts on making all this less confusing to beginners. http://codereview.appspot.com/5539062/diff/3004/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right):

Re: Issue 2100: Explanation of branches for CG (issue 5539062)

http://codereview.appspot.com/5539062/diff/3004/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5539062/diff/3004/Documentation/contributor/source-code.itexi#newcode297

Re: Glyphs for Kievan Notation (issue 4951062)

Aleksandr, i apologize for not replying so long. I've tested your patch and i see only one problem, see below. When you fix it, could you merge all changes into one commit (using 'git rebase -i origin/master'), make a patch and send it to James? I guess he has to check it manually since Patchy

Re: changes.tely: mention Flag changes, remove duplicate does (issue 5540058)

lgtm http://codereview.appspot.com/5540058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Docs: Explain the difference between ritardando and rallentando (issue 5544075)

lgtm http://codereview.appspot.com/5544075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2100: Explanation of branches for CG (issue 5539062)

On 2012/01/19 16:07:59, Carl wrote: On 2012/01/17 20:31:24, Graham Percival wrote: On Tue, Jan 17, 2012 at 08:24:35PM +, mailto:janek.lilyp...@gmail.com wrote: could we change this (and other similar) prefix so that it doesn't contain a slash? I mean, change dev/ to dev- or something

Re: Issue 2100: Explanation of branches for CG (issue 5539062)

LGTM. Good job, Carl! http://codereview.appspot.com/5539062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implements DOM-id property for grobs. (issue 5504106)

Hi Mike, i apologize for the delay; i focused on other things that seemed more urgent to me. On 2012/01/11 12:27:10, mike_apollinemike.com wrote: [explanation of the patch] I'm not sure how/where to include this info in the source: if you can think of a good way to phrase it that would

Re: lilypond-book: Group line-width settings together (issue 2222). (issue 5553056)

Hi Julien, could you please explain to me how your patch fixes this issue? I've read it but don't understand why it works :( thanks, Janek http://codereview.appspot.com/5553056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Update lilygit.tcl (Issue 2092) (issue 5504092)

Some questions and concerns. thanks, Janek http://codereview.appspot.com/5504092/diff/14001/scripts/auxiliar/lily-git.tcl File scripts/auxiliar/lily-git.tcl (right): http://codereview.appspot.com/5504092/diff/14001/scripts/auxiliar/lily-git.tcl#newcode222 scripts/auxiliar/lily-git.tcl:222:

Re: lilypond-book: Group line-width settings together (issue 2222). (issue 5553056)

Thanks for explanations, Julien! Janek http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py#oldcode184 python/book_snippets.py:184: line-width = #(- line-width (* mm

Re: lilypond-book: Group line-width settings together (issue 2222). (issue 5553056)

Thanks for explanations, Julien! Janek http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/5553056/diff/1/python/book_snippets.py#oldcode184 python/book_snippets.py:184: line-width = #(- line-width (* mm

Re: Makes sure dynamics don't budge for tuplet brackets. (issue 5555046)

So the problem was that by default tupletBracket doesn't have outside-staff-priority (because we want it to be placed on staff lines sometimes), and the code failed to check for that? But i don't see how this patch solved the same problem with outside-staff-priority set to something: { % this

Re: Fix beaming-pattern for compound meters (issue 5545067)

Hi Carl, is this patch obsolete and replaced by http://codereview.appspot.com/5556054 ? If so, please close this issue. thanks, Janek http://codereview.appspot.com/5545067/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fix issue 2228: Add option for strictBeatBeaming (issue 5556054)

LGTM. I'm not sure if the word flags should be used here. http://codereview.appspot.com/5556054/diff/2001/input/regression/beamlet-point-toward-beat.ly File input/regression/beamlet-point-toward-beat.ly (right):

Re: Spelling fixes in comments and documentation (issue 5562043)

LGTM http://codereview.appspot.com/5562043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

change bugreports expected response time (issue 5575047)

Reviewers: , Message: Graham noticed that we fail to examine bugreports in 24 hours, so let's change the information on website. http://lists.gnu.org/archive/html/lilypond-devel/2012-01/msg00839.html Description: change bugreports expected response time Please review this at

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

mostly LGTM http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1358 Documentation/notation/rhythms.itely:1358: The

Re: Glyphs for Kievan Notation (issue 4951062)

only one change left. On 2012/01/23 01:02:13, aleksandr.andreev wrote: Regarding comments by Jan: I guess it should be 2.5 staff_space or something I changed the depth and height parameters as you suggested. However, I do not see any difference, in the reg tests or in my test files. Are

Re: Gets vertical skylines from grob stencils (issue 5626052)

On 2012/02/06 19:25:34, mike_apollinemike.com wrote: On Feb 6, 2012, at 8:00 PM, Joe Neeman wrote: Could you publicize work-in-progress patches like this as a git branch instead of a Rietveld issue? Ok. For the git-handicapped (me), how does one do this? Push a private branch to our

Re: Glyphs for Kievan Notation (issue 4951062)

This was pushed as 18dda6b2f5fbea91a174b60eb22bbb73591b9b64 Thanks, Aleksandr and all reviewers! Janek http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

some comments and complaints on the code (issue 5651069)

Reviewers: milimetr88, Message: Hi, together with Luke (milimet...@gmail.com) we're preparing a fix for http://code.google.com/p/lilypond/issues/detail?id=1546 We had a really hard time on Wednesday trying to understand how the current code works; after 4 hours of reading we have some grasp

Re: some comments and complaints on the code (issue 5651069)

On 2012/02/10 23:49:24, Carl wrote: Thanks for taking this on, Janek. I don't know what the response will be to for_UP_and_DOWN(d). The last time somebody proposed a change, it was resisted because the do{} flip(d)!=UP idiom seemed simple enough to be acceptable. It took us a while to

Re: some comments and complaints on the code (issue 5651069)

Forgot about one thing, sorry http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode552 lily/note-collision.cc:552: for_UP_and_DOWN (d) // please, make a comment to

Re: some comments and complaints on the code (issue 5651069)

new patch set uploaded, please review. http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode588 lily/note-collision.cc:588: { On 2012/02/11 12:32:57, Milimetr88 wrote:

Re: Implements DOM-id property for grobs. (issue 5504106)

Mike, again i was outrageously slow, i apologize. Thanks for the explanations, i see now that the code is pretty clear when you're accustomed to our code base a little. I think the docstring you wrote is everything that's needed for this, so no need to do anything more here. Sorry for delay. I

WebCG: remove projects from HelpUs (issue 5665047)

Reviewers: , Message: I'll update translations when a consensus regarding english version will be reached. Description: WebCG: remove projects from HelpUs CG 1.1 Help us and website community/help us both contain projects section, but: - noone knows when GLISS will happen - Frogs are

CG: add information about Regtest Checking Project (issue 5669047)

Reviewers: , Message: Please review. The most important question is: will this be clear for average user, who hadn't participated in development previously? Description: CG: add information about Regtest Checking Project Phil Holmes wrote a nice web app that allows people to review regtests,

Re: CG: add information about Regtest Checking Project (issue 5669047)

http://codereview.appspot.com/5669047/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5669047/diff/1/Documentation/contributor/regressions.itexi#newcode511 Documentation/contributor/regressions.itexi:511:

Re: WebCG: remove projects from HelpUs (issue 5665047)

http://codereview.appspot.com/5665047/diff/1/Documentation/included/helpus.itexi File Documentation/included/helpus.itexi (right): http://codereview.appspot.com/5665047/diff/1/Documentation/included/helpus.itexi#newcode89 Documentation/included/helpus.itexi:89: @ignore On 2012/02/14 18:48:42,

Re: some comments and complaints on the code (issue 5651069)

Dear Han-Wen, Keith and Joe, many thanks for your comments and advice! I appreciate your feedback and apologize that i didn't respond yet; i was waiting for Łukasz (milimetr88@gmail) to decide together what we shall do, but he's currently busy :/ Please give us a few more days. Meanwhile, i

Re: Remove Time-signature from Kievan Staff (issue 5672063)

Looks Good To Me http://codereview.appspot.com/5672063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: recommend setting ragged-last-bottom to false for large scores (issue 5651077)

On 2012/02/17 12:34:29, mail_philholmes.net wrote: Graham wrote Pavel, please send the final patch to somebody for pushing. Janek is away until after Sunday. I'm back and i can push it if you send me patch file. cheers, Janek http://codereview.appspot.com/5651077/

Re: Doc: recommend setting ragged-last-bottom to false for large scores (issue 5651077)

I see that it's aa5c08ccb3a9bbe3a91c2a22e09880486cebac72 marking issue as fixed, thanks. Janek PS Pavel, please close this Rietveld issue http://codereview.appspot.com/5651077/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: WebCG: remove projects from HelpUs (issue 5665047)

On 2012/02/14 18:48:42, Graham Percival wrote: http://codereview.appspot.com/5665047/diff/1/Documentation/web/community.itexi#newcode515 Documentation/web/community.itexi:515: @helpusAdvanced I'm ok with this change, but the @helpusProjects should be in a @divClass{column-center-bottom}. On

Re: Gets vertical skylines from grob stencils (issue 5626052)

Hi, sorry, Mike - i got confused and forgotten that a patchset newer than what i had is here, on Rietveld. I see that you've fixed hairpins and added skylines to accidentals, flags and beams - great! Unfortunately I've spotted some problems with DynamicSigns - they are too high (as of patchset

Re: Remove Time-signature from Kievan Staff (issue 5672063)

On 2012/02/22 15:41:37, aleksandr.andreev wrote: On 2012/02/16 11:32:18, janek wrote: Looks Good To Me I think this can be pushed. Oops, i see now that the tracker issue (http://code.google.com/p/lilypond/issues/detail?id=2318) doesn't have a Patch label, and therefore isn't included in

Re: CG: add information about Regtest Checking Project (issue 5669047)

New patch set uploaded. On 2012/02/17 12:04:10, Graham Percival wrote: http://codereview.appspot.com/5669047/diff/5001/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right):

Add layout changing command \layout-from for getting context defs from music (issue 5686046)

LGTM http://codereview.appspot.com/5686046/diff/1/ly/context-mods-init.ly File ly/context-mods-init.ly (right): http://codereview.appspot.com/5686046/diff/1/ly/context-mods-init.ly#newcode45 ly/context-mods-init.ly:45: contexts. I like this description.

Re: Add layout changing command \layout-from for getting context defs from music (issue 5686046)

HTH, Janek http://codereview.appspot.com/5686046/diff/1/ly/context-mods-init.ly File ly/context-mods-init.ly (right): http://codereview.appspot.com/5686046/diff/1/ly/context-mods-init.ly#newcode49 ly/context-mods-init.ly:49: to @code{'Voice}. On 2012/02/23 00:53:58, dak wrote: On 2012/02/23

CG: Use latest convert-ly for LSR updates (fix 2346) (issue 5696069)

Reviewers: , Message: Please review. I'm very busy with GSoC now, so if you identify deficiencies, please write verbose changes you want done. Otherwise i will update it somewhere in March, sorry :( Janek Description: CG: Use latest convert-ly for LSR updates (fix 2346) Suggested by Thomas

Re: CG: add information about Regtest Checking Project (issue 5669047)

New patch set uploaded, it should make doc now. Thanks for the tips, Carl and Graham! You saved me some time. I decided not to use @rglos and @rinternals (because from what i understand it would print the name of the section i'm referring to) but use @rglosnamed and @rinternalsnamed instead.

Re: WebCG: remove projects from HelpUs (issue 5665047)

pushed as ee5f21d7ed3b985913194699aa1d412e4bced562 http://codereview.appspot.com/5665047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

CG: a note about articulations on EventChord (issue 5696080)

Reviewers: , Message: This is a bit vague and perhaps wordy, but i found it really helpful when David was changing EventChord. I'm not sure if this text reflects how things work now (wrt/ David's changes) - hopefully someone knowledgeable will confirm. Description: CG: a note about

Re: Issue 2100: Explanation of branches for CG (issue 5539062)

Carl, could you close this Rietveld issue? Janek http://codereview.appspot.com/5539062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG: add information about Regtest Checking Project (issue 5669047)

Screw this; i tried using regular refs but they produced hideous effects in html. I'm going back to named references; they are not perfect but acceptable i'd say. http://codereview.appspot.com/5669047/ ___ lilypond-devel mailing list

web: rephrase bugreports section (issue 5698070)

Reviewers: , Message: Please review. Description: web: rephrase bugreports section According to Graham's favorite rule (perfection is attained when there's nothing more to delete) i'm rephrasing bugreports section hoping to make it even more brief and straightforward for all users. Please

Allow music with layout instructions in output definitions. (issue 5701049)

/janek/lilypond-git/build/out/share/lilypond/current/scm/lily-library.scm:314:40: In expression (_f Cannot find context-def \\~a sym): /home/janek/lilypond-git/build/out/share/lilypond/current/scm/lily-library.scm:314:40: Unbound variable: _f Also, it fails to compile next .ly file in queue (when i

Re: Remove Time-signature from Kievan Staff (issue 5672063)

pushed to staging as f154d90b9627c04a195ff3b286fe9737f8c8bc27; this Rietveld issue can be closed. Thanks! http://codereview.appspot.com/5672063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: CG: Use latest convert-ly for LSR updates (fix 2346) (issue 5696069)

New patch set. http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi File Documentation/contributor/lsr-work.itexi (right): http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi#newcode302

changes.tely: declare MacOSX unsupported (issue 5694092)

Maybe add some encouragement for getting involved? http://codereview.appspot.com/5694092/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/5694092/diff/1/Documentation/changes.tely#newcode71 Documentation/changes.tely:71: provide timely

Re: CG: add information about Regtest Checking Project (issue 5669047)

pushed as 90ee61d5b681295b8b401128ca9bc48554eee66a closed http://codereview.appspot.com/5669047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

add ly:book-set-header! (issue 5720062)

Reviewers: , Message: From Jan-Peter Voigt, please review: Hello list, sorry for resending this, it might get lost, because I simply answered to another thread with another subject. now, we have a book-predicate and we are dealing with books in scheme. Then we might want to set a header after

LM - Remove obsolete statement (issue 5713053)

LGTM http://codereview.appspot.com/5713053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gets vertical skylines from grob stencils (issue 5626052)

Mike all, i did a quick compile with patchset 36 and unfortunately didn't notice significant speedups from previous version. Compilation time differences vary widely depending on music (from 5% to 100% longer) PROCESSING ../dynamics.ly WITH MASTER: -- real0m0.762s user

Web: add GSoC ideas list (issue 5753059)

Reviewers: Graham Percival, carl.d.sorensen_gmail.com, MikeSol, lemzwerg, Reinhold, joeneeman, Message: Please review asap, it's only a couple days left before application deadline. http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi File

Re: Web: add GSoC ideas list (issue 5753059)

New patchset. On Tue, Mar 6, 2012 at 6:36 PM, gra...@percival-music.ca wrote: If you add a new section to the website without changing the relevant part of Documentation/lilypond-texi2html.init, the colors will get messed up. See line 1516. done. Actually, i think that one entry was already

Re: Web: add GSoC ideas list (issue 5753059)

Fixed http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1012 Documentation/web/community.itexi:1012: @subheading Better

Allow music in contextmods (issue 5796052)

David, i'm sorry because i cannot give your patch a proper review, but i appreciate your work. I think Lily really needs changes like this. thanks, Janek http://codereview.appspot.com/5796052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: NR: Polyphony - use voiceX not \xxxup/down (issue 5754074)

LGTM http://codereview.appspot.com/5754074/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: Add more 'Concerts' to introduction.itexi (issue 6007048)

one typo http://codereview.appspot.com/6007048/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): http://codereview.appspot.com/6007048/diff/1/Documentation/web/introduction.itexi#newcode509 Documentation/web/introduction.itexi:509: musical director.

Re: Fixing height of Kievan bar line (issue 5727051)

pushed as 505fa5b0ee7bf06bcefea05a3854c31e63e991ba please close this Rietveld issue, thanks! Janek http://codereview.appspot.com/5727051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: web: add news about GSoC 2012 (issue 6112050)

Reviewers: Graham Percival, Message: On 2012/04/25 03:24:56, Graham Percival wrote: I get a chunk mismatch for the side-by-side comparison, but the actual patch is fine. Go ahead and push directly to staging. pushed as bf2c7f09ff00e6c59877eff5ba5f880299ed95bf, thanks! Description: web:

Allows lyrics to slide under TimeSignature when OctaveEight present. (issue 6201068)

http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/6201068/diff/1/lily/pure-from-neighbor-engraver.cc#newcode56 lily/pure-from-neighbor-engraver.cc:56: in_same_column (Grob *g1, Grob

Re: web: update GSoC subpage (issue 6190068)

Reviewers: carl.d.sorensen_gmail.com, Message: fixed, thanks! http://codereview.appspot.com/6190068/diff/1/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/6190068/diff/1/Documentation/web/community.itexi#newcode878

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6189048/diff/10001/lily/note-collision.cc#newcode301 lily/note-collision.cc:301: of the note heads on the sides that interfere. */ So, should the offsets

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

LGTM http://codereview.appspot.com/6197068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Use fractions rather than Scheme pairs for \scaleDuration, timeSignatureFraction et al (issue 6200068)

I don't know the parser stuff (and no time to figure it out), but docs LGTM. http://codereview.appspot.com/6200068/diff/2001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right):

Re: Add mail aliases for Carl, Colin, Janek, and Pál, for the sake of git shortlog (issue 6206057)

one concern about Pal. http://codereview.appspot.com/6206057/diff/1/.mailmap File .mailmap (right): http://codereview.appspot.com/6206057/diff/1/.mailmap#newcode5 .mailmap:5: Benkő Pál benko@gmail.com It seems that this document is in the format given name surname, so here it should be Pál

Re: web: update GSoC subpage (issue 6190068)

http://codereview.appspot.com/6190068/diff/1002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/6190068/diff/1002/Documentation/web/community.itexi#newcode884 Documentation/web/community.itexi:884: for 2012 edition of the program;

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

LGTM I apologize that you had to wait. Thank you for your work!! http://codereview.appspot.com/6189048/diff/9003/input/regression/collision-whole.ly File input/regression/collision-whole.ly (right): http://codereview.appspot.com/6189048/diff/9003/input/regression/collision-whole.ly#newcode16

Re: note-collison.cc: Scale shifts by width of note at left; issue 1713 (issue 6189048)

On 2012/05/15 07:31:09, Keith wrote: On 2012/05/15 06:48:09, janek wrote: Why don't we get gid of that multiplication? That is my plan. See Patch Set 1 for a preview. All note-collision spacing is scaled by the first down-stem note, so each path through the collision code needs to use

Re: web: update GSoC subpage (issue 6190068)

pushed as ae4701688c122849fc9228b6806f20e6f23d2a7d, closed. thanks, janek http://codereview.appspot.com/6190068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow tweaks in Lyrics. (issue 6221046)

Cool! So for example http://lsr.dsi.unimi.it/LSR/Item?id=643 will work without having to do something in \layout block. I love changes like this! http://codereview.appspot.com/6221046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: web: news about cancelled rc (issue 6223054)

Reviewers: dak, Graham Percival, Message: New version. On 2012/05/21 17:51:11, Graham Percival wrote: I hate to be a mao, but I believe I suggested a new news item? I thought that it was a non-obligatory suggestion. Think of each news item as a tweet or something like that. We have a new

Re: add \shape (issue 6255056)

generally LGTM. What about coloring the \shaped curves? This would make checking regtests more obvious to an ordinary person who may be not familiar with this stuff. thanks, David! http://codereview.appspot.com/6255056/diff/1/input/regression/shape-other-curves.ly File

Re: add \shape (issue 6255056)

it's good! http://codereview.appspot.com/6255056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: news: RC 2.15.39 withdrawn (issue 6280044)

Reviewers: Graham Percival, Message: On 2012/06/02 15:43:45, Graham Percival wrote: LGTM, push to staging now. Done. I'll push directly next time, if that's fine with you. closed Description: news: RC 2.15.39 withdrawn add news item and move some news to old news. Please review this at

Re: add \shape (issue 6255056)

Hi David, please close this Rietveld issue (crossed circle next to its name). cheers, Janek http://codereview.appspot.com/6255056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely#newcode210 Documentation/notation/keyboards.itely:210: e''2\p\

Re: cleanup: infinity, get property (issue 6310043)

Hi, i've moved things around. I've used your suggestion to check if it works at all - it works, but the results are wrong ;) That's not a problem, though; I'll fix them tomorrow. Meanwhile please take a look at my previous comments in Lyric_engraver (before the function was moved):

Re: cleanup: infinity, get property (issue 6310043)

How do you like this? I've tried to define a new property lyricDefaultAlignment (similar to lyricMelismaAlignment) and use it in line 47, but i got an error: 'internal_get_property' was not declared in this scope I'll investigate when i get back home. http://codereview.appspot.com/6310043/

Re: cleanup: infinity, get property (issue 6310043)

On Fri, Jun 15, 2012 at 6:48 PM, David Kastrup d...@gnu.org wrote: Janek Warchoł janek.lilyp...@gmail.com writes: indeed, i'm more silly than i thought. Is the inheritance correct now? I still get an error, though... Btw, why doesn't Flag inherit from Item? Good question. Looking through

Re: Documentation of Kievan notation (issue 6303095)

LGTM, minor style issues. http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): http://codereview.appspot.com/6303095/diff/1/Documentation/music-glossary.tely#newcode4539 Documentation/music-glossary.tely:4539:

Re: Documentation of Kievan notation (issue 6303095)

LGTM http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): http://codereview.appspot.com/6303095/diff/1/Documentation/notation/ancient.itely#newcode2566 Documentation/notation/ancient.itely:2566: @end lilypond On

Re: get rid of minimum-[XY]-extents (issue 6294086)

Reviewers: Keith, david.nalesnik, Message: Hi Keith, David (i'd like to know your opinion about something here) and all, On 2012/06/19 08:53:44, Keith wrote: Nobody told me minimum-*-extents were deprecated, except for their use in staff-spacing, You're right, i was imprecise: they are

[XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

Reviewers: MikeSol, joeneeman, Message: A pdf showing what this patch does is attached to tracker issue: http://code.google.com/p/lilypond/issues/detail?id=2613#c2 Please review! Description: [XY]-core-extent and general_alignment (issue 2613) This adds a versatile method for specifying

Re: [XY]-core-extent and general_alignment (issue 2613) (issue 6308093)

Hi, After rereading the code i see that you are totally right! I don't know why i wanted to use dim_cache so much. It's scrapped now. Joe, thanks to your suggestion it is now possible to read extent from any property, including user-defined ones! many thanks, Janek

Re: Treat accidentals parentheses as cautionary (issue 6310065)

So until now cautionary accidentals *were* supported - the problem was just that the software that exported mxls didn't mark them appropriately? I.e. they had parentheses around them, but didn't have appropriate property set? That's an interesting example of how WYSIWYG sucks. LGTM

Re: Documentation of Kievan notation (issue 6303095)

pushed as a10311ff02578de9f979dc6ad83ba9535f8e4e4c. Aleksandr, please close this Rietveld issue. thanks! http://codereview.appspot.com/6303095/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

web: Linux = GNU/Linux. English only. (issue 6374060)

Reviewers: , Message: Please review. I don't feel like changing the names of download files, they seem hard-coded in the build/release system :/ Also, i didn't touch translations (btw, is there a complete list of Translation Meisters somewhere? didn't find in CG...). Finally, there are loads

Re: parenthesizeStencil and bracketifyStencil (issue 6397043)

Hi, this is really cool! A few general remarks: - is there a command to turn it off? - there already is a command \parenthesize. Your function seems to be smarter (at least in some cases); would it be to combine them? Having two similar functions is confusing. - i get a segmentation fault

CG: clarify staging branch policy (issue 6425045)

LGTM http://codereview.appspot.com/6425045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

  1   2   3   4   5   >