Re: Issue 5712: Split context_specification syntax constructor (issue 565560043 by nine.fierce.ball...@gmail.com)

LGTM https://codereview.appspot.com/565560043/

Re: lily: fix some type conversion warnings (issue 557190043 by hanw...@gmail.com)

> I don't like this methodology, +1 > I prefer what Dan does right now (btw thanks for > working on this!): Pick a warning, investigate > the issue and fix it correctly. I currently add `CXXFLAGS="-Wno-sign-conversion"` while calling make; this reduces the amount of warnings with clang to a lev

Re: Doc: Correct and extend infos about LilyDev setup (issue 561360043 by michael.kaepp...@googlemail.com)

Next round of nits :-) https://codereview.appspot.com/561360043/diff/575590043/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (left): https://codereview.appspot.com/561360043/diff/575590043/Documentation/contributor/quick-start.itexi#oldcode103 Docum

Re: Doc: Correct and extend infos about LilyDev setup (issue 561360043 by michael.kaepp...@googlemail.com)

> > Documentation/contributor/quick-start.itexi:46: > > create it from the sources located in the > > @code{/mkosi} subdirectory > > s/@code/@file/. > > Slightly puzzled about this one. You suggested > '@code' in your first review, didn't you? Yep. A mistake, sorry. '@file' is the right one (or

Re: Doc: Correct and extend infos about LilyDev setup (issue 561360043 by michael.kaepp...@googlemail.com)

And hopefully some final nits. Thanks for your patience! https://codereview.appspot.com/561360043/diff/565550050/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (right): https://codereview.appspot.com/561360043/diff/565550050/Documentation/contributo

Grow heap aggressively during music interpretation (issue 561390043 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/561390043/diff/563450046/lily/score-engraver.cc File lily/score-engraver.cc (right): https://codereview.appspot.com/561390043/diff/563450046/lily/score-engraver.cc#newcode200 lily/score-engraver.cc:200: // This double the heap. TODO: don't do this if we get cl

Make Pitch::to_string() more robust (issue 581580043 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/581580043/

Document 2 functions in markup-macros.scm (issue 581570043 by hanw...@gmail.com)

Some nits. https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm File scm/markup-macros.scm (right): https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm#newcode419 scm/markup-macros.scm:419: "Lookup procedure in the current module, or return #f"

Re: Add a tentative .clang-format for LilyPond. (issue 561340043 by hanw...@gmail.com)

> If Werner likes it, I'm fine with it. I do like it, and it is completely non-intrusive since it gets used locally only for those people who set up a proper git hook (or call `clang-format` manually). https://codereview.appspot.com/561340043/

Issue 5720: Fix C++11 option (issue 579270051 by truer...@gmail.com)

Mhmm, wouldn't it be better to simply define `M_PI` if it is not defined? GNU options might not be available with other compilers... https://codereview.appspot.com/579270051/

Issue 2173: Add Unicode filename support for Windows 10 1903+ (issue 575600044 by truer...@gmail.com)

Very nice, thanks! LGTM https://codereview.appspot.com/575600044/

Re: Issue 5720: Fix C++11 option (issue 579270051 by truer...@gmail.com)

> In `-std=c++11`, most POSIX functions/definitions cannot > be used. > Also `putenv ()` and `chroot ()` cannot be used. What about using AC_USE_SYSTEM_EXTENSIONS instead (in `configure.in`) to activate many POSIX functionality? https://codereview.appspot.com/579270051/

Re: lilypond-book: Remove custom package loading (issue 553490051 by jonas.hahnf...@gmail.com)

LGTM https://codereview.appspot.com/553490051/

Re: Issue 5723: Pedal_type_info maintenance (issue 557270049 by nine.fierce.ball...@gmail.com)

LGTM https://codereview.appspot.com/557270049/

Re: Document 2 functions in markup-macros.scm (issue 581570043 by hanw...@gmail.com)

uot;Lookup procedure in the current module, or return > #f" > On 2020/02/01 07:04:11, lemzwerg wrote: > > s/Lookup/Look up/ > > Done. > > https://codereview.appspot.com/581570043/diff/563450043/scm/markup-macros.scm#newcode427 > scm/markup-macros.scm:427: "Retur

Re: Document 2 functions in markup-macros.scm (issue 581570043 by hanw...@gmail.com)

> you need to read the comment at the top of the file too.. Well, ... > I think this function should not have been pulbic, > and suspect it is only so some of the macros can work. ... even a non-public function should have an understandable doc string, so thanks for the fix! https://codereview.

Re: Issue 5720: Fix C++11 option (issue 579270051 by truer...@gmail.com)

LGTM now, thanks! https://codereview.appspot.com/579270051/

Some cleanups for Python code (issue 551430044 by jonas.hahnf...@gmail.com)

LGTM https://codereview.appspot.com/551430044/

Re: Document 2 functions in markup-macros.scm (issue 581570043 by hanw...@gmail.com)

On 2020/02/02 15:17:04, hanwenn wrote: > *say Yep, LGTM. https://codereview.appspot.com/581570043/

Issue 5733: Fix various type-conversion warnings (issue 559450053 by nine.fierce.ball...@gmail.com)

LGTM https://codereview.appspot.com/559450053/diff/547570044/lily/accidental-placement.cc File lily/accidental-placement.cc (right): https://codereview.appspot.com/559450053/diff/547570044/lily/accidental-placement.cc#newcode62 lily/accidental-placement.cc:62: scm_from_long (stagger ? context_h

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

A nit. https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/579290043/Documentation/notation/input.itely#newcode464 Documentation/notation/input.itely:464: escaped

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

An important nit to check... Besides this, LGTM, thanks! https://codereview.appspot.com/579280043/diff/567170044/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/567170044/Documentation/notation/input.itely#newcode

<    3   4   5   6   7   8