Work on 1890: Turn some int vars/funcs into vsize to prevent conversion warnings on 64-bit systems (issue 5039043)

2011-09-17 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/5039043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Unifies mensural ligatures with blot-diameter. (issue 5030053)

2011-09-17 Thread pkx166h
Passes make and reg tests - I get differences but they look ok see: http://code.google.com/p/lilypond/issues/detail?id=1898#c1 http://codereview.appspot.com/5030053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: New alist to replace special characters. (issue 4553056)

2011-09-16 Thread pkx166h
Hello, passes make but fails make check please see http://code.google.com/p/lilypond/issues/detail?id=1891#c1 James http://codereview.appspot.com/4553056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: New alist to replace special characters. (issue 4553056)

2011-09-16 Thread pkx166h
On 2011/09/16 21:31:25, J_lowe wrote: Hello, passes make but fails make check Sorry ignore this, I just realised I made a mistake in my make check. I'll redo now. James http://codereview.appspot.com/4553056/ ___ lilypond-devel mailing list

Re: New alist to replace special characters. (issue 4553056)

2011-09-16 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4553056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-16 Thread pkx166h
Passes make and reg tests. I did get the 'NOT A BUG' test show up again, I see that I had had this before...so this looks ok. See: http://code.google.com/p/lilypond/issues/detail?id=1854#c1 James http://codereview.appspot.com/4387046/ ___

Re: Isue 1868: Loglevels in our python scripts (lilypond-book, musicxml2ly, convert-ly) (issue 4908041)

2011-09-16 Thread pkx166h
I was able to do a full make doc with no errors. James http://codereview.appspot.com/4908041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Introduce a maximum depth for markup evaluation (issue 5032041)

2011-09-15 Thread pkx166h
passes make and reg tests (with other patch applied first and this one on top) http://codereview.appspot.com/5032041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 380: Auto-detect all cyclic references in markups (issue 5027042)

2011-09-15 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/5027042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement optional music function arguments (issue 5023044)

2011-09-15 Thread pkx166h
Fails make --snip-- Backtrace: In unknown file: ?: 0* [primitive-load-path documentation-generate.scm] In /home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/documentation-generate.scm: 72: 1* [display ... 73: 2* [identifiers-doc-string] In

Re: New short and long lyric ties. (issue 4912041)

2011-09-15 Thread pkx166h
Passes make, a full make doc and reg tests. Output of NR example attached here: http://code.google.com/p/lilypond/issues/detail?id=1822#c5 James http://codereview.appspot.com/4912041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Isue 1868: Loglevels in our python scripts (lilypond-book, musicxml2ly, convert-ly) (issue 4908041)

2011-09-15 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4908041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves some parmesan noteheads. (issue 4639065)

2011-09-15 Thread pkx166h
Passes make and new reg test differences (look ok) attached here http://code.google.com/p/lilypond/issues/detail?id=1839#c17 http://codereview.appspot.com/4639065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-15 Thread pkx166h
On 2011/09/15 21:41:27, Neil Puttock wrote: For some reason, your patch fails `make check' on my system. Neil, I've just applied this patch - after seeing your note - to the latest 'git pull -r' and 'make ; make check' work fine on my system if that helps? James

Re: Doc: adding doc strings for \...DashPattern and \harmonicBy... (1887) (issue 5019042)

2011-09-14 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/5019042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-14 Thread pkx166h
passes make and reg tests - there are three reg tests that show up but nothing significant. See http://code.google.com/p/lilypond/issues/detail?id=1883#c1 http://codereview.appspot.com/4962072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Improves some parmesan noteheads. (issue 4639065)

2011-09-13 Thread pkx166h
Thought I'd commented on this one but see http://code.google.com/p/lilypond/issues/detail?id=1839#c13 There are the reg test differences. http://codereview.appspot.com/4639065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Improves some parmesan noteheads. (issue 4639065)

2011-09-13 Thread pkx166h
Thought I'd commented on this one but see http://code.google.com/p/lilypond/issues/detail?id=1839#c13 There are the reg test differences. http://codereview.appspot.com/4639065/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: include lines in breve X-extent (issue 1814) (issue 4986042)

2011-09-12 Thread pkx166h
Passes make and I get a few reg test differences. See http://code.google.com/p/lilypond/issues/detail?id=1814#c10 for attachments, http://codereview.appspot.com/4986042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)

2011-09-11 Thread pkx166h
Passes make. There is one reg test that shows up that I don't understand the significance of but it looks ok. Attached in http://code.google.com/p/lilypond/issues/detail?id=1780#c14 http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

2011-09-11 Thread pkx166h
Passes make test but fails reg test check. See: http://code.google.com/p/lilypond/issues/detail?id=1572#c7 for more information James http://codereview.appspot.com/4981052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-11 Thread pkx166h
New patch uploaded with corrected snippet edit http://codereview.appspot.com/4837050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)

2011-09-10 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4969069/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-10 Thread pkx166h
Passes make but fails reg test check: see http://code.google.com/p/lilypond/issues/detail?id=380#c15 for details (keeps the noise down here) James http://codereview.appspot.com/4951073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (issue 4991049)

2011-09-10 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4991049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

MusicXML: fix case when some elements have a staff number, while others don't (issue 4991044)

2011-09-10 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4991044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-10 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-10 Thread pkx166h
patch 2 passes make and reg tests http://codereview.appspot.com/4951073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaned up style (issue 4951062)

2011-09-10 Thread pkx166h
I created https://code.google.com/p/lilypond/issues/detail?id=1873 and called it 'Added glyphs for Kievan Notation' so when this issue is changed can we use the same title? http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

2011-09-10 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4996044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-10 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-09 Thread pkx166h
Added http://code.google.com/p/lilypond/issues/detail?id=1878 http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaned up style (issue 4951062)

2011-09-08 Thread pkx166h
Added to Tracker: https://code.google.com/p/lilypond/issues/detail?id=1873 http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Several fixes for annotate-spacing. (issue 4950071)

2011-09-08 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4950071/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 814: Turn on warning-as-error in the regtests (issue 4890045)

2011-09-05 Thread pkx166h
http://code.google.com/p/lilypond/issues/detail?id=814#c10 Labels: -Priority-Low Needs-policy (just for information on this issue) http://codereview.appspot.com/4890045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Flush all ports after each file, flush stdout after displaying all options (issue 4956062)

2011-09-05 Thread pkx166h
Passes make and reg tests. http://codereview.appspot.com/4956062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Loglevels in our python scripts (lilypond-book, musicxml2ly, convert-ly) (issue 4908041)

2011-09-05 Thread pkx166h
Patch no longer applies to current tree http://codereview.appspot.com/4908041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur (issue 4904049)

2011-09-03 Thread pkx166h
passes Make and reg tests http://codereview.appspot.com/4904049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fixed space after time- key-signatures (issue 4964059)

2011-09-02 Thread pkx166h
passes Make but I get a lot of (probably expected) reg test differences. Attached the most significant shifts here http://code.google.com/p/lilypond/issues/detail?id=1856#c9 (as a zip containing about 30 pngs) james http://codereview.appspot.com/4964059/

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-09-02 Thread pkx166h
new patch passes make and reg tests http://codereview.appspot.com/4917046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Prevents nested tuplets from colliding. (issue 4808082)

2011-09-02 Thread pkx166h
passes make, some trivial reg test differences but one is very different and I have attached it here http://code.google.com/p/lilypond/issues/detail?id=1855#c3 for comparison. Otherwise looks ok. James http://codereview.appspot.com/4808082/ ___

Re: Fix issue 11 -- beamlet points in wrong direction on tuplet (issue 4941041)

2011-08-30 Thread pkx166h
Passes make and reg test shows one change see attached on http://code.google.com/p/lilypond/issues/detail?id=11#c14 probably expected. http://codereview.appspot.com/4941041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Fix 1825: Convert-ly shall also print output if no replacement was done (issue 4961059)

2011-08-30 Thread pkx166h
sses make and reg tests and I ran a make doc too (seemed relevant) and it failed --snip-- tal error: failed files: 78/lily-63af708e.ly fatal error: Children (3) exited with errors. command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -dbackend=eps --formats=ps,png,pdf -djob-count=7

Re: Add some polyphonically directed grobs (issue 4387046)

2011-08-30 Thread pkx166h
Passes make but get two reg tests show up that look ok but that need a second opinion. Attached on http://code.google.com/p/lilypond/issues/detail?id=1854#c1 http://codereview.appspot.com/4387046/ ___ lilypond-devel mailing list

Re: Prevents nested tuplets from colliding. (issue 4808082)

2011-08-30 Thread pkx166h
Mike, passes make but during reg test check i get --snip-- Failed files: (6c/lily-5110fb03.ly) fatal error: Children (3) exited with errors. command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I

Re: Add some polyphonically directed grobs (issue 4387046)

2011-08-28 Thread pkx166h
Patch fails on tree as of 28 August. patching file scm/music-functions.scm Hunk #2 FAILED at 415. 1 out of 2 hunks FAILED -- saving rejects to file scm/music-functions.scm.rej jlowe@jlowe-lilybuntu2:~/lilypond-git$ http://codereview.appspot.com/4387046/

Re: Make accidental styles available as context mods. (issue 4819064)

2011-08-28 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4819064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes figuredBassCenterContinuations. (issue 4868046)

2011-08-28 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4868046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Align pedal brackets to main note-column; issue 723 (issue 4966042)

2011-08-28 Thread pkx166h
Passes make and reg tests - one difference in reg test that is expected and attached for completeness here: http://code.google.com/p/lilypond/issues/detail?id=723#c4 http://codereview.appspot.com/4966042/ ___ lilypond-devel mailing list

Re: Lets auto numbering of footnotes kick in from commands alone. (issue 4837047)

2011-08-28 Thread pkx166h
passes make and reg tests. http://codereview.appspot.com/4837047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses Y-offset for stem tremolos instead of translated stencil. (issue 4867043)

2011-08-28 Thread pkx166h
Mike I get a failed patch apply here on the current tre (28 Aug) --snip-- patching file lily/beam.cc Hunk #1 succeeded at 1865 (offset 72 lines). patching file lily/include/beam.hh Hunk #1 succeeded at 69 with fuzz 2. patching file lily/include/stem-tremolo.hh patching file lily/include/stem.hh

Re: modifying default behaviour of tremolo slashes (issue 4636081)

2011-08-28 Thread pkx166h
Still passes make and reg tests http://codereview.appspot.com/4636081/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1529: hashed snippet filename changes should not count as log differences (issue 4893044)

2011-08-27 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4893044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

New partcombineUp and partcombineDown functions (issue 4514042)

2011-08-27 Thread pkx166h
When I try to patch to current tree (27 Aug) I get --snip-- patching file lily/part-combine-iterator.cc Hunk #2 succeeded at 138 with fuzz 1. Hunk #4 FAILED at 390. Hunk #5 FAILED at 412. 2 out of 5 hunks FAILED -- saving rejects to file lily/part-combine-iterator.cc.rej patching file

Re: include lines in breve X-extent (issue 1814) (issue 4931043)

2011-08-27 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4931043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: FiguredBass: Rewrite of the engraver to fix vertical position (issue 224052)

2011-08-27 Thread pkx166h
patching today's tree (27 Aug) I get --snip-- jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 ../Desktop/issue224052_2001.diff patching file input/regression/figured-bass-continuation-center.ly patching file input/regression/figured-bass-figureorder-position.ly patching file

Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

2011-08-27 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4923048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond-book: Get rid of lilyquote option, use quote instead (issue 4921050)

2011-08-27 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4921050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-08-27 Thread pkx166h
ok, this passes make but I get a lot of reg tests show up but I cannot see any diffs at all (i.e no 'green' shadows that indicate the changes). Either it's unbelievably subtle or something else is triggering the reg tests to show up. They are to big to post them all here but he diffs that show up

Re: Creates pure closures (issue 4894052)

2011-08-27 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4894052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes variable names in include/beam-scoring-problem.hh and beam-quanting.cc (issue 4961041)

2011-08-27 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4961041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Deprecate \fermataMarkup for full-bar rests. (issue 4672059)

2011-08-24 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4672059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-24 Thread pkx166h
On 2011/08/08 22:09:09, Trevor Daniels wrote: LGTM Although I'm not sure about editing the other language files. Best wait for Francisco to comment. Francisco, can you tell me if this patch is ok to go as I have touched some of the translated docs to remove this snippet. Thanks

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-24 Thread pkx166h
On 2011/08/08 22:09:09, Trevor Daniels wrote: LGTM Although I'm not sure about editing the other language files. Best wait for Francisco to comment. Francisco, can you tell me if this patch is ok to go as I have touched some of the translated docs to remove this snippet. Thank

Re: Does better polynomial calculations for avoid objects. (issue4860042)

2011-08-10 Thread pkx166h
Passes Make and there are some reg test differences - see http://code.google.com/p/lilypond/issues/detail?id=1328#c2 http://codereview.appspot.com/4860042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4860043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Get rid of some compiler warnings (issue4854049)

2011-08-10 Thread pkx166h
Passes make but there are some reg test differences see http://code.google.com/p/lilypond/issues/detail?id=804#c6 http://codereview.appspot.com/4854049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)

2011-08-10 Thread pkx166h
minor stuff. http://codereview.appspot.com/1659041/diff/16001/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): http://codereview.appspot.com/1659041/diff/16001/Documentation/usage/lilypond-book.itely#newcode225

Re: Doc: NR Warning added to para for cueduring (issue4850051)

2011-08-10 Thread pkx166h
Reviewers: Trevor Daniels, Message: Second draft, James http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely#newcode1304

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-08 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-08 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4808074/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Prevents nested tuplets from colliding. (issue4808082)

2011-08-08 Thread pkx166h
Passes make and reg test diff looks ok see http://code.google.com/p/lilypond/issues/detail?id=509#c4 for attached png http://codereview.appspot.com/4808082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: Added \compoundMeter function to NR (issue4837050)

2011-08-08 Thread pkx166h
Draft 5 - removed all translation docs with this snippet in it too (for when it is removed from LSR). have at it. http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right):

Re: Doc: Added \compoundMeter function to NR (issue4837050)

2011-08-07 Thread pkx166h
On 2011/08/05 10:07:46, Janek Warchol wrote: 2011/8/4 reinhold.kainho...@gmail.com: I would definitely mention here that the automatic beaming and the beam subdivisions are automatically derived from nbsp;the \compound meter. Are the subdivisions really used? ... I have removed the

Re: Doc: Added \compoundMeter function to NR (issue4837050)

2011-08-07 Thread pkx166h
New Draft. Thanks James http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1554

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-07 Thread pkx166h
a 'while you're there' nitpick. http://codereview.appspot.com/4808074/diff/18/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): http://codereview.appspot.com/4808074/diff/18/Documentation/notation/vocal.itely#newcode612 Documentation/notation/vocal.itely:612:

Re: Doc: Added \compoundMeter function to NR (issue4837050)

2011-08-07 Thread pkx166h
New Draft. Before I push this (and as Neil has just done an LSR update) do I still need to run makelsr.py before applying this patch once it has been approved? I have removed one snippet from both dirs (snippets/new and snippets). I'll get someone to remove the snippet from the LSR too.

Re: Fixes issue 40. (issue4801083)

2011-08-06 Thread pkx166h
Pass make and reg tests http://codereview.appspot.com/4801083/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-08-06 Thread pkx166h
make fails. --snip-- -DHAVE_CONFIG_H -DNDEBUG -I/home/jlowe/lilypond-git/lily/include -I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out -I../flower/include -I/home/jlowe/lilypond-git/lily/out -O2 -finline-functions -g -pipe -pthread -I/usr/include/freetype2 -pthread

Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

2011-08-06 Thread pkx166h
Passes make and one reg test difference http://code.google.com/p/lilypond/issues/detail?id=163#c23 see attached there. http://codereview.appspot.com/4810072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

lily/auto-beam-engraver: keep a Context_handle to starting Staff (issue4830064)

2011-08-06 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4830064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue4837050)

2011-08-04 Thread pkx166h
Second Draft. Hopefully I've covered everything without being too verbose or talking through the code. I also found some old 'scheme' code in the glossary and so updated that with the new \compoundMeter function instead also removed another reference to the snippet found in world.itely.

Re: Prevents lilypond from segfaulting with add-footer = ##f (issue4832046)

2011-08-02 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4832046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Added \compoundMeter function to NR (issue4837050)

2011-08-02 Thread pkx166h
Reviewers: , Message: Patch ready for review. But also see http://code.google.com/p/lilypond/issues/detail?id=1776#c6 as there are still some points I am not clear on on this function that may need more doc additions. Description: Doc: Added \compoundMeter function to NR Tracker 1776.

Re: Limits slurs to a maximum height. (issue4843043)

2011-08-02 Thread pkx166h
Hello, makes ok but during eg check I get: --snip-- reading input/regression/out-test/tablature-tie-spanner-1.signature Traceback (most recent call last): File /home/jlowe/lilypond-git/build/scripts/build/out/output-distance, line 1261, in module main () File

Re: Doc: Usage - new option for lilypond-book (issue4806050)

2011-08-01 Thread pkx166h
Reviewers: Graham Percival, Message: Pushed as Commit 23cdda9506931d5b9a1e75ee8be8be8b74f9084a7c0 James Description: Doc: Usage - new option for lilypond-book Documenting new feature made in Commit 23cdda9506931d5b9a1e75ee8be8be8b74f9084a7c0 Also for Tracker issue 1730 adding information

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-08-01 Thread pkx166h
Passes Make and reg tests http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Close loopholes in note-collision logic (issue4293054)

2011-07-31 Thread pkx166h
Passes Make and reg tests http://code.google.com/p/lilypond/issues/detail?id=1792#c1 http://codereview.appspot.com/4293054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue4553056)

2011-07-31 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4553056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

2011-07-31 Thread pkx166h
Passes Make and there is a reg test difference which looks ok. I created a tracker http://code.google.com/p/lilypond/issues/detail?id=1794 so people can see this but also because this has been going on for a while and the tracker will at least keep this on people's radars.

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

2011-07-31 Thread pkx166h
On 2011/07/31 20:10:30, J_lowe wrote: Passes Make and there is a reg test difference which looks ok. I created a tracker http://code.google.com/p/lilypond/issues/detail?id=1794 so people can see this but also because this has been going on for a while and the tracker will at least keep

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread pkx166h
On 2011/07/30 16:15:39, c_sorensen_byu.edu wrote: I think that the stop/start staves is currently exactly what it should do. It stops the staff at a location, and starts the staff at the same location. It reflects the commands that have been issued. If the staff is continuous, there is

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread pkx166h
passes make and reg tests look fine. http://codereview.appspot.com/4809057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-30 Thread pkx166h
Doesn't pass a make check. I get an error on regression/fret-diagrams-string-thickness.ly log file shows: Renaming input to: `/home/jlowe/lilypond-git/input/regression/fret-diagrams-string-thickness.ly' Interpreting music... ERROR: In procedure ly:pitch-transpose: ERROR: Wrong type argument

Re: New engraver for braces (issue4807053)

2011-07-30 Thread pkx166h
Passes make and reg tests all ok. No errors reported. http://codereview.appspot.com/4807053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG (issue4822055)

2011-07-30 Thread pkx166h
Passes make and reg test. http://codereview.appspot.com/4822055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: modifying default behaviour of tremolo slashes (issue4636081)

2011-07-30 Thread pkx166h
make passes and no reg tests differences http://codereview.appspot.com/4636081/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-30 Thread pkx166h
On 2011/07/29 11:35:55, J_lowe wrote: Mike's new addition to footnotes doesn't affect this patch so I would like to get this pushed and when Mike comes back with more explanation for his newer patch which will then take more reviewing I can update the documentation with the additions than

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-29 Thread pkx166h
Mike's new addition to footnotes doesn't affect this patch so I would like to get this pushed and when Mike comes back with more explanation for his newer patch which will then take more reviewing I can update the documentation with the additions than hold this back.

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-28 Thread pkx166h
note from Mike --snip-- I just pushed a patch for automatic footnotes. Everything you need to know about them exists in the two new regtests (233aad0ba9781e43424c4e77a859e42b660210e6). The most important thing to note is that, if people want to use non-automatic footnotes, they must now add

<    4   5   6   7   8   9   10   11   >