Re: Add regtest for issue 5181 (issue 327470043 by d...@gnu.org)

2017-09-25 Thread thomasmorley65
On 2017/09/25 21:53:06, dak wrote: On 2017/09/25 21:28:50, thomasmorley651 wrote: > Very nice, i.e LGTM > > Not sure whether this should be reflected by a reg-test, but currently there is > no case in it triggering the warning like: > > warns = { > \override NoteHead.color = #red > c'1 d'

Re: Add regtest for issue 5181 (issue 327470043 by d...@gnu.org)

2017-09-25 Thread dak
Reviewers: carl.d.sorensen_gmail.com, thomasmorley651, Message: On 2017/09/25 21:28:50, thomasmorley651 wrote: Very nice, i.e LGTM Not sure whether this should be reflected by a reg-test, but currently there is no case in it triggering the warning like: warns = { \override

Re: Add regtest for issue 5181 (issue 327470043 by d...@gnu.org)

2017-09-25 Thread thomasmorley65
Very nice, i.e LGTM Not sure whether this should be reflected by a reg-test, but currently there is no case in it triggering the warning like: warns = { \override NoteHead.color = #red c'1 d' \revert NoteHead.color } { \warns -1 e' } And there are cases which will probably never work,

Add regtest for issue 5181 (issue 327470043 by d...@gnu.org)

2017-09-24 Thread Carl . D . Sorensen
LGTM https://codereview.appspot.com/327470043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel