Issue 1255 is: "#1255 Extract hyphen dimensions and/or hyphen glyph
from the
font "
Your patch does not extract hyphen dimensions or the hyphen glyph from
the font.
It might get used for using the hyphen glyph (provided that you know
its
font-dependent character code) as a hyphen, so
https://codereview.appspot.com/325470043/diff/20001/lily/lyric-hyphen.cc
File lily/lyric-hyphen.cc (right):
https://codereview.appspot.com/325470043/diff/20001/lily/lyric-hyphen.cc#newcode126
lily/lyric-hyphen.cc:126: Stencil dash_mol (Lookup::round_filled_box (b,
0.8 * lt));
On 2017/09/17
On 2017/09/17 10:02:41, knupero wrote:
On 2017/09/16 19:53:57, dak wrote:
> Indepent of those: I don't actually see this addressing issue 1255,
so maybe
> create a new issue in the Sourceforge issue tracker for it and
attach this
> Rietveld issue? It seems at best loosely related to
https://codereview.appspot.com/325470043/diff/20001/lily/lyric-hyphen.cc
File lily/lyric-hyphen.cc (right):
https://codereview.appspot.com/325470043/diff/20001/lily/lyric-hyphen.cc#newcode125
lily/lyric-hyphen.cc:125: Box b (Interval (0, dash_length), Interval (h,
h + th));
On 2017/09/16
On 2017/09/16 19:53:57, dak wrote:
Indepent of those: I don't actually see this addressing issue 1255, so
maybe
create a new issue in the Sourceforge issue tracker for it and attach
this
Rietveld issue? It seems at best loosely related to issue #1255 but
seems to be
desirable
Rats, forgot to publish my code comments.
Indepent of those: I don't actually see this addressing issue 1255, so
maybe create a new issue in the Sourceforge issue tracker for it and
attach this Rietveld issue? It seems at best loosely related to issue
#1255 but seems to be desirable
https://codereview.appspot.com/325470043/diff/1/lily/lyric-hyphen.cc
File lily/lyric-hyphen.cc (right):
https://codereview.appspot.com/325470043/diff/1/lily/lyric-hyphen.cc#newcode55
lily/lyric-hyphen.cc:55: bool use_markup = to_boolean (me->get_property
("use-markup"));
On 2017/09/14 09:34:03,
https://codereview.appspot.com/325470043/diff/1/lily/lyric-hyphen.cc
File lily/lyric-hyphen.cc (right):
https://codereview.appspot.com/325470043/diff/1/lily/lyric-hyphen.cc#newcode55
lily/lyric-hyphen.cc:55: bool use_markup = to_boolean (me->get_property
("use-markup"));
That property seems
