Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-11 Thread pkx166h
One thing I think we need is an entry in the changes.tely for this new feature. Also now that you have tracker access (and because I cannot reassign this Rietveld issue to someone), could you Etienne create a new Rietveld issue for the tracker (which is now assigned to you) when you make the

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-04 Thread beauleetienne0
Add '-dcrop' option to ps and svg backends This change allows the output of scores in the format provided by the '-dpreview' option but including all systems, not just the first. This would allow for easier SVG use in HTML, without the need for cropping snippets. Further, SVG is an HTML

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-03 Thread beauleetienne0
In PS2, an implementation of the '-dcrop' argument was added to the 'ps' backend. My implementation has also been revamped to *work* and be more elegant. Letting James upload the patchset. https://codereview.appspot.com/326960043/diff/1/Documentation/usage/running.itely File

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-01 Thread Étienne Beaulé
Hit send too soon... With the fix, there's still the run-time error: /home/ubuntu/lilypond/build/out/share/lilypond/current/scm/backend-library.scm:245:18: In procedure ly:paper-book-systems in expression (ly:paper-book-systems book):

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-01 Thread Étienne Beaulé
Now that solves half of the issue. The other half is with the width, as my patch would (should) also adjust the width to fit the music, leaving no whitespace on any side. This feature is basically only available when using \includes " lilypond-book-preamble.ly" of which only works with the eps

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-01 Thread Paul
On 07/27/2017 03:21 AM, pkx1...@gmail.com wrote: This is a first attempt to merge the dump-page and dump-preview methods so that there is an option for cropping pages that are not just previews. I wonder... is the desired functionality already provided by one-page-breaking and/or

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-01 Thread Carl . D . Sorensen
Oh, now I read the first message and see that the code doesn't work. My first attempt at getting the code to work would be to change "stensil" to "stencil" and see if that fixed things. https://codereview.appspot.com/326960043/ ___ lilypond-devel

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-01 Thread Carl . D . Sorensen
I have listed some specific changes that must be made (move to the proper alphabetical order) and raised questions about how the code works with an apparently misspelled argument. I believe both of those need to be fixed before pushing the patch. I would also like to see crop apply to at least

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-01 Thread pkx166h
I am going to leave this on review for this countdown only that the submitter (not me) had doubts about this patch and was looking for any guidance (it does pass all the tests BTW). https://codereview.appspot.com/326960043/ ___ lilypond-devel mailing

Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-07-27 Thread pkx166h
Reviewers: , Message: Please note that *i* did the commit message - trying to interpret what Etienne is trying to achieve, so if this is completely non-sensical, blame me not him :) Etienne knows this is a first 'draft' and sent me an email to say so, any guidance would be appreciated: ---