Re: Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-20 Thread dak
http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc File lily/engraver-scheme.cc (right): http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc#newcode42 lily/engraver-scheme.cc:42: programming_error (cannot create grob); This gives no helpful indication of

Re: Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-02 Thread plroskin
There are only two calls to scm_throw in Lilypond, and I could not find out whether it should be added to engraver.cc or engraver-scheme.cc. I added it to the former so that other callers to Engraver::internal_make_grob could benefit. I could not figure out how to catch an exception. Without

Re: Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-02 Thread Han-Wen Nienhuys
On Fri, Mar 2, 2012 at 10:22 PM, plros...@gmail.com wrote: There are only two calls to scm_throw in Lilypond, and I could not find out whether it should be added to engraver.cc or engraver-scheme.cc.  I added it to the former so that other callers to Engraver::internal_make_grob could

Re: Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-02 Thread plroskin
I'm not getting any interesting information: ... [/usr/local/share/lilypond/2.15.32/ly/context-mods-init.ly] [/usr/local/share/lilypond/2.15.32/ly/engraver-init.ly]] [bad.ly] Interpreting music... [/usr/local/share/lilypond/2.15.32/fonts/otf/emmentaler-20.otf] fatal error: failed files:

Re: Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-02 Thread dak
On 2012/03/03 04:38:36, Pavel Roskin wrote: I'm not getting any interesting information: ... [/usr/local/share/lilypond/2.15.32/ly/context-mods-init.ly] [/usr/local/share/lilypond/2.15.32/ly/engraver-init.ly]] [bad.ly] Interpreting music...

Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-01 Thread plroskin
Reviewers: , Message: I've seen it many times that Lilypond would crash during my experiments with Scheme code. This time I decided to track it down. It's my first ever fix to the C++ code in Lilypond, so please check my coding style. Description: Fix crash when unknown grob name is passed to

Re: Fix crash when unknown grob name is passed to ly:engraver-make-grob (issue 5715053)

2012-03-01 Thread dak
On 2012/03/01 23:02:57, Pavel Roskin wrote: I've seen it many times that Lilypond would crash during my experiments with Scheme code. This time I decided to track it down. It's my first ever fix to the C++ code in Lilypond, so please check my coding style. How is that a fix? You return