Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-24 Thread sphema72
Dear Sir/Madam . I want to know something, how to get nulled to someone's business system and do whatever I like to do. https://codereview.appspot.com/571180043/

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-24 Thread sphema72
how to wipe my dept & how to put money on y bank account ,pay pall . useing development tool . because What I have lean while im seching things ,is the is no thing such as money .It just a number123... we work hard to get that number https://codereview.appspot.com/571180043/

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-21 Thread david . nalesnik
Reviewers: lemzwerg, carl.d.sorensen_gmail.com, Dan Eble, thomasmorley651, t.daniels_treda.co.uk, kieren_kierenmacmillan.info, c_sorensen, checkma, Message: Name has been changed to MeasureSpanner, and all references (including file names) have been adjusted. Thanks for the reviews!

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-18 Thread James Lowe
Hello, On Mon, 18 Nov 2019 12:56:54 +1100, Andrew Bernard wrote: > MeasureAttachedSpanner is better. I often use span bars with no > barlines. It's the measure I am concerned about. > > And don't forget that we Aussies and Brits call a measure a bar! Yes, there are many different terms for

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-17 Thread Andrew Bernard
MeasureAttachedSpanner is better. I often use span bars with no barlines. It's the measure I am concerned about. And don't forget that we Aussies and Brits call a measure a bar! Andrew On Sat, 16 Nov 2019 at 06:21, wrote: > I think the name should be changed from MeasureAttachedSpanner to >

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread checkma
Is it nestable? (Can you put one of these spanners inside of another?) --- Christopher Heckman https://codereview.appspot.com/571180043/

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread Carl Sorensen
On 11/16/19, 7:49 AM, "Kieren MacMillan" wrote: >> I'd vote for MeasureSpanner. > +1 +1 Kieren. MeasureSpanner works for me. Carl

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread thomasmorley65
Thanks for working on it !! Some other nits: https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc File lily/measure-attached-spanner.cc (right): https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode93

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread nine . fierce . ballads
I haven't reviewed the ly or scm. https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh File lily/include/measure-attached-spanner.hh (right): https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh#newcode4

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread Kieren MacMillan
>> I'd vote for MeasureSpanner. > +1 +1 Kieren.

Re[2]: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread Trevor
MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com) On 2019/11/16 14:27:25, Dan Eble wrote: On 2019/11/15 19:21:09, Carl wrote: > I think the name should be changed from MeasureAttachedSpanner to > BarAttachedSpanner. Calling it just MeasureSpanner would also address the sp

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread thomasmorley65
https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly File ly/spanners-init.ly (right): https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly#newcode25 ly/spanners-init.ly:25: "View side-by-side diff with in-line comments" is broken for this file.

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread thomasmorley65
On 2019/11/16 14:27:25, Dan Eble wrote: On 2019/11/15 19:21:09, Carl wrote: > I think the name should be changed from MeasureAttachedSpanner to > BarAttachedSpanner. Calling it just MeasureSpanner would also address the specific problem you raised. Is it more important for the name to

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-16 Thread nine . fierce . ballads
On 2019/11/15 19:21:09, Carl wrote: I think the name should be changed from MeasureAttachedSpanner to BarAttachedSpanner. Calling it just MeasureSpanner would also address the specific problem you raised. Is it more important for the name to state where it is attached or what it spans?

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-15 Thread Carl . D . Sorensen
I have not reviewed the code, but this looks like a worthwhile addition. Thanks for doing it! I think the name should be changed from MeasureAttachedSpanner to BarAttachedSpanner. A measure is the interval between bar lines. The spanner is attached to the bar line. While it requires some

Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-15 Thread lemzwerg--- via Discussions on LilyPond development
LGTM from reading the code without testing. Thanks! https://codereview.appspot.com/571180043/diff/565230043/input/regression/measure-spanner.ly File input/regression/measure-spanner.ly (right):