Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

I've marked the ticket as "needs work". Motivation has been lacking lately. I expect to return to this after some time (a week? a month?) but if someone else would like to take over this issue before then, I won't be offended. https://codereview.appspot.com/308890043/

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/12 22:04:52, dak wrote: I repeat: Can we get to some version of the code where the code paths supposed to be equivalent (is there agreement about that?) actually looks the same? I think the simplest options here are to (1) make the same changes in both code paths for

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 8/12/16 3:21 PM, "nine.fierce.ball...@gmail.com" wrote: >James put this issue back in "review" thinking that there might be more >than needs to be discussed, but my understanding is that none of the >reviewers has any significant concern about pushing this as

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/12 21:21:33, Dan Eble wrote: James put this issue back in "review" thinking that there might be more than needs to be discussed, but my understanding is that none of the reviewers has any significant concern about pushing this as it is. Is that correct? I repeat: Can we get

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

James put this issue back in "review" thinking that there might be more than needs to be discussed, but my understanding is that none of the reviewers has any significant concern about pushing this as it is. Is that correct? https://codereview.appspot.com/308890043/

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/10 23:05:23, c_sorensen wrote: When writing congregational hymns, dynamics are very seldom included. But I may wish to generate practice midi from my engraving (I regularly do it). It would be nice to be able to define my own default midi volume that would apply. This is a

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/10 23:05:23, c_sorensen wrote: On 8/10/16 4:17 PM, mailto:"nine.fierce.ball...@gmail.com; wrote: >David, do you have advice on the direction to take regarding the >comments on this thing in midi.scm? > > (define-public

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 8/10/16 4:17 PM, "nine.fierce.ball...@gmail.com" wrote: >David, do you have advice on the direction to take regarding the >comments on this thing in midi.scm? > > (define-public dynamic-default-volume 0.71) > >To me it seems unnecessary (the user

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

David, do you have advice on the direction to take regarding the comments on this thing in midi.scm? (define-public dynamic-default-volume 0.71) To me it seems unnecessary (the user should specify a dynamic if a specific dynamic is desired) and the wrong place for a default anyway. It

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

Sigh. Dan has suggested I might want to provide feedback here. Now I'm not really much into the Midi code to be honest, so this more or less boils down to consulting a gut feeling and/or general policy. The main thing this boils down to here is that Heikki feels that Dan changed one occurence

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/06 11:15:35, ht wrote: Do you mean the 'finish_queued_spans' function? Isn't it the case that 'this->depart_queue_.spans_' is empty when 'this->process_music' gets called the first time, so 'finish_queued_spans' would report a programming error if it actually got called (so

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc File lily/dynamic-performer.cc (right): https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc#newcode412 lily/dynamic-performer.cc:412: volume = equalize_volume (Audio_span_dynamic::DEFAULT_VOLUME); On

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/04 23:30:17, Dan Eble wrote: On 2016/08/04 21:23:12, ht wrote: > (define-public dynamic-default-volume 0.71) > > I wonder whether this (possibly obsolete, "git grep" doesn't show it being > currently referenced from anywhere, certainly not from Dynamic_performer) > definition

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/04 21:23:12, ht wrote: LGTM except for a small question (still) about the process_music logic. Also, I noticed the following definition in scm/midi.scm: ;; 90 == 90/127 == 0.71 is supposed to be the default value ;; urg: we should set this at start of track (define-public

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc File lily/dynamic-performer.cc (right): https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc#newcode412 lily/dynamic-performer.cc:412: volume = equalize_volume (Audio_span_dynamic::DEFAULT_VOLUME); On

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/04 21:30:58, Carl wrote: On 2016/08/04 21:23:12, ht wrote: > LGTM except for a small question (still) about the process_music logic. > > Also, I noticed the following definition in scm/midi.scm: > > ;; 90 == 90/127 == 0.71 is supposed to be the default value > ;; urg: we should set

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

On 2016/08/04 21:23:12, ht wrote: LGTM except for a small question (still) about the process_music logic. Also, I noticed the following definition in scm/midi.scm: ;; 90 == 90/127 == 0.71 is supposed to be the default value ;; urg: we should set this at start of track (define-public

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc File lily/dynamic-performer.cc (right): https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc#newcode412 lily/dynamic-performer.cc:412: volume = equalize_volume (Audio_span_dynamic::DEFAULT_VOLUME); I

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

LGTM except for a small question (still) about the process_music logic. Also, I noticed the following definition in scm/midi.scm: ;; 90 == 90/127 == 0.71 is supposed to be the default value ;; urg: we should set this at start of track (define-public dynamic-default-volume 0.71) I wonder

Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

Reviewers: ht, Description: Issue 4936: look up "mf" for default initial volume When the Dynamic_performer begins processing, if no dynamic is specified, act as if "mf" were specified. Changes in note velocity from 90 to 86 in many MIDI regression tests are expected. Please review this at