On 2017/08/01 12:53:25, Carl wrote:
After reviewing the slur code, I remove my objections to using
grob.line-thickness in this patch.
ok, so I'll go for patch set 3
https://codereview.appspot.com/326970043/
___
lilypond-devel mailing list
After reviewing the slur code, I remove my objections to using
grob.line-thickness in this patch.
https://codereview.appspot.com/326970043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I believe that line-thickness should not be changed for the grob; just
thickness. line-thickness should be the staff line-thickness, not
changed per grob, IMO.
https://codereview.appspot.com/326970043/diff/40001/lily/arpeggio.cc
File lily/arpeggio.cc (right):
I'm no expert, but LGTM.
https://codereview.appspot.com/326970043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc
File lily/arpeggio.cc (right):
https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc#newcode192
lily/arpeggio.cc:192: Real lt = robust_scm2double (me->get_property
("thickness"), 0.1);
On 2017/07/28 23:12:37, Dan Eble
https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc
File lily/arpeggio.cc (right):
https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc#newcode192
lily/arpeggio.cc:192: Real lt = robust_scm2double (me->get_property
("thickness"), 0.1);
1. The "thickness" property is
Reviewers: ,
Message:
Please review.
(It's my first patch changing operative c++-code on my own)
Description:
Let arpeggio-bracket/slur depend on grob-property thickness
Before thickness based on line-thickness from layout
Please review this at https://codereview.appspot.com/326970043/
