Re: RFC on MR 1368

2022-05-25 Thread Karlin High
On 5/25/2022 4:16 PM, David Kastrup wrote: I cannot do much more than express my gratitude that I see people willing to work on addressing one another's concerns and wish them success doing it without wasting unnecessary amounts of their energy. Same here. The font-structure issues have

Re: RFC on MR 1368

2022-05-25 Thread David Kastrup
Jean Abou Samra writes: > I agree that all commits should have a clearly explained and > duly justified rationale, because a review is a request > from the developer community to accept to collectively > build upon and maintain new code, and to invite future > developers to do so. On the other

Re: RFC on MR 1368

2022-05-25 Thread Jean Abou Samra
This discussion isn't exactly putting Jonas in a comfortable situation, which I empathize with, and I'm trying not to add to that. I do want to raise a few points. Le 25/05/2022 à 19:05, Jonas Hahnfeld via Discussions on LilyPond development a écrit : From the MR: I equally object to any

Re: RFC on MR 1368

2022-05-25 Thread Carl Sorensen
On Wed, May 25, 2022 at 11:20 AM Kevin Barry wrote: > > Also technically I cannot "block contributions", nobody in the > > community has the power to do so. > > > > This might be true technically, but in practice your objections are usually > enough. > I think it is important for us to

Re: RFC on MR 1368

2022-05-25 Thread Kevin Barry
> Also technically I cannot "block contributions", nobody in the > community has the power to do so. > This might be true technically, but in practice your objections are usually enough.

Re: RFC on MR 1368

2022-05-25 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Wed, 2022-05-25 at 08:02 +0200, Han-Wen Nienhuys wrote: > I have had many similarly exhausting discussions before, so I > empathize (it is also the reason that I paused my contributions > recently.) > > I would go with Werner's choices here; as the Freetype author, he is > the expert on font

Re: RFC on MR 1368

2022-05-25 Thread Luca Fascione
There! Thanks Aaron! L On Wed, 25 May 2022, 15:34 Aaron Hill, wrote: > On 2022-05-25 1:31 am, Luca Fascione wrote: > > (*) is there really no way to cross reference/link a commit comment > > from > > gitlab? gah. > > The post's relative time (e.g. "9 hours ago") should itself be a > hyperlink

Re: RFC on MR 1368

2022-05-25 Thread Carl Sorensen
On Tue, May 24, 2022 at 4:01 PM Werner LEMBERG wrote: > > Folks, > > > Jonas and I have an intense (and very exhausting) discussion where to > add kerning data. I want to hear more opinions whether I should go > 'route one' (which I prefer) or 'route two' (which Jonas prefers). > > Please have

Re: RFC on MR 1368

2022-05-25 Thread Aaron Hill
On 2022-05-25 1:31 am, Luca Fascione wrote: (*) is there really no way to cross reference/link a commit comment from gitlab? gah. The post's relative time (e.g. "9 hours ago") should itself be a hyperlink with the appropriate named anchor: [1]:

Re: RFC on MR 1368

2022-05-25 Thread Werner LEMBERG
> Werner instead wants all outlines in one file, all kerning info in a > separate file, all OT features in their own file and so on. This is not correct. I would *love* to be able to have everything in `.mf` files if it made sense. However, it doesn't. As mentioned in the very beginning of

Re: RFC on MR 1368

2022-05-25 Thread Kevin Barry
On Wed, 25 May 2022 at 07:38, Han-Wen Nienhuys wrote: > > I equally object to any contribution being merged "because the author > knows what he's doing". > > I object to reviewers blocking contributions just because they have a > strong opinion on how things should be done. In this case, Jonas

Re: RFC on MR 1368

2022-05-25 Thread Luca Fascione
I've read a bit of the discussion. I'll share my thoughts, I hope they can be of some use. TLDR: I like Werner's approach best, as conceptually outlined in his comment at 'May 25, 2022 6:02am GMT+0200' (*) Largely because it seems to me it lines up best with the sequence of activities somebody

Re: RFC on MR 1368

2022-05-25 Thread Han-Wen Nienhuys
I have had many similarly exhausting discussions before, so I empathize (it is also the reason that I paused my contributions recently.) I would go with Werner's choices here; as the Freetype author, he is the expert on font features and technology. >From the MR: > I equally object to any

RFC on MR 1368

2022-05-24 Thread Werner LEMBERG
Folks, Jonas and I have an intense (and very exhausting) discussion where to add kerning data. I want to hear more opinions whether I should go 'route one' (which I prefer) or 'route two' (which Jonas prefers). Please have a look at MR 1368