LGTM
http://codereview.appspot.com/6105049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: Graham Percival, Keith, Neil Puttock, dak,
Message:
On 2012/04/23 12:20:36, Neil Puttock wrote:
Nevertheless, the voicing should be fixed
even if it means adding explicit \voiceOne commands at appropriate
places. It
looks bad with both voices stem-down.
voiceOne and voiceTwo
On 2012/04/23 04:50:21, Keith wrote:
I need an
\override NoteColumn #'ignore-collision = ##t
here or else I get a warning (either before or after this patch). I
mention
this only because I broke the doc build not too long ago by causing a
warning
from Lilypond input in the docs. (patchy
On 2012/04/23 12:03:41, Neil Puttock wrote:
On 2012/04/23 04:50:21, Keith wrote:
I need an
\override NoteColumn #'ignore-collision = ##t
here or else I get a warning (either before or after this patch). I
mention
this only because I broke the doc build not too long ago by causing
a
On 2012/04/23 12:09:15, dak wrote:
\voiceOne is already used for the upper voice. The problem is that
the voice
settings are totally messed up by the standard grace synchronization
problem.
Remove the graces, and the score typesets fine.
Ah, I didn't scroll down that far. :)
On 2012/04/23 12:09:15, dak wrote:
Remove the graces, and the score typesets fine.
Removing the initial acciaccatura seems appropriate here. It is used as
an example of what LilyPond can do; but starting with a grace note is
not yet something LilyPond can do.
Changing the music is no problem
LGTM
http://codereview.appspot.com/6105049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
works good for me.
I can see the sense in either splitting into two commits as you
mentioned in email (the \hideNotes commit first) or combining into one
(which makes more sense to me since they are so closely related).
