Re: staff_radius fixes (issue 6202048)

2012-05-07 Thread graham
looks like this simplifies things, which is always nice to see. http://codereview.appspot.com/6202048/diff/1/lily/slur-configuration.cc File lily/slur-configuration.cc (right): http://codereview.appspot.com/6202048/diff/1/lily/slur-configuration.cc#newcode291 lily/slur-configuration.cc:291:

Re: staff_radius fixes (issue 6202048)

2012-05-07 Thread benko . pal
On 2012/05/07 18:25:35, Graham Percival wrote: looks like this simplifies things, which is always nice to see. http://codereview.appspot.com/6202048/diff/1/lily/slur-configuration.cc File lily/slur-configuration.cc (right):

Re: staff_radius fixes (issue 6202048)

2012-05-06 Thread benko . pal
this patch makes staff_radius work in cases when line-positions is overridden. so long staff_radius assumed overriding at most line-count. sorry, I forgot to mention that - staff-radius behaved incorrectly also when staff-space is overridden - there's one slight difference in the regression

staff_radius fixes (issue 6202048)

2012-05-05 Thread benko . pal
Reviewers: , Message: this patch makes staff_radius work in cases when line-positions is overridden. so long staff_radius assumed overriding at most line-count. http://codereview.appspot.com/6202048/diff/1/lily/tuplet-bracket.cc File lily/tuplet-bracket.cc (left):