On 2018/06/12 10:05:17, dak wrote:
However, cough cough, all this is an unnecessary complication. Sorry
for
overlooking this. Just write
Stencil q = *s;
[…]
Just to mention it:
How about the definition of ly:stencil-rotate in lily/stencil-scheme.cc?
There, we should have the exact same
On 2018/06/12 10:49:11, Be-3 wrote:
On 2018/06/12 10:05:17, dak wrote:
> However, cough cough, all this is an unnecessary complication.
Sorry for
> overlooking this. Just write
>
> Stencil q = *s;
> […]
Just to mention it:
How about the definition of ly:stencil-rotate in
https://codereview.appspot.com/341350043/diff/1/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/341350043/diff/1/lily/stencil-integral.cc#newcode1132
lily/stencil-integral.cc:1132: SCM new_s = s->smobbed_copy ();
This does not work: the compiler
On 2018/06/12 10:49:11, Be-3 wrote:
On 2018/06/12 10:05:17, dak wrote:
> However, cough cough, all this is an unnecessary complication.
Sorry for
> overlooking this. Just write
>
> Stencil q = *s;
> […]
Just to mention it:
How about the definition of ly:stencil-rotate in
On Jun 12, 2018, at 18:18, carl.d.soren...@gmail.com wrote:
>
> The tradeoff of having people know about dynamic casting and using it
> properly needs to be matched with people not needing to know about
> dynamic casting and being able to ignore it.
Carl, I appreciate hearing your perspective
I remembered another thing about dynamic casting which is not
specifically relevant to the changes in this review, and which should be
pretty well known, but I'll record it here for the sake of completeness.
Wherever there is alternative processing predicated on type, e.g.
if (A *a =
Dan,
Thanks for the feedback. I appreciate it.
I'm still not convinced that pulling the dynamic casts out of the
getter/setter pair is better.
You talk about performance penalties of dynamic casting. But your
profiling shows that dynamic casting took about 1% of the processing
time. Even if
