On 2018/06/13 03:24:02, dan_faithful.be wrote:
On Jun 12, 2018, at 18:18, mailto:carl.d.soren...@gmail.com wrote:
>
> The tradeoff of having people know about dynamic casting and using
it
> properly needs to be matched with people not needing to know about
> dynamic casting and being able to ig
On 2018/06/04 10:51:25, a.myltsev wrote:
Removed the 'test' commits, leaving only changes to Python files.
Patch counted down - please push. Alex if you do not have commit access
can you attach a git-formatted patch (re-based against current master)
and I can push it for you - attach it to the
This looks to me like a nice job of making the code more understandable
and predictable.
LGTM
Carl
https://codereview.appspot.com/339710043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hello,
Here is the current patch countdown list. The next countdown will be on June
16th.
A quick synopsis of all patches currently in the review process can be found
here:
http://philholmes.net/lilypond/allura/
Push:
5337 Create Bottom contexts in a more general way - Dan Eble
https://
I am convinced by these arguments.
Thank you for your patience with me.
Hopefully we can get some rats taken care of.
Carl
https://codereview.appspot.com/344010043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailma
On 2018/06/13 03:24:02, dan_faithful.be wrote:
I perceive that we understand each other’s points and simply disagree.
There is
nothing new I want to counter with. I will just state that if a
contributor
were made uncomfortable by dynamic_cast, my two-pronged solution would
be (1)
gently
LGTM and I would not fault you if you chose to push this immediately
after receiving independent confirmation that it builds.
https://codereview.appspot.com/346070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman
Reviewers: Dan Eble,
Message:
On 2018/06/13 21:11:38, Dan Eble wrote:
LGTM and I would not fault you if you chose to push this immediately
after
receiving independent confirmation that it builds.
Shrug. I have no dependencies on this one. It can sit in its branch
until the shoe drops. I j
