Han-Wen Nienhuys writes:
> On Wed, Mar 25, 2020 at 7:40 PM Carl Sorensen wrote:
>>
>> We don't push until the status becomes Push. Countdown is a last
>> chance for reviewers to comment.
>
> Sorry, I saw Valentin had pushed his, so I assumed this was OK.
But it was an issue by someone else.
We don't push until the status becomes Push. Countdown is a last chance for
reviewers to comment.
Thanks,
Carl
On 3/25/20, 12:06 PM, "lilypond-devel on behalf of Han-Wen Nienhuys"
wrote:
This was marked as Countdown in your Monday mail.
On Wed, Mar 25, 2020 at 5:55 PM James
On Wed, Mar 25, 2020 at 7:40 PM Carl Sorensen wrote:
>
> We don't push until the status becomes Push. Countdown is a last chance for
> reviewers to comment.
Sorry, I saw Valentin had pushed his, so I assumed this was OK.
Note that it was marked countdown for push by today.
> Thanks,
>
>
I'm getting some spurious characters at
http://lilypond.org/manuals.html. Screenshot attached.
Here's some of the page source:
bLearning:
a must-read gentle introduction to LilyPond.
(details of Learning)
Thanks,
David
Am 25.03.20 um 17:19 schrieb Jean-Charles Malahieude:
Hi Werner,
On my way to updating the French documentation, I read in running.itely
(1st item of Relocation algorithm)
"Compute the directory where the currently executed
@command{lilypond} binary is located. Let's call this
Added vowel transitions for lyrics master staging
author David Stephen Grant
Wed, 25 Mar 2020 09:27:43 + (10:27 +0100)
committer Han-Wen Nienhuys
Wed, 25 Mar 2020 09:27:43 + (10:27 +0100)
commit b7034e683d47b1e9bb11e5464a7e514912a0d9ba
---
I don't see any where that
This was marked as Countdown in your Monday mail.
On Wed, Mar 25, 2020 at 5:55 PM James Lowe wrote:
>
> Added vowel transitions for lyrics master staging
> authorDavid Stephen Grant
> Wed, 25 Mar 2020 09:27:43 + (10:27 +0100)
> committerHan-Wen Nienhuys
> Wed, 25 Mar 2020
On Wed, 25 Mar 2020 at 20:06, David Nalesnik wrote:
>
> I'm getting some spurious characters at
> http://lilypond.org/manuals.html. Screenshot attached.
looks python2 vs python3 related: b'' is how python3 prints byte
strings (which were the default string type in python2, but not in
python3).
> I wonder if "bindir/.." shouldn't be "../bindir" (my parents being up
> in the genealogy).
Nope, as others have already confirmed :-)
Werner
Han-wen,
If you're going to push patches before the countdown annoncement email,
have the good grace to update the tracker.
James
On 25/03/2020 15:34, pkx1...@posteo.net wrote:
Hello,
Here is the current patch countdown list. The next countdown will be on
March 27th
A quick synopsis of
Hi Werner,
On my way to updating the French documentation, I read in running.itely
(1st item of Relocation algorithm)
"Compute the directory where the currently executed
@command{lilypond} binary is located. Let's call this
@code{bindir}. Set (internal) environment variable
bindir/.. is the parent directory of bindir
../bindir is the directory bindir that is a child of the parent of the current
directory.
Carl
On 3/25/20, 10:27 AM, "lilypond-devel on behalf of Jean-Charles Malahieude"
wrote:
Hi Werner,
On my way to updating the French
Reviewers: ,
Message:
It's worth emphasizing this: even with these improvements to the
clang-format configuration, those who use clang-format will introduce a
truckload of differences from the traditional indentation.
Description:
https://sourceforge.net/p/testlilyissues/issues/5862/
Prefer
LGTM
https://codereview.appspot.com/577710043/
Hello,
Here is the current patch countdown list. The next countdown will be on
March 27th
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
***
Push:
5860 Remove unused file - Han-Wen Nienhuys
hanw...@gmail.com writes:
> Reviewers: lemzwerg,
>
> Message:
> On 2020/03/22 05:51:34, lemzwerg wrote:
>> LGTM
>>
>> https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in
>> File GNUmakefile.in (right):
>>
>>
>
Patch description in the issue tracker has been updated.
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc
File lily/vowel-transition.cc (right):
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode37
On 3/25/20, Werner LEMBERG wrote:
> Oops, I gave wrong advice, sorry.
You’re not the one to blame; I was the one who jumped the gun.
> Please do
> s/@example/@samp/
> and re-commit.
Done. Aand this is why we have a patch reviewing process. Lesson
learned. (Again.)
V.
https://codereview.appspot.com/547810069/
Reviewers: lemzwerg,
Message:
On 2020/03/22 05:51:34, lemzwerg wrote:
> LGTM
>
> https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in
> File GNUmakefile.in (right):
>
>
https://codereview.appspot.com/547810069/diff/575870045/GNUmakefile.in#newcode26
> GNUmakefile.in:26:
Reviewers: lemzwerg,
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile
File lily/GNUmakefile (right):
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15
lily/GNUmakefile:15: LOADLIBES = $(FLOWER_LIB) $(CONFIG_LIBS)
On 2020/03/21 05:53:15,
> > What's the reason this isn't called `LOADLIBS`?
>
> you should ask the GNU project.
Aah, indeed, thanks. Well, `LOADLIBES` is deprecated, and the new name
is `LDLIBS`. So maybe use `LDLIBS`?
https://codereview.appspot.com/577690043/
22 matches
Mail list logo
