Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

Are you a French forensics? (DNA is adn for us) https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-mea

Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

Have a look at Documentation/HOWTO.index https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely#newcode880 Documentation

Re: texinfo-rules: generate log files in $(outdir)/ (issue 557480043 by hanw...@gmail.com)

Does this mean that, for example, Documentation/fr/learning.*.log and input/regression/collated-files.texilog.log would respectively land in Documentation/fr/out/ and input/regression/out/ ? https://codereview.appspot.com/557480043/

Re: python: Fix compile for in-tree builds (issue 581910043 by jonas.hahnf...@gmail.com)

Thanks Jonas, it works like a charm. If it doesn't break out-tree build, I think you might push directly. https://codereview.appspot.com/581910043/

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

otherwise, LGTM https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely#newcode1624 Documentation/notation/text.itely:1624: @code{s

Re: NR: Update Clef styles Appendix (issue 324420043 by pkx1...@gmail.com)

On 2017/09/24 14:20:08, pkx166h wrote: Corrected the Note styles. Added more formatting changes. Would you mind formatting the "Standard clefs" as well, which would then "group" G, C and F-clefs and have a more pleasant layout? https://codereview.appspot.com/324420043/ ___

Re: Doc: NR - rhythms.itely minor edits to Durations (issue 336030043 by pkx1...@gmail.com)

LGTM https://codereview.appspot.com/336030043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc - NR: Add snippet for MM rests - space increment setting (issue 333970043 by pkx1...@gmail.com)

LGTM https://codereview.appspot.com/333970043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

typos and conistency (issue 332110043 by thomasmorle...@gmail.com)

Didn't you forget to amend the English version of changes.tely?… https://codereview.appspot.com/332110043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: typos and conistency (issue 332110043 by thomasmorle...@gmail.com)

On 2017/11/11 10:36:16, thomasmorley651 wrote: On 2017/11/11 10:11:39, Jean-Charles wrote: > Didn't you forget to amend the English version of changes.tely?… I changed every changes.tely containing addLyrics in _master_ The english version is empty apart from defaults, because it was moved to

Web: GSoC: Add Style Sheets project (issue 340140043 by g...@ursliska.de)

LGTM https://codereview.appspot.com/340140043/diff/1/Documentation/included/gsoc.itexi File Documentation/included/gsoc.itexi (right): https://codereview.appspot.com/340140043/diff/1/Documentation/included/gsoc.itexi#newcode172 Documentation/included/gsoc.itexi:172: (this would involve working

Re: web: Linux => GNU/Linux. English only. (issue 6374060)

On 2012/07/12 12:47:46, janek wrote: Also, i didn't touch translations (btw, is there a complete list of Translation Meisters somewhere? didn't find in CG...). The change will appear with a "check-translation" when master will be merged in translation, or a special "view" on Documentation/ in

Re: Documentation for cross staff stems (issue 6432063)

Just to be sure I understand correctly! http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely#newcode426 Documentation/notation/

Re: Using MSH Paris Nord server

> Message du 25/07/12 00:08 > De : "Trevor Daniels" > A : "Graham Percival" , "John Mandereau" > Copie à : "lilypond-devel" > Objet : Re: Using MSH Paris Nord server > > > Graham Percival wrote Tuesday, July 24, 2012 10:55 PM > > > grenouille.lilynet.net. > > I like it. Definitely better th

PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES (issue 7029043)

Reviewers: dak, phileholmes_googlemail.com, Graham Percival, Message: Please review Description: PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES Introduced with version 1.0.1 : in stepmake/stepmake/C.make ALL_C_SOURCES = h, c, y and l files in stepmake/stepmake/Targets.m

Re: Make documentation reflect presence of \tuplet (issue 7220052)

On 2013/01/29 17:25:19, Keith wrote: I tried to write simpler texts, below. If you are dissatisfied you > can use them as inspiration. I like this evident wording. https://codereview.appspot.com/7220052/ ___ lilypond-devel mailing list lilypond-de

Re: Add Czech translations (issue 7307088)

On 2013/02/10 16:51:30, PhilEHolmes wrote: The Czech strings resemble what I deduced from reading what is in Documentation/cs LGTM https://codereview.appspot.com/7307088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

Typo https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1637 Documentation/notation/vocal.itely:1637: contexts} which will resul

Re: Doc: Error message: unexpected \new (3285) (issue 8581044)

LGTM, amended with Ian's comment about _double_ angle brackets. https://codereview.appspot.com/8581044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Replace transposition example (3159) (issue 8622047)

LGTM https://codereview.appspot.com/8622047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422 Documentation/notation/rhythms.itely:1422: is usually positive and

Re: Doc: Augment description of how to customise staff line positions (3175) (issue 8540046)

LGTM https://codereview.appspot.com/8540046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422 Documentation/notation/rhythms.itely:1422: is usually positive and

Re: Doc: Augment section about titles (3103) (issue 8895044)

LGTM Cheers, Jean-Charles https://codereview.appspot.com/8895044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Document the use of \temporary (2938) (issue 8859044)

LGTM Jean-Charles https://codereview.appspot.com/8859044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Document \absolute in Changes and Notation Reference (issue 8933043)

LGTM Jean-Charles https://codereview.appspot.com/8933043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Remove space before the tie symbol (3133) (issue 8758047)

On 2013/04/25 15:20:07, dak wrote: On 2013/04/25 15:10:35, Graham Percival wrote: > I'm not wild about having ties without a space in front of them, but I can't > think of any rational reason for my reaction, so I guess LGTM. Oh, there is a perfectly rational reason: ties are placed symmetr

Re: Doc: elaborate the placement of \paper blocks (2902) (issue 8599045)

LGTM Jean-Charles https://codereview.appspot.com/8599045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: elaborate explanation of accidentals within cadenzas (3078) (issue 8866043)

LGTM Jean-Charles https://codereview.appspot.com/8866043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Use @dots{} instead of ... in notation manual where appropriate (issue 9964043)

There is also notation/rhythms.itely:2320:If a manual beam is specified with @code{[..]} set the beam For the rest, LGTM https://codereview.appspot.com/9964043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview

Re: Use @dots{} instead of ... in notation manual where appropriate (issue 9964043)

On 2013/06/04 18:33:41, dak wrote: https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely#newcode49 Documentation/notation/simultaneous.itely:49: @funindex <...> On 2013/06/04 18:17:21, Jean-Charles wrote: > @funindex <@dots{}> No, the index is something that

re: can't release 2.15.17 due to translators

> Message du 09/11/11 21:00 > De : "Graham Percival" > A : lilypond-devel@gnu.org > Copie à : > Objet : can't release 2.15.17 due to translators > > can somebody fix this? and depending on dak, either push directly > to master (which means he has to play yet more games with > dev/staging), or push

re: [PATCH 1/2] Fix spelling definiton -> definition

> Message du 20/01/12 03:42 > De : "Stefan Weil" > A : lilypond-devel@gnu.org > Copie à : "Stefan Weil" > Objet : [PATCH 1/2] Fix spelling definiton -> definition > > Signed-off-by: Stefan Weil --- > po/cs.po > po/de.po > po/el.po > po/es.po > po/fr.po > po/it.po > po/ja.po > po/lilypond.pot > po/

Re: [PATCH 1/2] Fix spelling definiton -> definition

> Message du 20/01/12 09:15 > De : "James" > A : "Lilyfan" > Copie à : "StefanWeil" , lilypond-devel@gnu.org > Objet : Re: [PATCH 1/2] Fix spelling definiton -> definition > > Jean-Charles, > > On 20 January 2012 08:02, Lilyfan wrot

PO: modifying po-replace before integrating it to the release process (issue 6188051)

Reviewers: Graham Percival, Message: Before integrating po-replace in the release process, let build a well-formed lilypond.pot in one run. Description: PO: modifying po-replace before integrating it to the release process Until now, updating the translation template file is disconnected from

CG: add updating of lilypond.pot in the release process (issue 6195060)

Reviewers: Graham Percival, Message: Both when releasing a stable or unstable version. Description: CG: add updating of lilypond.pot in the release process Please review this at http://codereview.appspot.com/6195060/ Affected files: M Documentation/contributor/release-work.itexi Index: Doc

Re: CG: add updating of lilypond.pot in the release process (issue 6195060)

Uploading new version http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi File Documentation/contributor/release-work.itexi (right): http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi#newcode87 Documentation/contributo

Re: Doc: NR clarified \footnote command as a TextScript (issue 6137050)

Nitpicks, but I had to read twice and carefully the first paragraph and I'm not sure to understand. http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6137050/diff/14003/Documentation

Use @dots{} instead of ... in manuals (issue 10296043)

Reviewers: dak, Trevor Daniels, Graham Percival, Message: Follow up of issue 3392 Description: Use @dots{} instead of ... in manuals Web: intro and helpus Doc: usage, extenting and learning Please review this at https://codereview.appspot.com/10296043/ Affected files: M Documentation/ext

Re: Updates to NR chapter 2 (issue 10543044)

fro the rest, LGTM https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely File Documentation/notation/chords.itely (right): https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely#newcode442 Documentation/notation/chords.itely:442: chordmus

Re: Corrections to LM (Issue 3407) (issue 11455046)

Except one nitpick, LGTM https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2387 Documentation/learning/tweaks.itely:2387:

Re: ERROR: Please install required programs: International New Century Schoolbook fonts

> Message du 13/09/13 00:55 > De : "Julien Rioux" > On 12/09/2013 6:09 PM, Federico Bruni wrote: > > 2013/8/3 Federico Bruni > > > > > I'm getting this error if I run ./autogen.sh in git master: > > > > ERROR: Please install required programs: International New Century > > Schoolbook fonts Interna

Re: Track move of grammar to CG (issue 3015) in German translation (issue 14160044)

On 2013/10/01 11:52:35, dak wrote: Use @rcontribnamed for translated link names LGTM https://codereview.appspot.com/14160044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 3720: Built-in templates for SATB vocal scores (issue 41990043)

LGTM, except one typo. https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely File Documentation/learning/templates.itely (right): https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely#newcode53 Documentation/learning/templates.itel

Re: Web:Reworded UNIX Download page more strongly not to use distro-based packages (issue 60180043)

LGTM https://codereview.appspot.com/60180043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)

On 2014/02/08 21:55:15, dak wrote: Is there any way in which one can actually delete this snippet file without getting it carried back in via LSR? According to CG 7.4: "Snippets used in the documentation are in '$LILYPOND_GIT/Documentation/snippets'. This directory contains a complete set of

Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

I just picked one file, but there might be some other occurrences of such "things". https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly File Documentation/snippets/ancient-notation-templatemodern-tr

Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

On 2014/07/20 15:45:14, email_philholmes.net wrote: [...] Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:88: > \once \once \hide NoteHead c'1 | > Why this doubled "\once"? Copy and paste error. Unfortunately it's not trivial to correct "prope

Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

Good job! Thanks! https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/editorial-headword.ly File Documentation/snippets/editorial-headword.ly (right): https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/editorial-headword.ly#newcode22 Documentation/

Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

On 2014/07/20 16:49:33, mail_philholmes.net wrote: - Original Message - From: https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly > File > Documentation/snippets/adding-indicator

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 13:51:33, PhilEHolmes wrote: Please review. Sorry to step in like that. I'm not able to comment on the code, but have just one question, since I don't use incipits: does it happen that the original score reproduced in an incipit happens to be on a four lines staff? How would it t

Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

If I'm not mistaken, this patch *changes* every natural pitch in English instead of just adding or including a variant for "natural". Since this will modify what is in place since more than 15 years, it is essential to document it, both in "changes" and over the documentation. Too bad, I prefer

Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

On 2014/08/25 10:13:52, Trevor Daniels wrote: I think you're mistaken. In the original file the unaltered English notenames were defined twice, and this patch alters just one of them, leaving the other unchanged. So it does just add a variant. Sorry, I did not expand enough! https://code

Re: Changes.tely updated - 2.19.x up to September 2014 (issue 147860043 by pkx1...@gmail.com)

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode127 Documentation/changes.tely:127: the existing @code{\keepWithTag} and @code{removeWithTag} comm

Re: Doc: Clarified how to use clip-systems option (issue 186640043 by pkx1...@gmail.com)

just one nitpick, otherwise LGTM. https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2559 Documentation/notation/input.itely

Re: Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)

LGTM for French https://codereview.appspot.com/193890043/diff/1/Documentation/de/notation/ancient.itely File Documentation/de/notation/ancient.itely (right): https://codereview.appspot.com/193890043/diff/1/Documentation/de/notation/ancient.itely#newcode2670 Documentation/de/notation/ancient.ite

Re: Doc: Clarified how to use clip-systems option (issue 186640043 by pkx1...@gmail.com)

Sorry to come so late https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely#newcode2543 Documentation/notation/input.itely:254

Doc Issue 4350: \compressFullBarRests needs a warning (issue 227470043 by tdanielsmu...@googlemail.com)

Otherwise, LGTM https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193 Documentation/learning/fundamental

Change comments like Voice "1" to Voice = "1" (issue 256860044 by d...@gnu.org)

LGTM https://codereview.appspot.com/256860044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 4557: Small typos in code base (issue 256470043 by d...@gnu.org)

Normally, you should not modify lilypond.pot as it is updated by commit "PO: update template" during the releasing phase. For the *.po files, they are managed through the Free Translation Project. https://codereview.appspot.com/256470043/ ___ lilypon

Re: Issue 4557: Small typos in code base (issue 256470043 by d...@gnu.org)

On 2015/08/14 16:47:08, dak wrote: On 2015/08/14 16:38:18, Jean-Charles wrote: > Normally, you should not modify lilypond.pot as it is updated by commit "PO: > update template" during the releasing phase. > > For the *.po files, they are managed through the Free Translation Project. What doe

Ignore backslash when indexing (issue 300390043 by d...@gnu.org)

LGTM That's where I put it yesterday for testing. https://codereview.appspot.com/300390043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: Move older news to the attic page (issue 318630043 by paulwmor...@gmail.com)

https://codereview.appspot.com/318630043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: Move older news to the attic page (issue 318630043 by paulwmor...@gmail.com)

On 2017/03/04 18:02:28, pkx166h wrote: Fails make doc. Seems to be a problem in the Catalan translations. Processing web site: [ca] *** Can't find web/news.itexi, skipping (in /home/james/lilypond-git/Documentati on/ca/web/community.itexi l. 1208) Max error number exceeded This line con