Re: MusicXML2Ly: Problem with minor chords

Jacques Menu Muzhic writes: >> Le 17 août 2016 à 21:26, David Kastrup a écrit: >> >> Johan Vromans writes: >> >>> David Kastrup wrote: >>> ... the change to let c:5 exclude the third was introduced as late

Re: MusicXML2Ly: Problem with minor chords

BTW, how are such regression tests devised and organized? JM > Le 17 août 2016 à 21:26, David Kastrup a écrit : > > Johan Vromans writes: > >> David Kastrup wrote: >> >>> ... the change to let >>> c:5 exclude the third was introduced as

Re: MusicXML2Ly: Problem with minor chords

Johan Vromans writes: > David Kastrup wrote: > >> ... the change to let >> c:5 exclude the third was introduced as late as version 2.19.28). > > Does that mean that there are no (regression)tests for musicxml2ly? Probably not enough. -- David Kastrup

Re: MusicXML2Ly: Problem with minor chords

David Kastrup wrote: > ... the change to let > c:5 exclude the third was introduced as late as version 2.19.28). Does that mean that there are no (regression)tests for musicxml2ly? ___ lilypond-user mailing list lilypond-user@gnu.org

Re: MusicXML2Ly: Problem with minor chords

On Wed, 17 Aug 2016 14:15:02 +0200 David Kastrup wrote: > Well, musicxml2ly.py presumably also generates a \version header, and > running convert-ly on the resulting file possibly fixes a number of > those problems (even though it complicates the rules, the change to let > c:5

Re: MusicXML2Ly: Problem with minor chords

Johan Vromans writes: > Johan Vromans wrote: > >> is translated into >> >> d:m5 >> >> and apparently not understood -- lilypond renders it as a major D chord >> without warning. > > The code in musicxml2ly.py does, indeed, generate :m5 for minor.

Re: MusicXML2Ly: Problem with minor chords

Johan Vromans wrote: > is translated into > > d:m5 > > and apparently not understood -- lilypond renders it as a major D chord > without warning. The code in musicxml2ly.py does, indeed, generate :m5 for minor. Surprisingly, the NR, A.2 Common chord modifiers, reads:

MusicXML2Ly: Problem with minor chords

Hi, In the attached XML, the minor D chord D minor is translated into d:m5 and apparently not understood -- lilypond renders it as a major D chord without warning. Dm(maj7) becomes d:maj7m5. A similar thing happens to half-diminished