Re: edition-engraver engine.scm with 2.23.6

[Jean Abou Samra]

Hi,

Le 28/09/2022 à 12:13, Jean Abou Samra a écrit :


It seems that LilyPond does an inappropriate type check on
the second argument of ly:make-stream-event (pair? instead
of cheap-list?), but it also looks like edition-engraver is
missing some bits.




The basic failure in LilyPond is fixed now
(https://gitlab.com/lilypond/lilypond/-/merge_requests/1644),
although the deeper problems of the edition engraver remain.

Best,
Jean

Re: edition-engraver engine.scm with 2.23.6

[Kieren MacMillan]

Hi Jean,

> Looks like the edition-engraver doesn't like injecting
> \newSpacingSection. By the way, it has nothing to do with
> 2.23.6, also happens in 2.22. As a workaround, you can
> replace \newSpacingSection with
> 
> #(make-event-chord (list (make-music 'SpacingSectionEvent 'dummy 'dummy)))

You are a twelfth-level wizard!
That totally worked — thanks.

Back to the grindstone!
Kieren.

Re: edition-engraver engine.scm with 2.23.6

[Jean Abou Samra]

Le 28/09/2022 à 09:48, Mark Knoop a écrit :

Hi Kieren,

At 20:02 on 27 Sep 2022, Kieren MacMillan wrote:

I ran with --verbose, and here's the output:

Would it be possible to send that as text?


I downloaded the files from
 about a week ago — do you
have a different set/source?

Probably best to switch back to
https://github.com/openlilylib/edition-engraver now, we're merging
everything back to that. (Although I don't know if there are currently
any differences between the two...)

If you can send some code I'll try to have a look later today.




Phew, I only receive this message now. Well, if you want
to have a deeper look, read Music::to_event in the source
and try to make the EE match what it does more closely.

Re: edition-engraver engine.scm with 2.23.6

[Jean Abou Samra]

Le 28/09/2022 à 02:02, Kieren MacMillan a écrit :

Hi again,

I ran with --verbose, and here's the output:
[image]
Maybe something in there can be used to narrow down where I should be 
focusing my search?




Looks like the edition-engraver doesn't like injecting
\newSpacingSection. By the way, it has nothing to do with
2.23.6, also happens in 2.22. As a workaround, you can
replace \newSpacingSection with

#(make-event-chord (list (make-music 'SpacingSectionEvent 'dummy 'dummy)))

It seems that LilyPond does an inappropriate type check on
the second argument of ly:make-stream-event (pair? instead
of cheap-list?), but it also looks like edition-engraver is
missing some bits. I don't have the time to look more closely
for now, maybe later, or maybe someone else will do it.

Jean

Re: edition-engraver engine.scm with 2.23.6

[Mark Knoop]

Hi Kieren,

At 20:02 on 27 Sep 2022, Kieren MacMillan wrote:
> I ran with --verbose, and here's the output:

Would it be possible to send that as text?

> I downloaded the files from
>  about a week ago — do you
> have a different set/source?

Probably best to switch back to
https://github.com/openlilylib/edition-engraver now, we're merging
everything back to that. (Although I don't know if there are currently
any differences between the two...)

If you can send some code I'll try to have a look later today.

Cheers,

Mark


--
Mark Knoop

Re: edition-engraver engine.scm with 2.23.6

[Kieren MacMillan]

Hi Jean,

> Then please give an example. Come on, you're a long-time user,
> you know https://lilypond.org/tiny-examples.html, right? :D

Tiny example… with the edition-engraver… and an include tree of multiple dozens 
of files…
Sure, I'll get right on that.  ;)

> The examples in the edition-engraver repo all work for me in 2.23.6

I downloaded the files from  about a 
week ago — do you have a different set/source?

Thanks,
Kieren.

Re: edition-engraver engine.scm with 2.23.6

[Jean Abou Samra]

Le 28/09/2022 à 00:44, Kieren MacMillan a écrit :

Hi Jean,


There was a renaming. If you had markFormatter somewhere in your
code, you need to change it into rehearsalMarkFormatter. Or just
“Run convert-ly ™” :-)

I did that.
It apparently doesn‘t solve the "Wrong type argument in position 2" error…?




Then please give an example. Come on, you're a long-time user,
you know https://lilypond.org/tiny-examples.html, right? :D

The examples in the edition-engraver repo all work for me in 2.23.6,
both the version with Guile 2 from GitLab and the one with Guile 1
from lilypond.org, which is not surprising given that Mark Knoop
and me made some commits to make it compatible recent versions, testing
with 2.23.11 (but also testing that it still worked in 2.22).

Cheers,
Jean

Re: edition-engraver engine.scm with 2.23.6

[Kieren MacMillan]

Hi Jean,

> There was a renaming. If you had markFormatter somewhere in your
> code, you need to change it into rehearsalMarkFormatter. Or just
> “Run convert-ly ™” :-)

I did that.
It apparently doesn‘t solve the "Wrong type argument in position 2" error…?

Thanks,
Kieren.

Re: edition-engraver engine.scm with 2.23.6

[Jean Abou Samra]

Le 27/09/2022 à 23:04, Kieren MacMillan a écrit :

Hi all,

I'm trying to run 2.23.6 with the edition-engraver. I think I have the most 
recent files, but I'm getting the following error:

warning: cannot find property type-check for 'markFormatter' 
(translation-type?).  perhaps a typing error?

It points to line 805 in engine.scm, and says "Wrong type argument in position 
2".
Here's lines 804-808:

  (ly:broadcast (ly:context-event-source context)
(ly:make-stream-event
 (ly:assoc-get 'types (ly:assoc-get mod-name 
music-descriptions '()) '())
 (ly:music-mutable-properties mod)))
  )

Can anyone help me figure out how to patch this?
Of course I'm under the gun for a big set of engravings — Mercury's still in 
retrograde, right? ;)




There was a renaming. If you had markFormatter somewhere in your
code, you need to change it into rehearsalMarkFormatter. Or just
“Run convert-ly ™” :-)

edition-engraver engine.scm with 2.23.6

[Kieren MacMillan]

Hi all,

I'm trying to run 2.23.6 with the edition-engraver. I think I have the most 
recent files, but I'm getting the following error:

warning: cannot find property type-check for 'markFormatter' 
(translation-type?).  perhaps a typing error?

It points to line 805 in engine.scm, and says "Wrong type argument in position 
2".
Here's lines 804-808:

 (ly:broadcast (ly:context-event-source context)
   (ly:make-stream-event
(ly:assoc-get 'types (ly:assoc-get mod-name 
music-descriptions '()) '())
(ly:music-mutable-properties mod)))
 )

Can anyone help me figure out how to patch this?
Of course I'm under the gun for a big set of engravings — Mercury's still in 
retrograde, right? ;)

Thanks,
Kieren.