RE: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up

Daniel Lezcano wrote: On 01/10/2013 11:33 PM, amit daniel kachhap wrote: On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano daniel.lezc...@free.fr wrote: On 01/10/2013 09:07 PM, amit daniel kachhap wrote: Hi Daniel, Hi Amit Daniel, This hotplug noifiers looks fine. I suppose it

Re: [PATCH 1/2] ARM: s3c64xx: cpuidle - declare the states with the new api

Brownbroo...@opensource.wolfsonmicro.com Thanks for testing, applied this series. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev

RE: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups

ok to me. I don't have this board, I was not able to test these patches. Mark, could you please check this patches on your board? Now, my smdk6410 has some problem to test this :( Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team

RE: [PATCH] ARM: exynos: Adapt to cpuidle core time keeping and irq enable

amit kachhap wrote: Hi Mr Kukjin, Any comment or update about this patch? I'm not sure we don't need to check the idle_time? Others, looks ok to me. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co

Re: [PATCH 2/3] ARM: EXYNOS: Add clkdev lookup entry for lcd clock

On 02/29/12 21:15, Kukjin Kim wrote: Tushar Behera wrote: [...] Acked-by: Jingoo Hanjg1@samsung.com OK, I will apply this with Sylwester's 'reviewed-by' I looked at before. Thanks. Do you want me rebase this patch on your latest for-next and resend? Thanks but I can do it. BTW

RE: [PATCH 2/3] ARM: EXYNOS: Add clkdev lookup entry for lcd clock

] in this series? If they are still needed now, could you please re-send? Maybe I missed. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing

RE: [PATCH 2/3] ARM: EXYNOS: Add clkdev lookup entry for lcd clock

Tushar Behera wrote: Hi Kukjin, Tushar, please don't top-post. On 03/01/2012 09:36 AM, Kukjin Kim wrote: Jingoo Han wrote: Hi Tushar, (please don't top-post) -Original Message- From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung- soc- ow

RE: February 2012 Kernel Release

Amit Kachhap wrote: Hi kukjin Kim, Hi, I was on travel for elc and linaro conferences so little late for replying. Thanks for testing these patches. I just submitted the V6 series of the cpuidle patchset. I rebased it against the 3.3-rc4 kernel version. I also tested it for SMDKV310

RE: February 2012 Kernel Release

Amit Kachhap wrote: Hi Amit Kucheria, Hi all, (Cc'ed Jaecheol Lee and Jongpill Lee) I have asked the samsung maintainer(Kukjin Kim) to queue this patch set 1 month back. But seems like it is not present. If it works fine, then I'm apply this series. But now it is not working

RE: [PATCH V4 0/5] ARM: exynos: Add l2 retention mode cpuidle state

these these patches can merged in this 3.3 merge window? Kindly let me know your opinion. This conflicts with local common.[ch] working for ARM restart. Please wait until after the merge window for this patches. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW

RE: [PATCH] ARM: EXYNOS4: Enable Bluetooth on ORIGEN

Sangwook Lee wrote: This patch enables Bluetooth support on ORIGEN board. Signed-off-by: Sangwook sangwook@linaro.org Maybe should be 'Signed-off-by: Sangwook Lee sangwook@linaro.org'? Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution

RE: [PATCH 3/3] ARM: EXYNOS: Invert VCLK polarity for framebuffer on Origen board

| + VIDCON1_INV_VCLK, .setup_gpio = exynos4_fimd0_gpio_setup_24bpp, }; -- 1.7.4.1 OK, will apply this. And I will review 1/3 and 2/3 patches soon. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution

RE: [PATCH] ARM: EXYNOS: Add USB OHCI support to ORIGEN board

@samsung.com OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. Thanks. Best regards, Jingoo Han --- This patch are based Kukjin's for-next branch and OHCI related patches

RE: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

via Samsung tree separately and you can add my and Boojin Kim's ack(actually, she replied) on this when you apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. For latter: Acked-by: Vinod Koul

RE: [PATCH 2/2] ARM: EXYNOS: Add apb_pclk clkdev entry for mdma1

. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

RE: [PATCH 0/3] Moving xusbxti clock setting in clock.c file.

though current value is same. So it should being at the each board file. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev

RE: [PATCH] gpio/samsung: Move SoC specific codes within macro

Kukjin Kim wrote: Grant Likely wrote: On Mon, Oct 03, 2011 at 08:59:19AM +0530, Tushar Behera wrote: In drivers/gpio/gpio-samsung.c, there are certain structures and functions which are not getting used if the particular CPU is not selected. These code segments are moved under CPU

RE: [PATCH] gpio/samsung: Move SoC specific codes within macro

KALLSYMS_EXTRA_PASS=1 as a workaround make: *** [vmlinux] Error 1 And it seems due to add condition around the 'static unsigned s3c24xx_gpio_getcfg_abank()'. I need to check it in detail and if any problems, let you know. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW

RE: [PATCH V4] ARM: EXYNOS4: Add machine support for 7 LCD on ORIGEN

to pass this information through device tree blob. For non-DT machines, IMHO, we have to follow the current approach. OK, applied. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd

RE: [PATCH] ARM: EXYNOS4: Add keypad support for Origen

[] __initdata = { s3c_device_hsmmc2, s3c_device_rtc, s3c_device_wdt, + origen_device_gpiokeys, }; static void __init origen_map_io(void) -- 1.7.4.1 Looks ok to me, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution

RE: [PATCH] ARM: EXYNOS4: Enable double linefill in PL310 Prefetch Control Register

patch, enabling WRAP read is better on it. Actually my colleague, Boojin Kim is testing it so that can submit it soon. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd

RE: [PATCH] ARM: EXYNOS4: convert boot_params to atag_offset

/mach-exynos4/mach-smdk4212.c @@ -284,7 +284,7 @@ static void __init smdk4212_machine_init(void) MACHINE_START(SMDK4212, SMDK4212) /* Maintainer: Kukjin Kim kgene@samsung.com */ - .boot_params= S5P_PA_SDRAM + 0x100, + .atag_offset= 0x100, .init_irq

RE: [PATCH V2] ARM: EXYNOS4: Add machine support for 7 LCD on ORIGEN

. + }, + .max_bpp= 32, + .default_bpp= 24, +}; Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list

RE: [PATCH V2] ARM: EXYNOS4: Add machine support for 7 LCD on ORIGEN

) pr_err(failed to request gpio for LCD power: %d\n, ret); Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev

RE: [PATCH] ARM: EXYNOS4: ADD USB EHCI device to SMDKV310

Kukjin Kim wrote: Sachin Kamat wrote: Signed-off-by: Bhuvana Kakunoori bhuvana.kakuno...@linaro.org Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos4/Kconfig |2 ++ arch/arm/mach-exynos4

RE: [PATCH 3/3] ARM: EXYNOS4: Add support for 8-bit bus width in SDHCI for ORIGEN

Tushar Behera wrote: On Wednesday 31 August 2011 06:31 AM, Kukjin Kim wrote: Tushar Behera wrote: Platform data for SDHCI controller on ORIGEN board is missing the support for 8-bit bus width. The platform data is extended in sync with other EXYNOS4 machines. Signed-off

RE: [PATCH 2/2] ARM: EXYNOS4: Add USB PHY initialization for device

you need to check about whole USB PHY structure on EXYNOS4 again. In addition, I don’t have idea we need to control USB Host clock for handling USB PHY enable/disable. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung

RE: [PATCH] ARM: EXYNOS4: Add USB EHCI device to Origen

)); } -- 1.7.4.1 OK, will apply with re-ordering as per my comments. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev

RE: [PATCH 2/3] ARM: EXYNOS4: Add support for secondary MMC port on ORIGEN

); + s3c_sdhci0_set_platdata(origen_hsmmc0_pdata); platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); } -- 1.7.4.1 OK, will apply. If you don't mind, I will add comments the reason of the ordering when I apply this. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com

RE: [PATCH 1/3] ARM: EXYNOS4: Fix sdhci card detection for ORIGEN

= S3C_SDHCI_CD_INTERNAL, .clk_type = S3C_SDHCI_CLK_DIV_EXTERNAL, }; -- 1.7.4.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd

RE: [PATCH] ARM: EXYNOS4: Add FIMC device on Origen board

, + s5p_device_fimc1, + s5p_device_fimc2, + s5p_device_fimc3, s3c_device_hsmmc2, s3c_device_rtc, s3c_device_wdt, -- 1.7.4.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung

RE: [PATCH 1/1] ARM: EXYNOS4: Add PWM backlight support on Origen

); platform_add_devices(origen_devices, ARRAY_SIZE(origen_devices)); + + samsung_bl_set(origen_bl_gpio_info, origen_bl_data); } MACHINE_START(ORIGEN, ORIGEN) -- 1.7.4.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development

RE: [PATCH] ARM: EXYNOS4: Enable system MMU support on Origen

? As I know, the EXYNOS System MMU driver will be changed like a form of omap and msm soon maybe it's within 1 or 2 weeks. So if this is not required on ORIGEN now, I'd like to wait for new EXYNOS System MMU driver. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW

RE: [PATCH 1/2] ARM: EXYNOS4: Code cleanup and remove extra functions.

regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

RE: [PATCH] ARM: EXYNOS4: ADD USB EHCI device to SMDKV310

this on smdkv310 on his patch just now... Hmm...I don't know :( Let me think again... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list

RE: [PATCH] ARM: EXYNOS4: Enable MFC on Samsung SMDKV310

. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

RE: [PATCH V2] ARM: EXYNOS4: Add support for ORIGEN board

, I remember this :) Looks ok to me, applied. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linaro-dev mailing list linaro-dev@lists.linaro.org http

RE: [PATCH] ARM: EXYNOS4: Fix addruart macro

Thomas Abraham wrote: Fix incorrect conditional execution of ldr instructions in addruart macro. Oops :( Ok, will apply:) As a note, I found same patch with this in your previous patches. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution

RE: [PATCH V2] ARM: SAMSUNG: Add support for clock debugging through debug-fs interface

Amit Daniel Kachhap wrote: Hi Mr Kim, Thanks for your comments. Please see the inline comments below. Hi Amit, I didn't get your updated patch, but it was small things. So I applied this in my tree for this merge window. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com

RE: [PATCH V2] ARM: SAMSUNG: Add support for clock debugging through debug-fs interface

); +#if defined(CONFIG_PM_DEBUG) defined(CONFIG_DEBUG_FS) + struct dentry *dent; /* For visible tree hierarchy */ +#endif }; /* other clocks which may be registered by board support */ -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW

RE: [PATCH] ARM: SAMSUNG: Add support for clock debugging through debug-fs interface

be registered by board support */ -- I think, you just copied this from omap. Of course, there is small changes... I mean, would be better, if you could add more useful debug-fs i/f for Samsung SoCs' clock. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW