Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-30 Thread Linus Walleij
On Fri, Sep 30, 2011 at 4:12 AM, Grant Likely grant.lik...@secretlab.ca wrote:  config MACH_U300       bool U300 +     select PINCTRL +     select PINMUX_U300 Shouldn't PINMUX_U300 select PINCTRL? It selects PINMUX which is inside the if-clause for the subsystem: if PINCTRL config PINMUX

Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-29 Thread Grant Likely
On Fri, Sep 16, 2011 at 02:14:09PM +0200, Linus Walleij wrote: From: Linus Walleij linus.wall...@linaro.org This adds a driver for the U300 pinmux portions of the system controller SYSCON. It also serves as an example of how to use the pinmux subsystem. This driver also houses the platform

Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-28 Thread Linus Walleij
On Wed, Sep 28, 2011 at 2:15 AM, Stephen Warren swar...@nvidia.com wrote: But can't debugfs just get its information from the device name field in the mapping table? I'm not sure why the need to use that information for debugfs prevents the having entries with both the hog flag set and a

RE: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-28 Thread Stephen Warren
Linus Walleij wrote at Wednesday, September 28, 2011 5:59 AM: On Wed, Sep 28, 2011 at 2:15 AM, Stephen Warren swar...@nvidia.com wrote: But can't debugfs just get its information from the device name field in the mapping table? I'm not sure why the need to use that information for debugfs

Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-27 Thread Linus Walleij
On Wed, Sep 21, 2011 at 9:39 PM, Stephen Warren swar...@nvidia.com wrote: Linus Walleij wrote at Wednesday, September 21, 2011 2:25 AM: On Wed, Sep 21, 2011 at 12:15 AM, Stephen Warren swar...@nvidia.com wrote: Linus Walleij wrote at Friday, September 16, 2011 6:14 AM: +     for (i = 0; i

RE: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-27 Thread Stephen Warren
Linus Walleij wrote at Tuesday, September 27, 2011 2:01 AM: On Wed, Sep 21, 2011 at 9:39 PM, Stephen Warren swar...@nvidia.com wrote: Linus Walleij wrote at Wednesday, September 21, 2011 2:25 AM: On Wed, Sep 21, 2011 at 12:15 AM, Stephen Warren swar...@nvidia.com wrote: Linus Walleij

Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-21 Thread Linus Walleij
On Wed, Sep 21, 2011 at 12:15 AM, Stephen Warren swar...@nvidia.com wrote: Linus Walleij wrote at Friday, September 16, 2011 6:14 AM: +     for (i = 0; i ARRAY_SIZE(u300_mux_hogs); i++) { +             struct pinmux *pmx; +             int ret; + +             pmx =

RE: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

2011-09-21 Thread Stephen Warren
Linus Walleij wrote at Wednesday, September 21, 2011 2:25 AM: On Wed, Sep 21, 2011 at 12:15 AM, Stephen Warren swar...@nvidia.com wrote: Linus Walleij wrote at Friday, September 16, 2011 6:14 AM: +     for (i = 0; i ARRAY_SIZE(u300_mux_hogs); i++) { +             struct pinmux *pmx; +