Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-18 Thread Manjunath Goudar
On 14 June 2013 01:22, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 13 Jun 2013, Tomasz Figa wrote: + rc = ohci_suspend(hcd, do_wakeup); + if (rc == 0 do_wakeup HCD_WAKEUP_PENDING(hcd)) { + ohci_resume(hcd, false); + rc = -EBUSY; + } I'm not

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-18 Thread Sachin Kamat
On 18 June 2013 15:24, Manjunath Goudar manjunath.gou...@linaro.org wrote: On 14 June 2013 01:22, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 13 Jun 2013, Tomasz Figa wrote: + rc = ohci_suspend(hcd, do_wakeup); + if (rc == 0 do_wakeup HCD_WAKEUP_PENDING(hcd)) { +

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-18 Thread Alan Stern
On Tue, 18 Jun 2013, Manjunath Goudar wrote: After Alan explanation I am writing below code end of ohci_suspend() routine.is it correct Alan. if (do_wakeup HCD_WAKEUP_PENDING(hcd)) { ohci_resume(hcd, false); rc = -EBUSY; } I'm glad you

[PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-13 Thread Manjunath Goudar
Suspend scenario in case of ohci-exynos glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in exynos_ohci_suspend() will ensure proper handling of suspend scenario. V2: -Incase ohci_suspend() fails, return right

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-13 Thread Alan Stern
On Thu, 13 Jun 2013, Tomasz Figa wrote: + rc = ohci_suspend(hcd, do_wakeup); + if (rc == 0 do_wakeup HCD_WAKEUP_PENDING(hcd)) { + ohci_resume(hcd, false); + rc = -EBUSY; + } I'm not into USB host subsystem, so I might just ask a stupid question. Can't

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-13 Thread Tomasz Figa
Hi Manjunath, On Thursday 13 of June 2013 14:46:24 Manjunath Goudar wrote: Suspend scenario in case of ohci-exynos glue was not properly handled as it was not suspending generic part of ohci controller.Calling explicitly the ohci_suspend() routine in exynos_ohci_suspend() will ensure proper