Re: [PATCH v3 2/3] ARM: imx: Add imx5 cpuidle driver

2012-05-10 Thread Rob Lee
On Thu, May 10, 2012 at 7:41 AM, Sascha Hauer wrote: > On Wed, May 09, 2012 at 09:27:02AM -0500, Rob Lee wrote: >> Sascha, >> >> > >> > This clk_get should go away here and be moved somewhere to >> > initialization. Also, if getting this clock fails we can still >> > do regular cpu_do_idle. Additi

Re: [PATCH v3 2/3] ARM: imx: Add imx5 cpuidle driver

2012-05-10 Thread Sascha Hauer
On Wed, May 09, 2012 at 09:27:02AM -0500, Rob Lee wrote: > Sascha, > > > > > This clk_get should go away here and be moved somewhere to > > initialization. Also, if getting this clock fails we can still > > do regular cpu_do_idle. Additionally, if clk_get fails, we'll > > have a ERR_PTR value in g

Re: [PATCH v3 2/3] ARM: imx: Add imx5 cpuidle driver

2012-05-09 Thread Rob Lee
Sascha, On Wed, May 9, 2012 at 3:02 AM, Sascha Hauer wrote: > On Mon, May 07, 2012 at 04:16:46PM -0500, Robert Lee wrote: >> Add imx5 cpuidle driver. >> >> Signed-off-by: Robert Lee >> --- >>  arch/arm/mach-imx/mm-imx5.c |   42 >> +++--- >>  1 file changed, 3

Re: [PATCH v3 2/3] ARM: imx: Add imx5 cpuidle driver

2012-05-09 Thread Sascha Hauer
On Mon, May 07, 2012 at 04:16:46PM -0500, Robert Lee wrote: > Add imx5 cpuidle driver. > > Signed-off-by: Robert Lee > --- > arch/arm/mach-imx/mm-imx5.c | 42 +++--- > 1 file changed, 39 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-imx/mm-im

[PATCH v3 2/3] ARM: imx: Add imx5 cpuidle driver

2012-05-07 Thread Robert Lee
Add imx5 cpuidle driver. Signed-off-by: Robert Lee --- arch/arm/mach-imx/mm-imx5.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/mm-imx5.c b/arch/arm/mach-imx/mm-imx5.c index d6b7e9f..0b3a4cc 100644 --- a/arch/