Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Yinghai Lu
On Thu, Feb 14, 2008 at 10:52 PM, Greg KH [EMAIL PROTECTED] wrote: Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. could be two issues: one in cpufreq, and one in detect softlockup... YH - To unsubscribe from

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Jeff Chua
On Fri, Feb 15, 2008 at 2:59 PM, Greg KH [EMAIL PROTECTED] wrote: I swear someone else sent this in, but my archives don't show it at all. I think the patch below should solve this, but I need someone to test it. I tested but it doesn't fix the problem for me. May be my problem is different

[PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Yi Yang
When one cpu is set to offline, the caller process will hang, according to the trace data, the problem lies in the refcount error in cpufreq driver, cpufreq_cpu_callback will wait for completion policy-kobj_unregister which is nerver completed because a refcount error in function

[PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Yi Yang
When one cpu is set to offline, the caller process will hang, according to the trace data, the problem lies in the refcount error in cpufreq driver, cpufreq_cpu_callback will wait for completion policy-kobj_unregister which is nerver completed because a refcount error in function

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Frans Pop
On Friday 15 February 2008, Greg KH wrote: I swear someone sent this patch in before. Can you try this one below, there seems to be an imbalance with kobject_get and _put. I did remember seeing this patch before [1] and can confirm that it does indeed fix the issue: with this patch applied to

RE: [patch 4/6] ACPI processor: extract return values using PTR_ERR

2008-02-15 Thread Thomas, Sujith
-Original Message- From: Zhao, Yakui Sent: Friday, February 15, 2008 12:21 PM To: Thomas, Sujith Cc: [EMAIL PROTECTED]; linux-acpi@vger.kernel.org; Zhang, Rui Subject: Re: [patch 4/6] ACPI processor: extract return values using PTR_ERR On Fri, 2008-02-15 at 10:54 +0530,

Re: 2.6.25-rc1 regression - IBM ACPI backlight

2008-02-15 Thread Lukas Hejtmanek
On Thu, Feb 14, 2008 at 10:24:52AM -0200, Henrique de Moraes Holschuh wrote: as of 2.6.25-rc1, there is no more /sys/class/backlight/acpi_video1 which controlled LVDS backlight on Lenovo ThinkPad T61. There is still acpi_video0 which seems to have sane values but echo N brightness has no

RE: The new thermal management sysfs class, and hwmon

2008-02-15 Thread Thomas, Sujith
On Wed, Feb 13, 2008 at 04:10:50PM +0100, Thomas Renninger wrote: Why do you want to still export the temperature via ACPI sysfs paths then? Once it is there and userspace progs make use of it, you will have to maintain it forever and HAL is getting crazy and must take care about: -

Re: 2.6.25-rc1 regression - IBM ACPI backlight

2008-02-15 Thread Henrique de Moraes Holschuh
On Fri, 15 Feb 2008, Lukas Hejtmanek wrote: On Thu, Feb 14, 2008 at 10:24:52AM -0200, Henrique de Moraes Holschuh wrote: as of 2.6.25-rc1, there is no more /sys/class/backlight/acpi_video1 which controlled LVDS backlight on Lenovo ThinkPad T61. There is still acpi_video0 which seems to

Re: The new thermal management sysfs class, and hwmon

2008-02-15 Thread Matthew Garrett
On Fri, Feb 15, 2008 at 04:34:34PM +0530, Thomas, Sujith wrote: Len had mentioned in one of his responses that there is scope for evolving and we can do that. As you pointed out if there are differences in the way temperatures are reported out, we can go ahead and fix it. That's fine, but

Re: 2.6.25-rc1 regression - IBM ACPI backlight

2008-02-15 Thread Matthew Garrett
On Fri, Feb 15, 2008 at 12:02:13PM +0100, Lukas Hejtmanek wrote: 2.6.24 kernel has two acpi_video[01]. 2.6.25-rc1 does not, it contains only acpi_video0 (even in text mode in single user without X being loaded) which does not work at all. Sigh. Ok. Could you attach the output of acpidump and

Re: [lm-sensors] The new thermal management sysfs class, and hwmon

2008-02-15 Thread Henrique de Moraes Holschuh
On Fri, 15 Feb 2008, Matthew Garrett wrote: On Fri, Feb 15, 2008 at 04:34:34PM +0530, Thomas, Sujith wrote: Len had mentioned in one of his responses that there is scope for evolving and we can do that. As you pointed out if there are differences in the way temperatures are reported out,

Re: 2.6.25-rc1 regression - IBM ACPI backlight

2008-02-15 Thread Lukas Hejtmanek
On Fri, Feb 15, 2008 at 12:07:20PM +, Matthew Garrett wrote: On Fri, Feb 15, 2008 at 12:02:13PM +0100, Lukas Hejtmanek wrote: 2.6.24 kernel has two acpi_video[01]. 2.6.25-rc1 does not, it contains only acpi_video0 (even in text mode in single user without X being loaded) which does not

Re: [linux-pm] [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Alan Stern
On Fri, 15 Feb 2008, Yi Yang wrote: This patch adds kobject_put to balance refcount. I noticed Greg suggests it will fix a power-off issue to remove kobject_get statement block, but i think that isn't the best way because those code block has existed very long and it is helpful because the

Re: [linux-pm] [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 10:52:51AM -0500, Alan Stern wrote: On Fri, 15 Feb 2008, Yi Yang wrote: This patch adds kobject_put to balance refcount. I noticed Greg suggests it will fix a power-off issue to remove kobject_get statement block, but i think that isn't the best way because those

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Yinghai Lu
On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop [EMAIL PROTECTED] wrote: On Friday 15 February 2008, Greg KH wrote: I swear someone sent this patch in before. Can you try this one below, there seems to be an imbalance with kobject_get and _put. I did remember seeing this patch before [1] and

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Yinghai Lu
On Fri, Feb 15, 2008 at 11:38 AM, Yinghai Lu [EMAIL PROTECTED] wrote: On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop [EMAIL PROTECTED] wrote: On Friday 15 February 2008, Greg KH wrote: I swear someone sent this patch in before. Can you try this one below, there seems to be an imbalance

[PATCH] remove is_processor_present prototype

2008-02-15 Thread Glauber Costa
The function itself is defined just below, so this prototype is not really useful. Signed-off-by: Glauber Costa [EMAIL PROTECTED] --- drivers/acpi/processor_core.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/processor_core.c

Re: [PATCH 0/3] Suspend-related cleanups

2008-02-15 Thread Rafael J. Wysocki
On Friday, 15 of February 2008, Len Brown wrote: On Sunday 03 February 2008 17:20, Pavel Machek wrote: Hi! Three suspend-related fixes that IMO can go into 2.6.25 follow. ACK on all three. Yes, these seem easy enough for 2.6.25.

Re: [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 07:48:41AM +0800, Yi Yang wrote: When one cpu is set to offline, the caller process will hang, according to the trace data, the problem lies in the refcount error in cpufreq driver, cpufreq_cpu_callback will wait for completion policy-kobj_unregister which is nerver

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 04:52:18PM +0800, Jeff Chua wrote: On Fri, Feb 15, 2008 at 2:59 PM, Greg KH [EMAIL PROTECTED] wrote: I swear someone else sent this in, but my archives don't show it at all. I think the patch below should solve this, but I need someone to test it. I tested but it

[PATCH] use ACPI_DEBUG_PRINT instead of printk

2008-02-15 Thread Glauber Costa
For consistency, use ACPI_DEBUG_PRINT instead of printk in acpi_processor_hotplug_notify() for BUS_CHECK and DEVICE_CHECK events Signed-off-by: Glauber Costa [EMAIL PROTECTED] --- drivers/acpi/processor_core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

Re: + acpi-use-acpi_debug_print-instead-of-printk.patch added to -mm tree

2008-02-15 Thread Len Brown
Since SuSE ships with CONFIG_ACPI_DEBUG=y, the line between printk and ACPI_DEBUG_PRINT is less clear. I.e. this printk will be present in a production shipping distro kernel even if you move to to ACPI_DEBUG_PRINT from printk. The only variable is the default verbosity level. Thomas, what

Re: [Bugme-new] [Bug 9995] New: 2.6.25-rc1 regression - IBM ACPI backlight controlls do not work

2008-02-15 Thread Andrew Morton
On Fri, 15 Feb 2008 04:51:15 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9995 Summary: 2.6.25-rc1 regression - IBM ACPI backlight controlls do not work Product: ACPI Version: 2.5 KernelVersion:

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 11:19:20AM +0100, Frans Pop wrote: On Friday 15 February 2008, Greg KH wrote: I swear someone sent this patch in before. Can you try this one below, there seems to be an imbalance with kobject_get and _put. I did remember seeing this patch before [1] and can

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 12:41:43AM -0800, Yinghai Lu wrote: On Thu, Feb 14, 2008 at 10:52 PM, Greg KH [EMAIL PROTECTED] wrote: Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. could be two issues: one

Re: [PATCH 0/3] Suspend-related cleanups

2008-02-15 Thread Len Brown
On Sunday 03 February 2008 17:20, Pavel Machek wrote: Hi! Three suspend-related fixes that IMO can go into 2.6.25 follow. ACK on all three. Yes, these seem easy enough for 2.6.25. Pavel 1 2 applied. lets re-send #3

Re: [2.6.25-rc1] System no longer powers off after shutdown

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 11:38:59AM -0800, Yinghai Lu wrote: On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop [EMAIL PROTECTED] wrote: On Friday 15 February 2008, Greg KH wrote: I swear someone sent this patch in before. Can you try this one below, there seems to be an imbalance with

Re: [PATCH] ACPI: Check whether cooling device exists before unregistering it

2008-02-15 Thread Len Brown
applied. thanks, -len On Thursday 14 February 2008 19:34, Zhao Yakui wrote: Subject: ACPI: Check whether cooling device exists before unregistering it From : Zhao Yakui [EMAIL PROTECTED] OS should check whether the cooling device exists before it is unregistered. If it doesn't exists, it

Re: + acpi-use-acpi_debug_print-instead-of-printk.patch added to -mm tree

2008-02-15 Thread Glauber Costa
Len Brown wrote: I.e. this printk will be present in a production shipping distro kernel even if you move to to ACPI_DEBUG_PRINT from printk. Yes, but you can still disable it. And if you do, all the messages will vanish, but this will stay. The only variable is the default verbosity level.

Re: [Bugme-new] [Bug 9995] New: 2.6.25-rc1 regression - IBM ACPI backlight controlls do not work

2008-02-15 Thread Matthew Garrett
No, this one is a bug. I'll try to deal with it. -- Matthew Garrett | [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 4/6] ACPI processor: extract return values using PTR_ERR

2008-02-15 Thread Len Brown
refreshed in acpi-test branch. thanks, -len On Friday 15 February 2008 05:46, Thomas, Sujith wrote: -Original Message- From: Zhao, Yakui Sent: Friday, February 15, 2008 12:21 PM To: Thomas, Sujith Cc: [EMAIL PROTECTED]; linux-acpi@vger.kernel.org; Zhang, Rui Subject: Re:

[PATCH] acer-wmi - Add DMI match for mail LED on Acer TravelMate 4200 series

2008-02-15 Thread Carlos Corbacho
The TM4200 series use the same method as the TM2490 series to control the mail LED, so add a DMI based quirk for these laptops. Signed-off-by: Carlos Corbacho [EMAIL PROTECTED] CC: Len Brown [EMAIL PROTECTED] --- drivers/misc/acer-wmi.c |9 + 1 files changed, 9 insertions(+), 0

[PATCH 1/9] ACPI: thinkpad-acpi: trivial fix to module_desc typo

2008-02-15 Thread Henrique de Moraes Holschuh
Thanks to Damjan [EMAIL PROTECTED] for noticing this one. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] --- drivers/misc/thinkpad_acpi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c index

[PATCH 2/9] ACPI: thinkpad-acpi: trivial fix to documentation

2008-02-15 Thread Henrique de Moraes Holschuh
Fix a stray ibm-acpi that should have been replaced with thinkpad-acpi. Thanks to Damjan [EMAIL PROTECTED] for noticing this one. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] --- Documentation/laptops/thinkpad-acpi.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 3/9] ACPI: thinkpad-acpi: always track input device open/close

2008-02-15 Thread Henrique de Moraes Holschuh
The open() and close() hooks for the input device are useful even when hotkey NVRAM polling support is not in use, so it is better to always have them around. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] --- drivers/misc/thinkpad_acpi.c | 13 - 1 files changed, 8

[GIT PATCH] thinkpad-acpi queue for 2.6.25-rc3

2008-02-15 Thread Henrique de Moraes Holschuh
Len, This patchset has my current thinkpad-acpi queue with fixes that should go into 2.6.25-rc. There are some minor obviously correct fixes, some typo fixes, and an event interface change that I'd rather get into 2.6.25, since the interface that is being changed was introduced in my previous

[PATCH 9/9] ACPI: thinkpad-acpi: add tablet-mode reporting

2008-02-15 Thread Henrique de Moraes Holschuh
A quick study of the 0x5009/0x500A HKEY event on the X61t DSDT revealed the existence of the EC HTAB register (EC 0x0f, bit 7), and a compare with the X41t DSDT shows that HKEY.MHKG can be used to verify if the ThinkPad is tablet-capable (MHKG present), and in tablet mode (bit 3 of MHKG return is

[PATCH 7/9] ACPI: thinkpad-acpi: improve thinkpad-acpi input device documentation

2008-02-15 Thread Henrique de Moraes Holschuh
Fix a few spelling errors, and also document the EV_SW events thinkpad-acpi can issue. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] --- Documentation/laptops/thinkpad-acpi.txt | 48 +- 1 files changed, 27 insertions(+), 21 deletions(-) diff --git

[PATCH 8/9] ACPI: thinkpad-acpi: minor hotkey_radio_sw fixes

2008-02-15 Thread Henrique de Moraes Holschuh
Fixes some minor points in the radio switch code and docs. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] --- Documentation/laptops/thinkpad-acpi.txt |2 +- drivers/misc/thinkpad_acpi.c|8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 5/9] ACPI: thinkpad-acpi: make the video output feature optional

2008-02-15 Thread Henrique de Moraes Holschuh
The video output port control feature is not very useful on many ThinkPads (especially when a X server is running), and lately userspace is getting better and better at it, so it makes sense to allow users to stripe out the thinkpad-acpi video feature from their kernels and save at least 2KB.

[PATCH 6/9] ACPI: thinkpad-acpi: issue input events for tablet swivel events

2008-02-15 Thread Henrique de Moraes Holschuh
Issue EV_SW SW_TABLET_MODE events for HKEY events 0x5009 and 0x500A on the X41t/X60t/X61t. As usual, we suppress the HKEY events on the netlink interface to avoid sending duplicate events to userspace. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] ---

i386 warnings in acpi-test

2008-02-15 Thread Andrew Morton
arch/x86/kernel/acpi/sleep.c: In function 'acpi_save_state_mem': arch/x86/kernel/acpi/sleep.c:55: warning: passing argument 1 of 'native_store_gdt' from incompatible pointer type arch/x86/kernel/acpi/sleep.c:71: warning: assignment makes integer from pointer without a cast

Re: [PATCH 5/9] ACPI: thinkpad-acpi: make the video output feature optional

2008-02-15 Thread Len Brown
On Friday 15 February 2008 23:17, Henrique de Moraes Holschuh wrote: The video output port control feature is not very useful on many ThinkPads (especially when a X server is running), and lately userspace is getting better and better at it, so it makes sense to allow users to stripe out the

Re: [PATCH] acer-wmi - Add DMI match for mail LED on Acer TravelMate 4200 series

2008-02-15 Thread Len Brown
applied thanks, -len On Friday 15 February 2008 19:02, Carlos Corbacho wrote: The TM4200 series use the same method as the TM2490 series to control the mail LED, so add a DMI based quirk for these laptops. Signed-off-by: Carlos Corbacho [EMAIL PROTECTED] CC: Len Brown [EMAIL PROTECTED]

Re: i386 warnings in acpi-test

2008-02-15 Thread Len Brown
yeah, i know. Linus personally created this one last week. We're waiting for him to cool off before we re-suggest a patch that actually works:-) -Len On Friday 15 February 2008 23:47, Andrew Morton wrote: arch/x86/kernel/acpi/sleep.c: In function 'acpi_save_state_mem':