Hello.....
This is to inform you that Turkey Financier here in Turkey offers loan to anyone who might be in need of a loan for any financial concern. Should you be interested in applying for a business or personal loan, you are required to send an enquiry to us for further proceedings. We offer loan services 24 hours for 7 days of the week (24*7). Yours Faithfully, Salman H. Usmani, Loan and trade credit
Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere
Arnd Bergmann writes: > diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl > b/arch/powerpc/kernel/syscalls/syscall.tbl > index b18abb0c3dae..00f5a63c8d9a 100644 > --- a/arch/powerpc/kernel/syscalls/syscall.tbl > +++ b/arch/powerpc/kernel/syscalls/syscall.tbl > @@ -505,3 +505,7 @@ > 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait > compat_sys_rt_sigtimedwait_time64 > 422 32 futex_time64sys_futex > sys_futex > 423 32 sched_rr_get_interval_time64sys_sched_rr_get_interval > sys_sched_rr_get_interval > +424 common pidfd_send_signal sys_pidfd_send_signal > +425 common io_uring_setup sys_io_uring_setup > +426 common io_uring_enter sys_io_uring_enter > +427 common io_uring_register sys_io_uring_register Acked-by: Michael Ellerman (powerpc) Lightly tested. The pidfd_test selftest passes. Ran the io_uring example from fio, which prints lots of: IOPS=209952, IOS/call=32/32, inflight=117 (117), Cachehit=0.00% IOPS=209952, IOS/call=32/32, inflight=116 (116), Cachehit=0.00% IOPS=209920, IOS/call=32/32, inflight=115 (115), Cachehit=0.00% IOPS=209952, IOS/call=32/32, inflight=115 (115), Cachehit=0.00% IOPS=209920, IOS/call=32/32, inflight=115 (115), Cachehit=0.00% IOPS=209952, IOS/call=32/32, inflight=115 (115), Cachehit=0.00% IOPS=210016, IOS/call=32/32, inflight=114 (114), Cachehit=0.00% IOPS=210016, IOS/call=32/32, inflight=113 (113), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=113 (113), Cachehit=0.00% IOPS=210016, IOS/call=32/32, inflight=113 (113), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=112 (112), Cachehit=0.00% IOPS=210016, IOS/call=32/32, inflight=110 (110), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=105 (105), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=104 (104), Cachehit=0.00% IOPS=210080, IOS/call=32/32, inflight=102 (102), Cachehit=0.00% IOPS=210112, IOS/call=32/32, inflight=100 (100), Cachehit=0.00% IOPS=210080, IOS/call=32/32, inflight=97 (97), Cachehit=0.00% IOPS=210112, IOS/call=32/32, inflight=97 (97), Cachehit=0.00% IOPS=210112, IOS/call=32/31, inflight=126 (126), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=126 (126), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=125 (125), Cachehit=0.00% IOPS=210016, IOS/call=32/32, inflight=119 (119), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=117 (117), Cachehit=0.00% IOPS=210016, IOS/call=32/32, inflight=114 (114), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=111 (111), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=108 (108), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=107 (107), Cachehit=0.00% IOPS=210048, IOS/call=32/32, inflight=105 (105), Cachehit=0.00% Which is good I think? cheers
Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere
Arnd Bergmann writes: > On Sun, Mar 31, 2019 at 5:47 PM Michael Ellerman wrote: >> >> Arnd Bergmann writes: >> > Add the io_uring and pidfd_send_signal system calls to all architectures. >> > >> > These system calls are designed to handle both native and compat tasks, >> > so all entries are the same across architectures, only arm-compat and >> > the generic tale still use an old format. >> > >> > Signed-off-by: Arnd Bergmann >> > --- >> > arch/alpha/kernel/syscalls/syscall.tbl | 4 >> > arch/arm/tools/syscall.tbl | 4 >> > arch/arm64/include/asm/unistd.h | 2 +- >> > arch/arm64/include/asm/unistd32.h | 8 >> > arch/ia64/kernel/syscalls/syscall.tbl | 4 >> > arch/m68k/kernel/syscalls/syscall.tbl | 4 >> > arch/microblaze/kernel/syscalls/syscall.tbl | 4 >> > arch/mips/kernel/syscalls/syscall_n32.tbl | 4 >> > arch/mips/kernel/syscalls/syscall_n64.tbl | 4 >> > arch/mips/kernel/syscalls/syscall_o32.tbl | 4 >> > arch/parisc/kernel/syscalls/syscall.tbl | 4 >> > arch/powerpc/kernel/syscalls/syscall.tbl| 4 >> >> Have you done any testing? >> >> I'd rather not wire up syscalls that have never been tested at all on >> powerpc. > > No, I have not. I did review the system calls carefully and added the first > patch to fix the bug on x86 compat mode before adding the same bug > on the other compat architectures though ;-) > > Generally, my feeling is that adding system calls is not fundamentally > different from adding other ABIs, and we should really do it at > the same time across all architectures, rather than waiting for each > maintainer to get around to reviewing and testing the new calls > first. This is not a problem on powerpc, but a lot of other architectures > are less active, which is how we have always ended up with > different sets of system calls across architectures. Well it's still something of a problem on powerpc. No one has volunteered to test io_uring on powerpc, so at this stage it will go in completely untested. If there was a selftest in the tree I'd be a bit happier, because at least then our CI would start testing it as soon as the syscalls were wired up in linux-next. And yeah obviously I should test it, but I don't have infinite time unfortunately. > The problem here is that this makes it harder for the C library to > know when a system call is guaranteed to be available. glibc > still needs a feature test for newly added syscalls to see if they > are working (they might be backported to an older kernel, or > disabled), but whenever the minimum kernel version is increased, > it makes sense to drop those checks and assume non-optional > system calls will work if they were part of that minimum version. But that's the thing, if we just wire them up untested they may not actually work. And then you have the far worse situation where the syscall exists in kernel version x but does not actually work properly. See the mess we have with pkeys for example. > In the future, I'd hope that any new system calls get added > right away on all architectures when they land (it was a bit > tricky this time, because I still did a bunch of reworks that > conflicted with the new calls). Bugs will happen of course, but > I think adding them sooner makes it more likely to catch those > bugs early on so we have a chance to fix them properly, > and need fewer arch specific workarounds (ideally none) > for system calls. For syscalls that have a selftest in the tree, and don't rely on anything arch specific I agree. I'm a bit more wary of things that are not easily tested and have the potential to work differently across arches. cheers