Re: [PATCH 03/21] ia64: rename ioremap_nocache to ioremap_uc

[Sergei Shtylyov]

Hello!

On 17.10.2019 20:45, Christoph Hellwig wrote:


On ia64 ioremap_nocache fails if attributs don't match.  Not other


  Attributes?


architectures does this, and we plan to get rid of ioremap_nocache.
So get rid of the special semantics and define ioremap_nocache in
terms of ioremap as no portable driver could rely on the behavior
anyway.

However x86 implements ioremap_uc with a in a similar way as the ia64


   With a what?


version of ioremap_nocache, so implement that instead.

Signed-off-by: Christoph Hellwig 
---
  arch/ia64/include/asm/io.h | 6 +++---
  arch/ia64/mm/ioremap.c | 4 ++--
  2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index 54e70c21352a..fec9df9609ed 100644
--- a/arch/ia64/include/asm/io.h
+++ b/arch/ia64/include/asm/io.h

[...]

MBR, Sergei

Re: [PATCH 20/21] csky: remove ioremap_cache

[Guo Ren]

Acked-by: Guo Ren 

On Fri, Oct 18, 2019 at 1:47 AM Christoph Hellwig  wrote:
>
> No driver that can be used on csky uses ioremap_cache, and this
> interface has been deprecated in favor of memremap.
>
> Signed-off-by: Christoph Hellwig 
> ---
>  arch/csky/include/asm/io.h | 2 --
>  arch/csky/mm/ioremap.c | 7 ---
>  2 files changed, 9 deletions(-)
>
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index a4b9fb616faa..f572605d5ad5 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -36,13 +36,11 @@
>  /*
>   * I/O memory mapping functions.
>   */
> -extern void __iomem *ioremap_cache(phys_addr_t addr, size_t size);
>  extern void __iomem *__ioremap(phys_addr_t addr, size_t size, pgprot_t prot);
>  extern void iounmap(void *addr);
>
>  #define ioremap(addr, size)__ioremap((addr), (size), 
> pgprot_noncached(PAGE_KERNEL))
>  #define ioremap_wc(addr, size) __ioremap((addr), (size), 
> pgprot_writecombine(PAGE_KERNEL))
> -#define ioremap_cache  ioremap_cache
>
>  #include 
>
> diff --git a/arch/csky/mm/ioremap.c b/arch/csky/mm/ioremap.c
> index e13cd3497628..ae78256a56fd 100644
> --- a/arch/csky/mm/ioremap.c
> +++ b/arch/csky/mm/ioremap.c
> @@ -44,13 +44,6 @@ void __iomem *__ioremap(phys_addr_t phys_addr, size_t 
> size, pgprot_t prot)
>  }
>  EXPORT_SYMBOL(__ioremap);
>
> -void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size)
> -{
> -   return __ioremap_caller(phys_addr, size, PAGE_KERNEL,
> -   __builtin_return_address(0));
> -}
> -EXPORT_SYMBOL(ioremap_cache);
> -
>  void iounmap(void __iomem *addr)
>  {
> vunmap((void *)((unsigned long)addr & PAGE_MASK));
> --
> 2.20.1
>


-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/